diff mbox series

[Concept,25/29] patman: Keep code quotes out of the cover-letter review

Message ID 20260501110040.1874719-26-sjg@u-boot.org
State New
Headers
Series patman: Review-flow improvements and shared helpers |

Commit Message

Simon Glass May 1, 2026, 11 a.m. UTC 
  From: Simon Glass <sjg@chromium.org>

The cover-letter review prompt let the agent insert inline code
snippets to illustrate series-level points. The snippets end up
indented plain text with no diff header, and sometimes refer to code
outside the series (e.g. a previously reverted patch), which the
recipient cannot verify from the series being reviewed.

Tell the agent to stick to prose in the cover-letter reply; code
examples belong in the per-patch reviews where they can be quoted
properly from the diff.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 tools/patman/review.py | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.43.0
diff mbox series

Patch

diff --git a/tools/patman/review.py b/tools/patman/review.py
index 29f618641bd..eb8a3da63b3 100644
--- a/tools/patman/review.py
+++ b/tools/patman/review.py
@@ -511,6 +511,9 @@  Rules:
   quote identifiers that are obviously code (e.g. CONFIG_FOO)
 - Never put a period directly after a code identifier — rephrase,
   omit the period, or use an em dash to start the next clause
+- Do NOT quote code fragments in the cover-letter reply — code
+  belongs in the per-patch reviews. Describe series-level issues in
+  prose only.
 - Use {ctx.spelling} spelling
 - Be brief — only raise series-level concerns, not per-patch nits
 - Do NOT repeat issues that belong on individual patches