From patchwork Fri May 1 11:00:17 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2268 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1777633332; bh=wCPvxetNysPaPo2wQprjcLjgnULO3LumQneV6BegbdI=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=Zdv973Azol9k45denYWMrEqk32VpkIF/B0m2TQT85UrG2tq6uYm5aAtyRqC0eZy1z bICj68ssFeuiCrJdE0WoXuQGAsl9UIu57Gtw/ommjIQXGaaDjDDuwCVjDUx1faNJiZ 1tcMyrVsakmkOo2emZdrt8FVuefYxzXNk/ca3Z/g= Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id E9C0E6A848 for ; Fri, 1 May 2026 05:02:12 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Y_j6Vv2SPvOa for ; Fri, 1 May 2026 05:02:12 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1777633331; bh=wCPvxetNysPaPo2wQprjcLjgnULO3LumQneV6BegbdI=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=ooJbqxcunJaVdulpBpffX8TszYETFI79g2EQlqNwMP/cLIHz5ZQuewVNW9Zqpa8aO IiWplcdMs5AKeQH7cgGNuDpMeB1P37Da7Mn3pAb3LzuJxtHy+NsWco4JSJ/STbreru ICKUZQjgDT0EUr7OJ+tFXO221fQRGPao0Y64GwLY= Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 2225A6A857 for ; Fri, 1 May 2026 05:02:11 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1777633326; bh=DbI9PAMZYSKg7BGwZJssaJehSeIvZkubdFJDTjkv1Y0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r48yZW9MrdHVYsderPVRjPlIwCsxjhBzUoPrFgv6zv4SoDsf4OwcT5iqC5xvM9Fn0 M///FMn3p8a4paUC7gKJJDO8Shu3zYDG5b2pvXqkZYZzAhY3ZvsBFoirbbtt+kVikN 1fIJNl7C+P9OwOrXNIjK6tO4wZdsl2+24O8hRMm0= Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id DAA9A6A833; Fri, 1 May 2026 05:02:06 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id Ve0DgJS77-HC; Fri, 1 May 2026 05:02:06 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1777633326; bh=VHOhx/nX2Efen/+iWa0XyBJfv5YzLaz43H7UstTnQiI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OegmJZeMLq9+1HCuFWOaCFoFHvCTtmVjHGFEMse64qkoDlXePKwkyQr54gQzsq2EN cvQ1KEfOVJEB0RAo5XE+npfdghbTyw3ogCzkKK480dRF9DEvQ8SghNC083/jnNXsre rNHpEW9z53o0PbEzN2NPkadhBGDYexktqJFh45Jw= Received: from u-boot.org (unknown [174.51.25.52]) by mail.u-boot.org (Postfix) with ESMTPSA id 733636A834; Fri, 1 May 2026 05:02:06 -0600 (MDT) From: Simon Glass To: U-Boot Concept Date: Fri, 1 May 2026 05:00:17 -0600 Message-ID: <20260501110040.1874719-26-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260501110040.1874719-1-sjg@u-boot.org> References: <20260501110040.1874719-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: 7G4NUAJVQU6NFYSCH5ZB4LDORNFMXBQP X-Message-ID-Hash: 7G4NUAJVQU6NFYSCH5ZB4LDORNFMXBQP X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Glass X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 25/29] patman: Keep code quotes out of the cover-letter review List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass The cover-letter review prompt let the agent insert inline code snippets to illustrate series-level points. The snippets end up indented plain text with no diff header, and sometimes refer to code outside the series (e.g. a previously reverted patch), which the recipient cannot verify from the series being reviewed. Tell the agent to stick to prose in the cover-letter reply; code examples belong in the per-patch reviews where they can be quoted properly from the diff. Signed-off-by: Simon Glass --- tools/patman/review.py | 3 +++ 1 file changed, 3 insertions(+) -- 2.43.0 diff --git a/tools/patman/review.py b/tools/patman/review.py index 29f618641bd..eb8a3da63b3 100644 --- a/tools/patman/review.py +++ b/tools/patman/review.py @@ -511,6 +511,9 @@ Rules: quote identifiers that are obviously code (e.g. CONFIG_FOO) - Never put a period directly after a code identifier — rephrase, omit the period, or use an em dash to start the next clause +- Do NOT quote code fragments in the cover-letter reply — code + belongs in the per-patch reviews. Describe series-level issues in + prose only. - Use {ctx.spelling} spelling - Be brief — only raise series-level concerns, not per-patch nits - Do NOT repeat issues that belong on individual patches