From patchwork Sat Apr 4 21:29:03 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2142 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1775338379; bh=/T4oxHDP1sUrlqiQ1KfC5LbplVJ2qLA5JjkfX0GRU5o=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=T8SmFayIwZ0NI08CIaVz/AhFU5lih/HS1Ah19Qku9r4M6MezDq8kYdIJ1VqkKNJ7E LatWSNkzofvlSQBqk+oLcXZued2nQC6OzBVjqb3RFmCb18I8sriZgZvCDlhkucufDV RY3w5mCo3y6RcJsucsWFH6w+pVdIVzZpSx/nO18K1EGhd1FBhTKxBRSpf0QdO/GqlY P09Ik487M0N4BurFOT6AnDEULoXEPukyA8mnwBYyOir28SNbaILqTKNBV6DLJDftPL 6DOz9AUjlIVhMElonC9aIVVPmaKW7q23c/qF08QuoRoFiLLGUJV+h4ymCRbOfmiVsx rG2pzrlvMz2oQ== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 6A6115FC8F for ; Sat, 4 Apr 2026 15:32:59 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id IUKLhOz_Pqjk for ; Sat, 4 Apr 2026 15:32:59 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1775338379; bh=/T4oxHDP1sUrlqiQ1KfC5LbplVJ2qLA5JjkfX0GRU5o=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=T8SmFayIwZ0NI08CIaVz/AhFU5lih/HS1Ah19Qku9r4M6MezDq8kYdIJ1VqkKNJ7E LatWSNkzofvlSQBqk+oLcXZued2nQC6OzBVjqb3RFmCb18I8sriZgZvCDlhkucufDV RY3w5mCo3y6RcJsucsWFH6w+pVdIVzZpSx/nO18K1EGhd1FBhTKxBRSpf0QdO/GqlY P09Ik487M0N4BurFOT6AnDEULoXEPukyA8mnwBYyOir28SNbaILqTKNBV6DLJDftPL 6DOz9AUjlIVhMElonC9aIVVPmaKW7q23c/qF08QuoRoFiLLGUJV+h4ymCRbOfmiVsx rG2pzrlvMz2oQ== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 57BBF6833B for ; Sat, 4 Apr 2026 15:32:59 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1775338377; bh=++uXSoZpQTCDLZffLF2AICqm5o3236y5pK/u3dUIlR8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bV0umPQwHqatorWuBWuF4FtOSTOHxzd3YyhRNtjqvLEdtbIOlQGL14TnyJowKoIB/ Iqhdr+fRDGYoo1Ch3gOTLs/ufZYR/w+JF8w4t/IO5uzhFKuCsXERyywl7+qOJYNaGN +bu7+fUYNRCSA311HEZGCUJjrxq6TfouNDY/PJDUMd7xsR501zqZcX0aGOcSRIvv7r SnO2G70Vy9qYuVXjDl0LfNh4L9FJpRW44gny/GZ7KPnNBkE0fjO/tob6XNTBeBsK2Y jQVuQTDbqiE739v8RsHKobDipo/JNlB1tZKE/i2vgY3qjmgqiVtcGk2vi/M8IsF6Vk qeEyjo0aKUq9Q== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id A268D5FC8F; Sat, 4 Apr 2026 15:32:57 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id UyltlHiQQSqZ; Sat, 4 Apr 2026 15:32:57 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1775338373; bh=UzzU0IqJGtb710nVrVpWc1nCwt/bXqgEwxZEqRJFjGo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lopQqnorHEb2NtQJrx5Rxo1LUEaM01z3LfD4ibDm1PmdSAtcjAMDYmLW9/ZTK2U5u lqCdzBPD5Bs+YRP+nmRKNwEElB4p878mt4pdajLhdpuAo+M+MPWPyqxI4+sRi2OSOe +Orvy3aJMvLJaJJhn9JV17ttB1QAxy/EbwIWOwVEByCBGCt3O5JTGm8z27MnQ2pbkk rMAFpUxYwDRXx297XftWEjtE6ZVma4hrjQLfExS0DI+GLJbv6X9ULsiIB1FZ1FWSTC Fhg+8kWL5X/V9CO7+suPQteFKiiC0454XsTLpkM0Y19n45NCaG3dKRfnA9r3zOG7PX VStcDtzmQBkOg== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 8E9315E7B4; Sat, 4 Apr 2026 15:32:53 -0600 (MDT) From: Simon Glass To: U-Boot Concept Date: Sat, 4 Apr 2026 15:29:03 -0600 Message-ID: <20260404213020.372253-28-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260404213020.372253-1-sjg@u-boot.org> References: <20260404213020.372253-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: S44PQDQF3P4OWBOEHRPJ3D5VKJ6WGINL X-Message-ID-Hash: S44PQDQF3P4OWBOEHRPJ3D5VKJ6WGINL X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Glass X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 27/37] patman: Add notes field to SerVer namedtuple List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass The notes column exists in the ser_ver table but the SerVer namedtuple and its SELECT queries do not include it. Add the field and update all queries to select it. Also fix SerVer construction in cser_helper to include the extra None for the notes position. Signed-off-by: Simon Glass --- tools/patman/cser_helper.py | 4 ++-- tools/patman/database.py | 7 ++++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/tools/patman/cser_helper.py b/tools/patman/cser_helper.py index 7979deda6dc..31a5e3663dc 100644 --- a/tools/patman/cser_helper.py +++ b/tools/patman/cser_helper.py @@ -1370,10 +1370,10 @@ class CseriesHelper: updated += 1 if cover: info = SerVer(svid, None, None, None, cover.id, - cover.num_comments, cover.name, None, None) + cover.num_comments, cover.name, None, None, None) else: info = SerVer(svid, None, None, None, None, None, patches[0].name, - None, None) + None, None, None) self.db.ser_ver_set_info(info) return updated, 1 if cover else 0 diff --git a/tools/patman/database.py b/tools/patman/database.py index 8a96030b68f..50b9ea0dca5 100644 --- a/tools/patman/database.py +++ b/tools/patman/database.py @@ -39,7 +39,7 @@ Review = namedtuple( SerVer = namedtuple( 'SER_VER', 'idnum,series_id,version,link,cover_id,cover_num_comments,name,' - 'archive_tag,desc') + 'archive_tag,desc,notes') # Record from the pcommit table: # idnum (int): record ID @@ -783,7 +783,7 @@ class Database: # pylint:disable=R0904 ValueError: There is no matching idnum/version """ base = ('SELECT id, series_id, version, link, cover_id, ' - 'cover_num_comments, name, archive_tag, desc ' + 'cover_num_comments, name, archive_tag, desc, notes ' 'FROM ser_ver WHERE series_id = ?') if version: res = self.execute(base + ' AND version = ?', @@ -825,7 +825,8 @@ class Database: # pylint:disable=R0904 """ res = self.execute( 'SELECT id, series_id, version, link, cover_id, ' - 'cover_num_comments, name, archive_tag, desc FROM ser_ver') + 'cover_num_comments, name, archive_tag, desc, notes ' + 'FROM ser_ver') items = res.fetchall() return [SerVer(*x) for x in items]