| Message ID | 20260316183050.3855921-18-sjg@u-boot.org |
|---|---|
| State | New |
| Headers |
Return-Path: <concept-bounces+u-boot-concept=u-boot.org@u-boot.org> X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1773685899; bh=smxRl2aq31hYmTV2UbLx/sFV7eL98jxfY1gApWj8y84=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=TSzDg8xV9u42P1gJABigJvucU3J7ntz5QzdhLF78UbwYRSyxsbeiLmhlwXcAFNJPT 668KriP2d7oVbNHWZyckNQGMXjQhPB2qnZjVQTdTOOyy/FNKnf1YSbnfYCbJsci3zF FUli4F/BdY5R6J+SP/JaHYPrCU+SqHV9yI/yV6f1XC+AJ7j2EdkZoLq+iIJ+VaaF2/ wxI+0ruQvNoD/sQCijfylnc4aFKhZBh1BKQXH/1/mpRWk9XSD37m9gage9K1QSVH5Y rEhgO+XyHCURfAZIG47G/OElGRurfg02Y36+tG2AGMP/KfeedPn7lq24r0PkCZAfEt dt8xNhRJuKnWg== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 413266A0A5 for <u-boot-concept@u-boot.org>; Mon, 16 Mar 2026 12:31:39 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id DSMkImkRsfnv for <u-boot-concept@u-boot.org>; Mon, 16 Mar 2026 12:31:39 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1773685898; bh=smxRl2aq31hYmTV2UbLx/sFV7eL98jxfY1gApWj8y84=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=Y2H5Ws84VrTOGb5v2++/uWB0D4KB7KCQ+RQdEt3kbo3iH6Jk7kOnHTRyx0318NUeo YS0ZViVfnP/sjUSQz1c/8NUZNiE2lnNZUTFDXJCjJGpnIuaqczGSd3j00ox1PF36k5 KB5Jp3keAPleS8iXz92FuU8+1921L+6RHwJ4rHWya5RxrtPq0rg6mmZQreDoGOi9Tl iOROiUtfkSLPRaXFqwDiN0v/JJJdIT/SJJ1lMCT3sQgPAVmpvsFjfgau6kHHEJo9ko Hh4LF69P8ja0GD3YIBd6xJ3lDSUcvlCz3SUUyyVDDC91iz98IyWSns3o20+4yXboot mT2RgG8eiGaIw== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id AA5906A09B for <u-boot-concept@u-boot.org>; Mon, 16 Mar 2026 12:31:38 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1773685896; bh=QEXHtkeDCh6UAfgmVUIQcDTe0l5jQd7U7n97/GR/x2c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Jsenmsw0YZL0CTMuCUHQyhBSKmQeGL9sMjE9QLmVJJRDAcXB3s9x6FlLdAUS0zceN EoviBMN5s+poZNfg8FpfMTg/WlLIc4GUVgv1R170BptFOdLrfb7G6kKOQGj1EJ8ZtL HghFBAcbC2ge/cPrm4g1KDIuyplVB1KfPPquddrCqOPH1daOiddNLm6DeVwI8F7003 5S6TN69srS0kIyyau3k4QlWhR9AToQAT2eEVpSxApS2dEuEZ5N2GKZX6lxAol+5uav OawcNsNJLSjTnAEV7HngkVdGaXGhFSjwsBaPxJ45HdRBGmz83sgfoHWXhYOkIfPLai rF5L/i7vDuMcw== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 367156A081; Mon, 16 Mar 2026 12:31:36 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id OSVhNitBVCs9; Mon, 16 Mar 2026 12:31:36 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1773685893; bh=qmGWhLXrNQvtTTu4ybe3VYpkBifRxSKIxuwZujq46XI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=k+WxneF7B5F9pfPfNHPXrqWq5PwTPA+ENFW1vlm86AF9yRIK26TFSpnKUYx/zQSAO suwTEWb/zNwB8Y9pNx9kp58kgA0rg/O76mRm4I4ramFdxatvmYDcAvetBY/KijLJAV etbIeDKhyAR8N4YO3Jd5WOkAtQjWue11H2+38dHYCTrhFG+MaRi8UAXud2BpHH5rV3 ZFLRI+QVvrELGrWgjq5Wn6CBD8cH06KPVs38gFMt1orcKWTnYWzWOO5da5Lm9YZTJG nIia+cWhnWfBsLDRTLwi1rftAjQLXlFf3IuaStLDLowtIFk4a4e9+N6sQRRckEd9Nx wFurg0E2kjG8w== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id F27CA6A09E; Mon, 16 Mar 2026 12:31:32 -0600 (MDT) From: Simon Glass <sjg@u-boot.org> To: U-Boot Concept <concept@u-boot.org> Date: Mon, 16 Mar 2026 12:30:40 -0600 Message-ID: <20260316183050.3855921-18-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260316183050.3855921-1-sjg@u-boot.org> References: <20260316183050.3855921-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: D446THBMZWF2R6WCOJKXRGB5JOYDONXL X-Message-ID-Hash: D446THBMZWF2R6WCOJKXRGB5JOYDONXL X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Glass <sjg@chromium.org> X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 17/17] video: Fix map_to_sysmem() leak in show_splash() List-Id: Discussion and patches related to U-Boot Concept <concept.u-boot.org> Archived-At: <https://lists.u-boot.org/archives/list/concept@u-boot.org/message/D446THBMZWF2R6WCOJKXRGB5JOYDONXL/> List-Archive: <https://lists.u-boot.org/archives/list/concept@u-boot.org/> List-Help: <mailto:concept-request@u-boot.org?subject=help> List-Owner: <mailto:concept-owner@u-boot.org> List-Post: <mailto:concept@u-boot.org> List-Subscribe: <mailto:concept-join@u-boot.org> List-Unsubscribe: <mailto:concept-leave@u-boot.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit |
| Series |
Add automatic memory-leak detection to U-Boot tests
|
|
Commit Message
Simon Glass
March 16, 2026, 6:30 p.m. UTC
From: Simon Glass <sjg@chromium.org> show_splash() calls map_to_sysmem() to convert the splash image pointer to a physical address but never unmaps it, leaking a sandbox memory-mapping entry. Add the missing unmap_sysmem() call. Fixes: 84e63abfff67 ("video: Support showing the U-Boot logo") Signed-off-by: Simon Glass <sjg@chromium.org> --- drivers/video/video-uclass.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/video/video-uclass.c b/drivers/video/video-uclass.c index b492ff313aa..20d98798520 100644 --- a/drivers/video/video-uclass.c +++ b/drivers/video/video-uclass.c @@ -661,6 +661,7 @@ static int show_splash(struct udevice *dev) data = video_image_getptr(u_boot); ret = video_bmp_display(dev, map_to_sysmem(data), -4, 4, true); + unmap_sysmem(data); return 0; }