From patchwork Thu Feb 26 20:00:34 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1965 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1772136203; bh=pA3cShkcU+qB6k7ax66zWgmbvksKp/Eux7aIvR7jqwQ=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=OdjTXJNlT63DxaJfxg5vwpNFOIFPCOspfHgkOx5S/HMNdnFq4U85osmkHY+Lg2sS5 gzsX6O9p1410ub8FzjC2AdRF+oRoO0rQptlrnqWcTBRNSXH40uRU+snJPvwipGe22W sQHXBV6zr7D47nIZdhroVulr87w5kxJVMgW0IDaQIKjI9Ky9CuIYZOCCy6pfuRBnZ4 Q7fgETMtfhfRiM70id2h34u90fYvhu9jfi2rxIWnaI5x3VoZqBjqkdZtWb0friLbWg blleUAvb9WdFvN435COwnpk6TCYWKYDXbULzkAVLD9y9gx2TAPo47ZJTsk8x3s7D9T WTINpEX0fVsxg== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 7F91F69E35 for ; Thu, 26 Feb 2026 13:03:23 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id b59fy0y5Mkeg for ; Thu, 26 Feb 2026 13:03:23 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1772136203; bh=pA3cShkcU+qB6k7ax66zWgmbvksKp/Eux7aIvR7jqwQ=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=OdjTXJNlT63DxaJfxg5vwpNFOIFPCOspfHgkOx5S/HMNdnFq4U85osmkHY+Lg2sS5 gzsX6O9p1410ub8FzjC2AdRF+oRoO0rQptlrnqWcTBRNSXH40uRU+snJPvwipGe22W sQHXBV6zr7D47nIZdhroVulr87w5kxJVMgW0IDaQIKjI9Ky9CuIYZOCCy6pfuRBnZ4 Q7fgETMtfhfRiM70id2h34u90fYvhu9jfi2rxIWnaI5x3VoZqBjqkdZtWb0friLbWg blleUAvb9WdFvN435COwnpk6TCYWKYDXbULzkAVLD9y9gx2TAPo47ZJTsk8x3s7D9T WTINpEX0fVsxg== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 6EB1769E39 for ; Thu, 26 Feb 2026 13:03:23 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1772136202; bh=XOXDRKgYaEqDlLkVwYunx4Fjqigd8jqbkqAlwMqjvb0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a80tc7ouzi9kWk/gmfByOjiv8i0Hkji+kg2eDM19bpg9u5MW8+f2n7RNHoAZqZ6iB LgNF+PoFf1j5Ejsl5Hvs2Obhu5+QGwATuMwDECMouEEYcx/I9ZLdaK3M7Con0AR+kX iDvKGoikPV59HfgC2e8oHBJXoHAur2I+NPJpQym1V8ehB6dXOSB18q8sr0d20sLd2w k51ZQy+aCQ2dm1PZkCZocbaHRWf1JwUlDm5CvN8IJvBKk67y5XO0b7Pd/ya+f2tPXp NgDAoDnom5uS+Ny/pykxBCNX5mEH5zep0i9DdraoKPVzKUoeDnMzf7g9heIelrag3l oLiDTx6VzlzPA== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 7B11969E35; Thu, 26 Feb 2026 13:03:22 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id GpXtPho7i4s7; Thu, 26 Feb 2026 13:03:22 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1772136198; bh=Gsxix4P0YZoWv62OpPlYrMIMQ8Dfs0vSEXN2pMQXpZI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uMdN6pEni8cMM3kO63/mR8ULxGKnC1+6vS5olIF1A+loGzDUyOq1vk+L9exev0rCl lwwE0XZYDq9aCUd9ZnMYSvQggyRUmr3uJBBaJDuMLYSi4jYnJ6dGWrj9g6rTpf1wkY WAXEr6sc5rkz2QheenfpaF1hs43b67PKKkS4QwIvs9uL8lFwgP73SY2IX6v25JDpaB sdXvPOl94GQ4jtjM+4juTfu3cLYpDB6qQ93mUI0VSgwCpwo6Pe26NunvTu3ROwV3wY tj9nn/HNaJ2vXqDUnwC5/hieYZ30FqGRRfAowNE+cpQcUN9siXvlCHU2qBZcRlhkKR AFHJU/1l9Cklg== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 2277D69D4A; Thu, 26 Feb 2026 13:03:18 -0700 (MST) From: Simon Glass To: U-Boot Concept Date: Thu, 26 Feb 2026 13:00:34 -0700 Message-ID: <20260226200106.1727176-29-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260226200106.1727176-1-sjg@u-boot.org> References: <20260226200106.1727176-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: DNWCVNQRP7JY7BOXLPEQQNVWZSGVIFV7 X-Message-ID-Hash: DNWCVNQRP7JY7BOXLPEQQNVWZSGVIFV7 X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Glass X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 28/32] patman: Improve send feedback and upstream list formatting List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass Move the sendemail identity message from upstream lookup to the send path, so it appears closer to the actual send. Change the Series-to mismatch from a warning to an error, since sending to the wrong list is likely unintentional. Widen the URL column in upstream list to avoid truncation. Signed-off-by: Simon Glass --- tools/patman/cseries.py | 8 +++----- tools/patman/send.py | 11 ++++++++--- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/tools/patman/cseries.py b/tools/patman/cseries.py index 0f1766f5539..81a8712b3de 100644 --- a/tools/patman/cseries.py +++ b/tools/patman/cseries.py @@ -941,8 +941,6 @@ class Cseries(cser_helper.CseriesHelper): identity, series_to, no_maintainers, no_tags = settings if identity and not getattr(args, 'identity', None): args.identity = identity - print(f"Using sendemail identity '{identity}'" - f" from upstream '{ups}'") if series_to: args.series_to = series_to if no_maintainers: @@ -1220,8 +1218,8 @@ class Cseries(cser_helper.CseriesHelper): """ udict = self.get_upstream_dict() - print(f"{'Name':6} {'Def':3} {'Project':10} {'URL':40} Options") - border = (f"{'-' * 6} {'-' * 3} {'-' * 10} {'-' * 40} " + print(f"{'Name':6} {'Def':3} {'Project':10} {'URL':44} Options") + border = (f"{'-' * 6} {'-' * 3} {'-' * 10} {'-' * 44} " f"{'-' * 20}") print(border) for name, items in udict.items(): @@ -1241,7 +1239,7 @@ class Cseries(cser_helper.CseriesHelper): opts.append('no-maintainers') if no_tags: opts.append('no-tags') - print(f'{name:6} {default:3} {proj_name:10} {url:40} ' + print(f'{name:6} {default:3} {proj_name:10} {url:44} ' f'{" ".join(opts)}') def upstream_set(self, name, **kwargs): diff --git a/tools/patman/send.py b/tools/patman/send.py index 51d2c533540..eb9a8e0da2e 100644 --- a/tools/patman/send.py +++ b/tools/patman/send.py @@ -190,8 +190,9 @@ def send(args, git_dir=None, cwd=None): if series_to: to_list = series.get('to', []) if to_list and series_to not in to_list: - print(f"WARNING: Series-to tag {to_list} does not include " - f"expected '{series_to}' from upstream settings") + raise ValueError( + f"Series-to tag {to_list} does not match " + f"expected '{series_to}' from upstream settings") if not to_list: series['to'] = [series_to] @@ -200,12 +201,16 @@ def send(args, git_dir=None, cwd=None): ok = ok and gitutil.check_suppress_cc_config() + identity = getattr(args, 'identity', None) + if identity: + print(f"Using sendemail identity '{identity}'") + its_a_go = ok or args.ignore_errors cmd = email_patches( col, series, cover_fname, patch_files, args.process_tags, its_a_go, args.ignore_bad_tags, args.add_maintainers, args.get_maintainer_script, args.limit, args.dry_run, args.in_reply_to, args.thread, args.smtp_server, - identity=getattr(args, 'identity', None), cwd=cwd) + identity=identity, cwd=cwd) return cmd and its_a_go and not args.dry_run