| Message ID | 20260130035849.3580212-7-simon.glass@canonical.com |
|---|---|
| State | New |
| Headers |
Return-Path: <concept-bounces+u-boot-concept=u-boot.org@u-boot.org>
X-Original-To: u-boot-concept@u-boot.org
Delivered-To: u-boot-concept@u-boot.org
Authentication-Results: mail.u-boot.org;
dkim=fail reason="signature verification failed" (1024-bit key;
unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256
header.s=google header.b=lOACtlvY;
dkim-atps=neutral
Received: from localhost (localhost [127.0.0.1])
by mail.u-boot.org (Postfix) with ESMTP id 1E037697DF
for <u-boot-concept@u-boot.org>; Thu, 29 Jan 2026 20:59:23 -0700 (MST)
X-Virus-Scanned: Debian amavis at
Received: from mail.u-boot.org ([127.0.0.1])
by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP
id v0k_Ls0cAnZP for <u-boot-concept@u-boot.org>;
Thu, 29 Jan 2026 20:59:23 -0700 (MST)
Received: from mail.u-boot.org (localhost [127.0.0.1])
by mail.u-boot.org (Postfix) with ESMTP id 0D912697CB
for <u-boot-concept@u-boot.org>; Thu, 29 Jan 2026 20:59:23 -0700 (MST)
Received: from localhost (localhost [127.0.0.1])
by mail.u-boot.org (Postfix) with ESMTP id 4F9DA69738
for <concept@u-boot.org>; Thu, 29 Jan 2026 20:59:21 -0700 (MST)
X-Virus-Scanned: Debian amavis at
Received: from mail.u-boot.org ([127.0.0.1])
by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP
id 6YSvdtsDlHFr for <concept@u-boot.org>;
Thu, 29 Jan 2026 20:59:21 -0700 (MST)
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.167.182;
helo=mail-oi1-f182.google.com; envelope-from=sjg@chromium.org;
receiver=u-boot.org
Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com
[209.85.167.182])
by mail.u-boot.org (Postfix) with ESMTPS id B2602697E6
for <concept@u-boot.org>; Thu, 29 Jan 2026 20:59:16 -0700 (MST)
Received: by mail-oi1-f182.google.com with SMTP id
5614622812f47-45c715116dbso1197540b6e.3
for <concept@u-boot.org>; Thu, 29 Jan 2026 19:59:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=chromium.org; s=google; t=1769745555; x=1770350355; darn=u-boot.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=1iKyZ0tCq7KWFgDxftp7p2CX6XgqgnS23WTCCnXWBTc=;
b=lOACtlvYLDBTWar5QsIQgpkNsofHM10djCVUPK/+NC/Dt3uh1hb90It9cfgzH35IEO
gMrm3mFelVgzUqMJOZ8egJfS2O7xCZu40LfyUzqeKunugIRrsRhzFkt8KvzGVxuD7RmZ
FzVGMIs18daJx8LJwTRas/aYUcdc2hyZ9k7oA=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1769745555; x=1770350355;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=1iKyZ0tCq7KWFgDxftp7p2CX6XgqgnS23WTCCnXWBTc=;
b=Xrnikue1aGF00bpEgh2652BIE8iiinMTAJkL8oyb4DHUufgTgPVE39jbRj3FyqN0gZ
6SJxPaMP4JLzOn3mJjEXynbPT7ipFYNCGhmBFx0CV8zPIjVzZDXD33Wgi1Whm9HpPx+9
nJ2gEaO9Fe/9EyKOyZs2T8MKrbhkDfhxxE0SxgueYwJbY+kJ8gifpx+v94S8iEYhGhbE
0MP/Glq6ujKDHxgxXHZgyzVNq4oRKxT7dY2QW+5ah0hgZWWn4SDg7tH9/eVz+rp2opzr
L18sM6obUgA4P1LkGFNjNoqXwMS4+j9bF7hl7e3YkPysm4KOa8bXRJYwkm8JGpDB70KW
sD0w==
X-Gm-Message-State: AOJu0YzNpPcLNbu7WfLGcJG+JwIpCe7Len5Fyj0sAXo2iXQBo/vnRnIn
Glr27s1f5C3bPtFiS8fVVRHMBSMdn5pGKd3WiQj07eeFTnHuQlpxiJ/Vk2nVv5l63Oz82dlZq44
1HMVN3Q==
X-Gm-Gg: AZuq6aJhD9ewx34c2KqnwCWxwHVhAU5Rbz0Ct4MDFP8kb2JaJZ36IQ3ad57xRT2kcab
gP9jgE3C4XjifKeTYCpOvT3AJip6w1ir9W+Xeums4JX30M4aD9ktUfYTvd3uQ4hDSY9pwYpuNHP
7kix+UulBKDfrka2PwJ3/0y2n1OBHoUVCKUoqGPQsVIXvxIHiWDVC349eaMxgDPrOC74alhu3Cv
uUtc05hwTuGVzMrmKNWOSKkN1L/h+EoLgPhZmcIlzsCkTJ8AgnEeB6MmXNzmfa2SMtVaA6icziW
DtJ+3VKQ3M3EELgUvaamPwTdp3R4w87YhLx+FMaG0DaGNjRyID4eI+UWTHrmUfx3uhO4RMDv+9l
A1VCOnpkFtMPFJHuQFJNjhPwhhotZsATT4f+y4g7CPWabScmWUaM9vylojQOVdOhSsiHPnxnJZZ
2N9uvqLBSgbU+FfEO/
X-Received: by 2002:a05:6820:220d:b0:662:fd74:61d5 with SMTP id
006d021491bc7-6630f004c4cmr927741eaf.3.1769745555522;
Thu, 29 Jan 2026 19:59:15 -0800 (PST)
Received: from chromium.org ([73.34.74.121])
by smtp.gmail.com with ESMTPSA id
006d021491bc7-662f9a4e491sm4128687eaf.16.2026.01.29.19.59.13
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 29 Jan 2026 19:59:14 -0800 (PST)
From: Simon Glass <sjg@chromium.org>
X-Google-Original-From: Simon Glass <simon.glass@canonical.com>
To: U-Boot Concept <concept@u-boot.org>
Date: Thu, 29 Jan 2026 20:58:29 -0700
Message-ID: <20260130035849.3580212-7-simon.glass@canonical.com>
X-Mailer: git-send-email 2.43.0
In-Reply-To: <20260130035849.3580212-1-simon.glass@canonical.com>
References: <20260130035849.3580212-1-simon.glass@canonical.com>
MIME-Version: 1.0
Message-ID-Hash: KW3NYU6BO6GRKIRHF3IJ5XJD7HWRRKAG
X-Message-ID-Hash: KW3NYU6BO6GRKIRHF3IJ5XJD7HWRRKAG
X-MailFrom: sjg@chromium.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
banned-address; emergency; member-moderation; nonmember-moderation;
administrivia; implicit-dest; max-recipients; max-size; news-moderation;
no-subject; digests; suspicious-header
CC: Simon Glass <simon.glass@canonical.com>,
"Claude Opus 4 . 5" <noreply@anthropic.com>
X-Mailman-Version: 3.3.10
Precedence: list
Subject: [Concept] [PATCH 06/19] expo: Free gen.lines alist when destroying
text
objects
List-Id: Discussion and patches related to U-Boot Concept <concept.u-boot.org>
Archived-At:
<https://lists.u-boot.org/archives/list/concept@u-boot.org/message/KW3NYU6BO6GRKIRHF3IJ5XJD7HWRRKAG/>
List-Archive: <https://lists.u-boot.org/archives/list/concept@u-boot.org/>
List-Help: <mailto:concept-request@u-boot.org?subject=help>
List-Owner: <mailto:concept-owner@u-boot.org>
List-Post: <mailto:concept@u-boot.org>
List-Subscribe: <mailto:concept-join@u-boot.org>
List-Unsubscribe: <mailto:concept-leave@u-boot.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
|
| Series |
Enhanced command-line editing with undo/redo support
|
|
Commit Message
Simon Glass
Jan. 30, 2026, 3:58 a.m. UTC
Text scene objects (SCENEOBJT_TEXT) have a gen.lines alist that stores
line measurement info populated during rendering. This alist was not
being freed when the object was destroyed, causing a memory leak.
Add cleanup for gen.lines in scene_obj_destroy() for TEXT objects.
Co-developed-by: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: Simon Glass <simon.glass@canonical.com>
---
boot/scene.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/boot/scene.c b/boot/scene.c index ff21b524843..b075697adb6 100644 --- a/boot/scene.c +++ b/boot/scene.c @@ -110,6 +110,8 @@ void scene_obj_destroy(struct scene_obj *obj) else if (obj->type == SCENEOBJT_TEXTLINE || obj->type == SCENEOBJT_TEXTEDIT) scene_txtin_destroy(obj->scene, scene_obj_txtin(obj)); + if (obj->type == SCENEOBJT_TEXT) + alist_uninit(&((struct scene_obj_txt *)obj)->gen.lines); free(obj->name); free(obj); }