| Message ID | 20260122041155.174721-9-sjg@u-boot.org |
|---|---|
| State | New |
| Headers |
Return-Path: <concept-bounces+u-boot-concept=u-boot.org@u-boot.org> X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1769055164; bh=XnwT6kqVu7VXIIHfES0BLCvNl4QKvS+5g9DmTcxI7vA=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=LG85GqZNaSjRcuvrySTTPDENHTK484HvS4kFySNydTIRKHrucrOPF+0D15IoRODuK NvWLadSsIO0xoKrSUGtWbaUwE+BD5meKKolvcYk2mD7MA+M9Ie4yz5GQ8mQfTyvdue 9tlT3jmq9m1pdtRp8G6BU8eTsfdGRNyy6BqBQkK7PL7Uo+w4PtKy/hSrnHFx58TBDq +bUC2elyDf1EruDS7I/NW8P4jkyeVnEidNQgj9KI7cBs7WAU5/HLDCYAIx+on1E7Zt 56abDb11XrasKa+ImLmGFLAdw0E8S50CupuRbs44EKGqD/fpB6VP3qaMs5ZHoe7mTb E+hkczhgWPVOQ== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 668476962D for <u-boot-concept@u-boot.org>; Wed, 21 Jan 2026 21:12:44 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id CmCPOCZ2AxHC for <u-boot-concept@u-boot.org>; Wed, 21 Jan 2026 21:12:44 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1769055164; bh=XnwT6kqVu7VXIIHfES0BLCvNl4QKvS+5g9DmTcxI7vA=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=LG85GqZNaSjRcuvrySTTPDENHTK484HvS4kFySNydTIRKHrucrOPF+0D15IoRODuK NvWLadSsIO0xoKrSUGtWbaUwE+BD5meKKolvcYk2mD7MA+M9Ie4yz5GQ8mQfTyvdue 9tlT3jmq9m1pdtRp8G6BU8eTsfdGRNyy6BqBQkK7PL7Uo+w4PtKy/hSrnHFx58TBDq +bUC2elyDf1EruDS7I/NW8P4jkyeVnEidNQgj9KI7cBs7WAU5/HLDCYAIx+on1E7Zt 56abDb11XrasKa+ImLmGFLAdw0E8S50CupuRbs44EKGqD/fpB6VP3qaMs5ZHoe7mTb E+hkczhgWPVOQ== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 568506962A for <u-boot-concept@u-boot.org>; Wed, 21 Jan 2026 21:12:44 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1769055162; bh=IL/WlDzya7cdwzAXLOlI7KeJwDRQHKLN991PsKGV5+Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TcSjpcQ8knVIOY+M2yEDdmXrb1wIOPeBy2Nz8QQbHQZniPCOoQwYg834kk8QB3rw/ wMehGqQvn33LJaq283tZ5N0hPRSJRiKxCyKEz85ylXJNfIkAak7hakToMs4HwgmwD8 0gWTFyg5iH4KY4OqaKJqwQYuQ7G+kMjT20lFN4+ExnB/vQae1C9Geg+UzWZeCywvqa zmB94Iwan6/Jn/sgpx6pHfSJDmFQNGRP4ZB/9R8Jw4Izhle4GJ/v00eOE5Tw14mD8b KO0n6qK24zfC7pyMKtDudc5pirI0qjJ9mc3zOWHXyz7EJTo6Srbnnn0ybY+RYBZFRb 0S1E+4J2nOQWQ== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 6374B694CC; Wed, 21 Jan 2026 21:12:42 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id dQ5YfE4e7OJt; Wed, 21 Jan 2026 21:12:42 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1769055158; bh=aqvbsXyuX/ab5YkS1kPs+gurbcz4Joujl/NNqe198sA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KbhqI/jcsqrYHjlt/98MmEoTVzFl1l1kWKBtfRhU18lXlUNs7gYUImXAWsVn8MK4s kA6EFIKwFdI4RjX6qruY/mOGcGHJU4FzkiPj0QD8imX8xd/jxrWIL/fF8nx3QCa+8k Ziw6k9Vw/qXP8vgryeBxyeTuanl6yehng69FJcto2mZnGUJdZg7geUh2IHK7w4h0oF AeuMs+Eu2ZoI8GxtnBishL1s8mAyiL+tFqBXl5ktHx6OChOOSd8V78vZweiJmGkWRo jhUSBSlO1FNQS3On8gG+Qm/cVSHhNzKO0C3BcAQAAIHEOFMySj0pTatfkAlgPTYgI1 jzjHVkI9b3ZHw== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id F048D69616; Wed, 21 Jan 2026 21:12:37 -0700 (MST) From: Simon Glass <sjg@u-boot.org> To: U-Boot Concept <concept@u-boot.org> Date: Wed, 21 Jan 2026 21:11:36 -0700 Message-ID: <20260122041155.174721-9-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260122041155.174721-1-sjg@u-boot.org> References: <20260122041155.174721-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: AG2WIYS3LKXTCHV6A7ZLR22SEZB2JE5P X-Message-ID-Hash: AG2WIYS3LKXTCHV6A7ZLR22SEZB2JE5P X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Glass <simon.glass@canonical.com>, "Claude Opus 4 . 5" <noreply@anthropic.com> X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 08/16] expo: Fix text-input close on BKEY_SELECT List-Id: Discussion and patches related to U-Boot Concept <concept.u-boot.org> Archived-At: <https://lists.u-boot.org/archives/list/concept@u-boot.org/message/AG2WIYS3LKXTCHV6A7ZLR22SEZB2JE5P/> List-Archive: <https://lists.u-boot.org/archives/list/concept@u-boot.org/> List-Help: <mailto:concept-request@u-boot.org?subject=help> List-Owner: <mailto:concept-owner@u-boot.org> List-Post: <mailto:concept@u-boot.org> List-Subscribe: <mailto:concept-join@u-boot.org> List-Unsubscribe: <mailto:concept-leave@u-boot.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit |
| Series |
expo: Add multiline editing support for textedit
|
|
Commit Message
Simon Glass
Jan. 22, 2026, 4:11 a.m. UTC
From: Simon Glass <simon.glass@canonical.com> When closing a text-input object (textline or textedit) with Enter (BKEY_SELECT), scene_txtin_close() is not called. This leaves the vidconsole context in a bad state, causing rendering issues. Also, the code falls through to process '\n' via cread_line_process_ch(), which incorrectly adds a newline character to the text buffer. Fix this by calling scene_txtin_close() for BKEY_SELECT, matching the behaviour of BKEY_QUIT, and breaking instead of falling through. Co-developed-by: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Simon Glass <simon.glass@canonical.com> --- boot/scene_txtin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/boot/scene_txtin.c b/boot/scene_txtin.c index da8d49af04f..43a6c00d497 100644 --- a/boot/scene_txtin.c +++ b/boot/scene_txtin.c @@ -199,8 +199,8 @@ int scene_txtin_send_key(struct scene_obj *obj, struct scene_txtin *tin, break; event->type = EXPOACT_CLOSE; event->select.id = obj->id; - key = '\n'; - fallthrough; + scene_txtin_close(scn, tin); + break; default: cread_line_process_ch(cls, key); break;