From patchwork Thu Jan 22 04:11:33 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1764 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1769055150; bh=SL7Hp4fXmrzjoQP7nOzro0WJef3y4hoRzr64ud9HBmA=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=tEGKs9Edh+Cwm+d/Er3KZr3dlxsoBNgH82mIp5GxWr0fCfmL4+OsvBmaBEV8h+Md5 xbAaarlinLa7gFNzX0ZoNCOv8ZxPySKwYNNBJWS4npsw+VHZQXMqDGkzif0WILU8ZH LMuCDnESioC9m87M02dK6VZ4ovwnRCuEDrf1w6u6oYKrGhEj+7aWibf0g5S40uZQpb fSU+NN4I3m6stnr5cI/XyaB72HngRstpO8ERInTh8/cK0f57hTzGZNtL7mEZPmuval RTExKKw88St/0jK9nFDYL3x9SWzUaqNSP32CBMTk4aDB13Z5A8UAC/zlXDCWNypGMu VuvWXCp/viC7w== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 756986962C for ; Wed, 21 Jan 2026 21:12:30 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id LeXLJM_YMwvA for ; Wed, 21 Jan 2026 21:12:30 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1769055150; bh=SL7Hp4fXmrzjoQP7nOzro0WJef3y4hoRzr64ud9HBmA=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=tEGKs9Edh+Cwm+d/Er3KZr3dlxsoBNgH82mIp5GxWr0fCfmL4+OsvBmaBEV8h+Md5 xbAaarlinLa7gFNzX0ZoNCOv8ZxPySKwYNNBJWS4npsw+VHZQXMqDGkzif0WILU8ZH LMuCDnESioC9m87M02dK6VZ4ovwnRCuEDrf1w6u6oYKrGhEj+7aWibf0g5S40uZQpb fSU+NN4I3m6stnr5cI/XyaB72HngRstpO8ERInTh8/cK0f57hTzGZNtL7mEZPmuval RTExKKw88St/0jK9nFDYL3x9SWzUaqNSP32CBMTk4aDB13Z5A8UAC/zlXDCWNypGMu VuvWXCp/viC7w== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 63C5069627 for ; Wed, 21 Jan 2026 21:12:30 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1769055148; bh=hXaowbvh7DDI/H255KlySvo4bnMhuY8Y/zjXUziVjQ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uyjWTCekpd0pEbmlYbUZ7CDUy+1h/ETGaF+2woGAxLo7/hGgOTJhTyjEKYfhhx++u 7HxOKJU3CG34xPIi7TLsPe3QHwcaE1Xsr4JQekfGICYjRPeRO6zQuVK0FYVIgQfnTx WzOodzqyRn9ze4ASjuY179owMiXp3iZfxmTaTJEUdgz28NBN3QLfZ5wsnaMGzJUk0f +R5RiaLSLBeQjd0GkzQQyCD177OLNR5nZ4M3sz82gn3HMDmUTgU1IvmLp5Smgf/x/U mHAeCWZkaI6H9FhHXuZlWbnV19PYmFNwOTUQhTrwxqi53MUx7JK15tSGMhxmqvBIU1 hm4u5Nsx3xm8g== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 716EF69627; Wed, 21 Jan 2026 21:12:28 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id hBPqcLd4ph0e; Wed, 21 Jan 2026 21:12:28 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1769055143; bh=tyVjh4BTVPSn6EGYPcuzrKe+gj4HemvD7/dK9yUF01g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BXK4abJZVs/6IWVYBE6FolmyHjRgLYbzNyx74U7LG82vvgEYDluNy9h/AW5JlbWhC nQUGktmCPhG8oUW6CORxd6IhhlnXndefqQGYy5gEmoS54QiLWNLzU8gCVEPkIXtc6o fvc9NF0wSa/AKbr2jZX9EF0+xik2FquLe+ohhHvxaoVBbhfb4xx+gkIUZeruPYNJOa 4+c/Br7KAYVu5zcxMuiNKB+HNho44Deor0arQ9pbYWPrOWNIr36TKAyaKOBg6j56cC hfYCmFc5/niPcXvnjCE00ACa5CDxdrYxgj4KxW4ZzTItlZATgBk2mLULUGTgZ5aHxj 8n5o5o+D4iBqA== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 3CDA1694CC; Wed, 21 Jan 2026 21:12:23 -0700 (MST) From: Simon Glass To: U-Boot Concept Date: Wed, 21 Jan 2026 21:11:33 -0700 Message-ID: <20260122041155.174721-6-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260122041155.174721-1-sjg@u-boot.org> References: <20260122041155.174721-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: 6ATBG7UFF3G2NMVNAPYFJRCVTDB7MBHJ X-Message-ID-Hash: 6ATBG7UFF3G2NMVNAPYFJRCVTDB7MBHJ X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Glass , "Claude Opus 4 . 5" X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 05/16] expo: Drop entry save/restore in textline rendering List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass With per-object vidconsole contexts, each text-input object maintains its own cursor position and state. The entry save/restore calls in scene_txtin_render_deps() are no longer needed since the context persists between renders. Remove the vidconsole_entry_save() and vidconsole_entry_restore() calls, simplifying the rendering code. Co-developed-by: Claude Opus 4.5 Signed-off-by: Simon Glass --- boot/scene_txtin.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/boot/scene_txtin.c b/boot/scene_txtin.c index 457d782b4cf..1829fabf9cc 100644 --- a/boot/scene_txtin.c +++ b/boot/scene_txtin.c @@ -79,19 +79,11 @@ int scene_txtin_render_deps(struct scene *scn, struct scene_obj *obj, /* if open, render the edit text on top of the background */ if (open) { - int ret; - - ret = vidconsole_entry_restore(cons, &scn->entry_save); - if (ret) - return log_msg_ret("sav", ret); scene_render_obj(scn, tin->edit_id, ctx); /* move cursor back to the correct position */ for (i = cls->num; i < cls->eol_num; i++) vidconsole_put_char(cons, ctx, '\b'); - ret = vidconsole_entry_save(cons, &scn->entry_save); - if (ret) - return log_msg_ret("sav", ret); vidconsole_show_cursor(cons, ctx); }