diff mbox series

[Concept,05/16] expo: Drop entry save/restore in textline rendering

Message ID 20260122041155.174721-6-sjg@u-boot.org
State New
Headers
Series expo: Add multiline editing support for textedit |

Commit Message

Simon Glass Jan. 22, 2026, 4:11 a.m. UTC 
  From: Simon Glass <simon.glass@canonical.com>

With per-object vidconsole contexts, each text-input object maintains
its own cursor position and state. The entry save/restore calls in
scene_txtin_render_deps() are no longer needed since the context
persists between renders.

Remove the vidconsole_entry_save() and vidconsole_entry_restore() calls,
simplifying the rendering code.

Co-developed-by: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: Simon Glass <simon.glass@canonical.com>
---

 boot/scene_txtin.c | 8 --------
 1 file changed, 8 deletions(-)
diff mbox series

Patch

diff --git a/boot/scene_txtin.c b/boot/scene_txtin.c
index 457d782b4cf..1829fabf9cc 100644
--- a/boot/scene_txtin.c
+++ b/boot/scene_txtin.c
@@ -79,19 +79,11 @@  int scene_txtin_render_deps(struct scene *scn, struct scene_obj *obj,
 
 	/* if open, render the edit text on top of the background */
 	if (open) {
-		int ret;
-
-		ret = vidconsole_entry_restore(cons, &scn->entry_save);
-		if (ret)
-			return log_msg_ret("sav", ret);
 		scene_render_obj(scn, tin->edit_id, ctx);
 
 		/* move cursor back to the correct position */
 		for (i = cls->num; i < cls->eol_num; i++)
 			vidconsole_put_char(cons, ctx, '\b');
-		ret = vidconsole_entry_save(cons, &scn->entry_save);
-		if (ret)
-			return log_msg_ret("sav", ret);
 
 		vidconsole_show_cursor(cons, ctx);
 	}