| Message ID | 20260119204130.3972647-23-sjg@u-boot.org |
|---|---|
| State | New |
| Headers |
Return-Path: <concept-bounces+u-boot-concept=u-boot.org@u-boot.org> X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768855414; bh=c1LByFu34h4xehWMrxXuaYinlybNzgR7027lLlyx9sc=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=jCaihBKpygwcRajS7DR/JIB1eCTmGxfjhnohmEnFl5zUT04Do3izKYIKZDjU9OEh3 DPQMlm6uuiGaAJ9GQxUYtLMK7upX76klV5gT/6SqeFSzkXDHZmA8Ko02IeHvC2PHXO zRwVvLWyLxXHTvWvo8ldp+j0UX13FkkfZr4qamM/daNlPdzQbK2O6pjtMgNmkhJI4G 5Y3F6A0mtVclIXpbtkvy291yw7/1I4p/naRjDCCJIfpcr5HkE+jiYhMJR6l7gi8AtU wmMMrRosPslTCO10E54Ykz4DSgsEUqXLFdESP2w11XczIPNvWhvEFYvGrn5Dpi71DK jEljduP4Jg4+A== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 9374F6951C for <u-boot-concept@u-boot.org>; Mon, 19 Jan 2026 13:43:34 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id SH-NhXqJyiXZ for <u-boot-concept@u-boot.org>; Mon, 19 Jan 2026 13:43:34 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768855414; bh=c1LByFu34h4xehWMrxXuaYinlybNzgR7027lLlyx9sc=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=jCaihBKpygwcRajS7DR/JIB1eCTmGxfjhnohmEnFl5zUT04Do3izKYIKZDjU9OEh3 DPQMlm6uuiGaAJ9GQxUYtLMK7upX76klV5gT/6SqeFSzkXDHZmA8Ko02IeHvC2PHXO zRwVvLWyLxXHTvWvo8ldp+j0UX13FkkfZr4qamM/daNlPdzQbK2O6pjtMgNmkhJI4G 5Y3F6A0mtVclIXpbtkvy291yw7/1I4p/naRjDCCJIfpcr5HkE+jiYhMJR6l7gi8AtU wmMMrRosPslTCO10E54Ykz4DSgsEUqXLFdESP2w11XczIPNvWhvEFYvGrn5Dpi71DK jEljduP4Jg4+A== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 83A4669504 for <u-boot-concept@u-boot.org>; Mon, 19 Jan 2026 13:43:34 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768855412; bh=RFTswCgyWZrJGIf9ud61pZhkH7oDq2VIYUoewR5FjA0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rhRJm3AY17tpFcYGofsQggDWJ7jiMNhoALwcdcPP9nZHaoM9JIOlXZVC7z+pQ4viH WhIGKCVSTwuj2dkoplk6oBeZWi8zk/lvqR2p+qO045YRyR+0Pomz60YbjRtsL5P8gf dkMQSzERtUDG1SqduCfPVASloHO0dK8lACfPxzdex3equm4DhgK7cPPXNDsJelqI2o MH+8EnljVJf6HBCYQB7kZUiRzM5HWqcmimArljKyI6J8/qAqb/KiIjvBWFwLzayA9G azdWr8y2Lt6B+ze4kgCihTAr0d16elph1YqEXoA8VjB0HagB8FemWdL8g3TAv9PX3s ZkCmUBgsLR6Iw== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 89A59693BA; Mon, 19 Jan 2026 13:43:32 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id yCXe7hbE2Kuq; Mon, 19 Jan 2026 13:43:32 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768855408; bh=gnqfTRUiNsIyb+lVnoM+7ZH0RIAeTSyF92qq8S48xwo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=M8DJAh52aXQoZ8kHT7b6BLVvLfacfy3NzmokqCa7Qc/kLihFdaL3uc/UTyd8Jn7BG euB/UOT+KejswN92D+4irxjancGMv/MHzK8D0T3TNZ6NjLHj5FNNYbWMDOST7UgQpW oQqF0ktiiYoqpU7Hi3Orzq/NsjhDrj8LjfgL8li2joL92O8Bbf2Jvp4TDJYKraLC29 lLuEojS4OnqGK4jyAil90Uey9e0iwTVYV8EJtf4UxtY+24JHTpFlTAqrvbyVCmYqKN 9qoRNuIzr1oAaa/VNztzFSrGK3+nVtM9nYb5jhJmeShrRvPFwTAdHcPkTcz0Kw4Qno MAZCbkD4g6mWw== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 1BBD669504; Mon, 19 Jan 2026 13:43:28 -0700 (MST) From: Simon Glass <sjg@u-boot.org> To: U-Boot Concept <concept@u-boot.org> Date: Mon, 19 Jan 2026 13:41:15 -0700 Message-ID: <20260119204130.3972647-23-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260119204130.3972647-1-sjg@u-boot.org> References: <20260119204130.3972647-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: RBABDP6MXWQVNPC6QGOHLOAWDI36NLCA X-Message-ID-Hash: RBABDP6MXWQVNPC6QGOHLOAWDI36NLCA X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Glass <simon.glass@canonical.com>, "Claude Opus 4 . 5" <noreply@anthropic.com> X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 22/27] expo: Combine textline and textedit switch cases List-Id: Discussion and patches related to U-Boot Concept <concept.u-boot.org> Archived-At: <https://lists.u-boot.org/archives/list/concept@u-boot.org/message/RBABDP6MXWQVNPC6QGOHLOAWDI36NLCA/> List-Archive: <https://lists.u-boot.org/archives/list/concept@u-boot.org/> List-Help: <mailto:concept-request@u-boot.org?subject=help> List-Owner: <mailto:concept-owner@u-boot.org> List-Post: <mailto:concept@u-boot.org> List-Subscribe: <mailto:concept-join@u-boot.org> List-Unsubscribe: <mailto:concept-leave@u-boot.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit |
| Series |
Expo debugging and textedit improvements (part E)
|
|
Commit Message
Simon Glass
Jan. 19, 2026, 8:41 p.m. UTC
From: Simon Glass <simon.glass@canonical.com> Combine the TEXTLINE and TEXTEDIT cases in scene_obj_render() and scene_apply_theme() since they have identical handling. Co-developed-by: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Simon Glass <simon.glass@canonical.com> --- boot/scene.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/boot/scene.c b/boot/scene.c index ae3851cc82c..b05291138ed 100644 --- a/boot/scene.c +++ b/boot/scene.c @@ -786,6 +786,7 @@ static int scene_obj_render(struct scene_obj *obj, bool text_mode) break; } case SCENEOBJT_TEXTLINE: + case SCENEOBJT_TEXTEDIT: if (obj->flags & SCENEOF_OPEN) scene_render_background(obj, true, false); break; @@ -796,10 +797,6 @@ static int scene_obj_render(struct scene_obj *obj, bool text_mode) obj->bbox.y1, box->width, vid_priv->colour_fg, box->fill); break; } - case SCENEOBJT_TEXTEDIT: - if (obj->flags & SCENEOF_OPEN) - scene_render_background(obj, true, false); - break; } return 0; @@ -1621,10 +1618,7 @@ int scene_apply_theme(struct scene *scn, struct expo_theme *theme) case SCENEOBJT_MENU: case SCENEOBJT_BOX: case SCENEOBJT_TEXTLINE: - break; case SCENEOBJT_TEXTEDIT: - scene_txted_set_font(scn, obj->id, NULL, - theme->font_size); break; case SCENEOBJT_TEXT: scene_txt_set_font(scn, obj->id, NULL,