diff mbox series

[Concept,03/16] cli: Convert ERASE_TO_EOL macro to a function

Message ID 20260118204303.1982533-4-sjg@u-boot.org
State New
Headers
Series expo: Continue preparations for textedit (part D) |

Commit Message

Simon Glass Jan. 18, 2026, 8:42 p.m. UTC 
  From: Simon Glass <simon.glass@canonical.com>

Convert the ERASE_TO_EOL macro to cread_erase_to_eol() function. This
reduces code size by 71 bytes since the function is called from three
places.

Co-developed-by: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: Simon Glass <simon.glass@canonical.com>
---

 common/cli_readline.c | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)
diff mbox series

Patch

diff --git a/common/cli_readline.c b/common/cli_readline.c
index 81b0688da38..2e41aa5afef 100644
--- a/common/cli_readline.c
+++ b/common/cli_readline.c
@@ -232,13 +232,14 @@  void cread_print_hist_list(void)
 	}					\
 }
 
-#define ERASE_TO_EOL() {				\
-	if (cls->num < cls->eol_num) {		\
-		printf("%*s", (int)(cls->eol_num - cls->num), ""); \
-		do {					\
-			cls_putch(cls, CTL_BACKSPACE);	\
-		} while (--cls->eol_num > cls->num);	\
-	}						\
+static void cread_erase_to_eol(struct cli_line_state *cls)
+{
+	if (cls->num < cls->eol_num) {
+		printf("%*s", (int)(cls->eol_num - cls->num), "");
+		do {
+			cls_putch(cls, CTL_BACKSPACE);
+		} while (--cls->eol_num > cls->num);
+	}
 }
 
 #define REFRESH_TO_EOL() {				\
@@ -344,7 +345,7 @@  int cread_line_process_ch(struct cli_line_state *cls, char ichar)
 		}
 		break;
 	case CTL_CH('k'):
-		ERASE_TO_EOL();
+		cread_erase_to_eol(cls);
 		break;
 	case CTL_CH('e'):
 		REFRESH_TO_EOL();
@@ -378,7 +379,7 @@  int cread_line_process_ch(struct cli_line_state *cls, char ichar)
 	case CTL_CH('x'):
 	case CTL_CH('u'):
 		BEGINNING_OF_LINE();
-		ERASE_TO_EOL();
+		cread_erase_to_eol(cls);
 		break;
 	case DEL:
 	case DEL7:
@@ -418,7 +419,7 @@  int cread_line_process_ch(struct cli_line_state *cls, char ichar)
 			BEGINNING_OF_LINE();
 
 			/* erase to end of line */
-			ERASE_TO_EOL();
+			cread_erase_to_eol(cls);
 
 			/* copy new line into place and display */
 			strcpy(buf, hline);