From patchwork Sun Jan 18 20:42:40 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1592 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768769002; bh=ZxovhrEjOYcsiFcN9i3mwPMKkhYo3N+wsipV0ab/WDM=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=USMsAos0dC4yw4z1BLUQ1H8v+lCMFjFKljhgRULIKfJHSBI5J9zNDJgS0sM76/UXs 4r0+fag5fFSli5eFyZAjfL9CDVbg1LJxWXAO/xzHk8dL1T9FfUBNIVcZdbwqfhN1i2 k0U6xoSaux2T2/AUa0R9vQZyXCi1XP66TkB5+aG/31l4EUDxti1ioin567PxQn750n ag7QEw3qo7zSE6m1KEIY8MgULoMz7aDp6VQ4UcoI0wOv3iL4SutsnguGxZxEJB7cgA 4RVGM+fGsvj520H73ILnr6biurMg2vy9O7zeYAnORO0xuWKUaWtPDPhNIY8/RfX2up h/pGauRPLH59Q== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id D24786948C for ; Sun, 18 Jan 2026 13:43:22 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id j6GE5aNPpaFn for ; Sun, 18 Jan 2026 13:43:22 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768769002; bh=ZxovhrEjOYcsiFcN9i3mwPMKkhYo3N+wsipV0ab/WDM=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=USMsAos0dC4yw4z1BLUQ1H8v+lCMFjFKljhgRULIKfJHSBI5J9zNDJgS0sM76/UXs 4r0+fag5fFSli5eFyZAjfL9CDVbg1LJxWXAO/xzHk8dL1T9FfUBNIVcZdbwqfhN1i2 k0U6xoSaux2T2/AUa0R9vQZyXCi1XP66TkB5+aG/31l4EUDxti1ioin567PxQn750n ag7QEw3qo7zSE6m1KEIY8MgULoMz7aDp6VQ4UcoI0wOv3iL4SutsnguGxZxEJB7cgA 4RVGM+fGsvj520H73ILnr6biurMg2vy9O7zeYAnORO0xuWKUaWtPDPhNIY8/RfX2up h/pGauRPLH59Q== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id C154669491 for ; Sun, 18 Jan 2026 13:43:22 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768769000; bh=vk2w9v0Ix2+rtvTrQfgSQ86q+XmlXNEbQNRr3Xs5Er4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F9zm6dGWgR+xW/IAkM4t59zR6kiV5PXUZ+NAI+z0m2j6km/gx+Fz+ht5xXfVc6WoZ LhN8lW/t3en4vYvY5PCirN58kGODatq1gHzA5g6368W052Efv+jTf2IQcp1asO1elo 5QFmuoAwjZsTSGJkNyFQz4y57gnBMk4AM1eTvMp+pQalV1xc21zgYXzfB4KXCiCk/X 6Pfo3WfMmDXrnlGepbZBH0ECCIJzqDdkddmHO753HgC6HCrKRxVLHDQkYydTJ/jXJo Axh089apflIdyPHixqCtADIaF3pbb0SOrbJVQ7ojrPfERjAX3jsB8YM+mByKm/NjIh 8WENRf41yZy/w== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id C3EA16948C; Sun, 18 Jan 2026 13:43:20 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id 0fhDHZgmQUlt; Sun, 18 Jan 2026 13:43:20 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768768996; bh=DhVKzZDAYL9AGDJ3BSojvsBM8yg2KV7Orh79IUVkM44=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g1UbrURB8o37oSrMzWb6zvjlawG7vbz/3oAMrWHb/m24AXSqn2Yg/AFle317vYZ23 U2ZrWng/n4z4x9lNBYgZZl9Bnub+nM3OAigddabMHRGOXCvzNGc2NltlC0JjdP+/wq Ic4Gy/9D6Thk07LKvFgQl06cpliREXKIFrXKwJMaRC8+Y0XQ0VPjG9O4uBLiRBtdSO VnUiuP7XvQDGx2v7meb2WvauhwFG+hFAD0QABNoZZpNL/ufwMXelTHY003w08J2xqC 75z0bf2zNUL7ZHKodQx/5M6Z/kmdSEJ8iXXf5Spv4qGuft5brcW8Vo5uTkowaW5Cnb K6OGQJ4dDhYgA== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 7A50069394; Sun, 18 Jan 2026 13:43:16 -0700 (MST) From: Simon Glass To: U-Boot Concept Date: Sun, 18 Jan 2026 13:42:40 -0700 Message-ID: <20260118204303.1982533-2-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260118204303.1982533-1-sjg@u-boot.org> References: <20260118204303.1982533-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: ZHOYGN5ZU5UWYKIEWXQZFRVFVVOYKCIW X-Message-ID-Hash: ZHOYGN5ZU5UWYKIEWXQZFRVFVVOYKCIW X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Glass , "Claude Opus 4 . 5" X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 01/16] test: acpi: Fix flaky dm_test_acpi_fpdt checksum test List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass The test modifies ebs_entry and ebs_exit to 123 and 456, then expects the checksum to become invalid. However, the original values come from timer_get_boot_us() which varies each run. If the byte sum of the timer values coincidentally equals the byte sum of 123 + 456, the checksum remains valid and the test fails. Use 0 for the modified values instead, since the test already verifies the original values are non-zero. This guarantees the checksum changes. Co-developed-by: Claude Opus 4.5 Signed-off-by: Simon Glass --- test/dm/acpi.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/test/dm/acpi.c b/test/dm/acpi.c index 1409c333eb1..588a518bc4f 100644 --- a/test/dm/acpi.c +++ b/test/dm/acpi.c @@ -1012,9 +1012,12 @@ static int dm_test_acpi_fpdt(struct unit_test_state *uts) ut_asserteq_ptr(rec, (struct acpi_fpdt_boot *)(fpdt + 1)); ut_asserteq(1234, rec->reset_end); - /* Update a timing field */ - rec->ebs_entry = 123; - rec->ebs_exit = 456; + /* + * Update timing fields - use 0 since we know the original values are + * non-zero + */ + rec->ebs_entry = 0; + rec->ebs_exit = 0; /* Checksum should now be invalid */ ut_assert(table_compute_checksum(fpdt, fpdt->header.length) != 0); @@ -1026,8 +1029,8 @@ static int dm_test_acpi_fpdt(struct unit_test_state *uts) ut_asserteq(0, table_compute_checksum(fpdt, fpdt->header.length)); /* Verify the updated values are still there */ - ut_asserteq(123, rec->ebs_entry); - ut_asserteq(456, rec->ebs_exit); + ut_asserteq(0, rec->ebs_entry); + ut_asserteq(0, rec->ebs_exit); unmap_sysmem(buf);