diff mbox series

[Concept,01/16] test: acpi: Fix flaky dm_test_acpi_fpdt checksum test

Message ID 20260118204303.1982533-2-sjg@u-boot.org
State New
Headers
Series expo: Continue preparations for textedit (part D) |

Commit Message

Simon Glass Jan. 18, 2026, 8:42 p.m. UTC 
  From: Simon Glass <simon.glass@canonical.com>

The test modifies ebs_entry and ebs_exit to 123 and 456, then expects
the checksum to become invalid. However, the original values come from
timer_get_boot_us() which varies each run. If the byte sum of the timer
values coincidentally equals the byte sum of 123 + 456, the checksum
remains valid and the test fails.

Use 0 for the modified values instead, since the test already verifies
the original values are non-zero. This guarantees the checksum changes.

Co-developed-by: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: Simon Glass <simon.glass@canonical.com>
---

 test/dm/acpi.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)
diff mbox series

Patch

diff --git a/test/dm/acpi.c b/test/dm/acpi.c
index 1409c333eb1..588a518bc4f 100644
--- a/test/dm/acpi.c
+++ b/test/dm/acpi.c
@@ -1012,9 +1012,12 @@  static int dm_test_acpi_fpdt(struct unit_test_state *uts)
 	ut_asserteq_ptr(rec, (struct acpi_fpdt_boot *)(fpdt + 1));
 	ut_asserteq(1234, rec->reset_end);
 
-	/* Update a timing field */
-	rec->ebs_entry = 123;
-	rec->ebs_exit = 456;
+	/*
+	 * Update timing fields - use 0 since we know the original values are
+	 * non-zero
+	 */
+	rec->ebs_entry = 0;
+	rec->ebs_exit = 0;
 
 	/* Checksum should now be invalid */
 	ut_assert(table_compute_checksum(fpdt, fpdt->header.length) != 0);
@@ -1026,8 +1029,8 @@  static int dm_test_acpi_fpdt(struct unit_test_state *uts)
 	ut_asserteq(0, table_compute_checksum(fpdt, fpdt->header.length));
 
 	/* Verify the updated values are still there */
-	ut_asserteq(123, rec->ebs_entry);
-	ut_asserteq(456, rec->ebs_exit);
+	ut_asserteq(0, rec->ebs_entry);
+	ut_asserteq(0, rec->ebs_exit);
 
 	unmap_sysmem(buf);