From patchwork Wed Jan 14 22:56:01 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1505 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768431461; bh=E/xMmDVBgc1JJFl5iAI8ag6hKSrQmtVdPCL6eC0PYtU=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=T3jSJ9HLOxEx2XyOMtCWlJQsqPJtYrb2dx0TPPPqEa6oWFfBmBCsWjLvD5uCPDp3j 7UdFOFkKHK7TvUMBHDsMlYRoaeY2fwsVGzABrm6eiklKXkgY9cxG3ngQsFeKaZYORv UXSYviTkg+jHfLwWwVUWAg23EOVMmAWu0BDs+XI5gMLlE0aaJp/vB2wT3KSucskAeN 1iWcbioqoxURRm1z2k4eFmuj/UuP9wIx0QLIBI6Zc/ZOzCI5jL4nvddn0oU48bh9ym 4aKQb5RJ55rsVcSVIS11Twotsf+lYs9BlAgS9IypYEGoms4tuTUCBTEbjctHS0OKyV Y4weKdV1sDmYw== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 3A3FB6935C for ; Wed, 14 Jan 2026 15:57:41 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id WVQz_NcJjKDQ for ; Wed, 14 Jan 2026 15:57:41 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768431461; bh=E/xMmDVBgc1JJFl5iAI8ag6hKSrQmtVdPCL6eC0PYtU=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=T3jSJ9HLOxEx2XyOMtCWlJQsqPJtYrb2dx0TPPPqEa6oWFfBmBCsWjLvD5uCPDp3j 7UdFOFkKHK7TvUMBHDsMlYRoaeY2fwsVGzABrm6eiklKXkgY9cxG3ngQsFeKaZYORv UXSYviTkg+jHfLwWwVUWAg23EOVMmAWu0BDs+XI5gMLlE0aaJp/vB2wT3KSucskAeN 1iWcbioqoxURRm1z2k4eFmuj/UuP9wIx0QLIBI6Zc/ZOzCI5jL4nvddn0oU48bh9ym 4aKQb5RJ55rsVcSVIS11Twotsf+lYs9BlAgS9IypYEGoms4tuTUCBTEbjctHS0OKyV Y4weKdV1sDmYw== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 29C1369345 for ; Wed, 14 Jan 2026 15:57:41 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768431459; bh=RHjfI8+o50qvKdJ4qjaXtV61M6lVEZ1k2yeTx+bimEI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qIByGZNsFHMvYzzZ3hmqpJ6rm2WfSC99zsRw24u9mRjQlDX+BBeNIT6138FdGfvWT 3SOtcMRZHVfaaeFTd+S2K11xPIZhBNwYVFp6+PQJIpSMqEDatr8SN1x9glnXJYLDqC d5NPK9sGn6r9k5PToF9Pqe74/+ntALmsoTrXjTYJ7C1pPSIZswgyDPAyterXMLlwTe nR8NGPaPcE+Mu9aABnmhoMdVGPAgTP1fQhv59Ox/TQefWH0rI2Snvwb7q/V32xAOmd PPfsuQFqq9HoHQtTsx/YjBO2gvQTN0OHqvsu3lb1VmydsqBoDMSNov+IwatbCrIrN2 LdBc3Eht80/aA== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 4654069342; Wed, 14 Jan 2026 15:57:39 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id 94DJIIG5VYoZ; Wed, 14 Jan 2026 15:57:39 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768431455; bh=8hynwWOy8GEFsA1/OYxJNdBbQ9tRGcGids/8y1upvdo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cuAQhlweS8UT3TtFJJbRXKLz/qUbFK6BFBerDO9U/GWEAoGgS68c6xbJYe4Ymp9MF mo0elm2Kg/R2Qx1WyRWgaqxcqVf8S24pyE5uBBGpkYHxk7mGWZvlZgoJl80RwdQglL KpfYV2sFJChhxDSF2l+HQp2Q7/aRASER+GsZYkix6VpnNF4eOiKlOamE2d3aQrz/Wj J0LdRD6ihlHvxHDjmdGrgSNqZxOSJdtLn5i8IkluMzXFU/cIKTxjN8Zgp4p1qgXCVc 5lFVx2rSg6uCg7g+mhTRZT9inI/18Io+LIPkOyMVRGP9zHNG8U5lQWSTNohM+ni8C0 cIpOQoPLZbSmQ== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id F1575692EF; Wed, 14 Jan 2026 15:57:34 -0700 (MST) From: Simon Glass To: U-Boot Concept Date: Wed, 14 Jan 2026 15:56:01 -0700 Message-ID: <20260114225635.3407989-12-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260114225635.3407989-1-sjg@u-boot.org> References: <20260114225635.3407989-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: VIWOJN6STBFVV2TQELSRLPWAX4E5HOCK X-Message-ID-Hash: VIWOJN6STBFVV2TQELSRLPWAX4E5HOCK X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Glass , "Claude Opus 4 . 5" X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 11/34] ext4l: Remove dead iomap definitions List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass Remove the iomap type constants and struct definitions that are wrapped in a LINUX_IOMAP_H header guard. Since linux/iomap.h is already included at the top of ext4_uboot.h, this block was dead code that could never be compiled. The definitions also had different values from linux/iomap.h (e.g. IOMAP_MAPPED was 0 vs 2), which could have caused subtle bugs if the guard was ever removed. Co-developed-by: Claude Opus 4.5 Signed-off-by: Simon Glass --- fs/ext4l/ext4_uboot.h | 30 +----------------------------- 1 file changed, 1 insertion(+), 29 deletions(-) diff --git a/fs/ext4l/ext4_uboot.h b/fs/ext4l/ext4_uboot.h index 0edcb4533b7..ef40658753b 100644 --- a/fs/ext4l/ext4_uboot.h +++ b/fs/ext4l/ext4_uboot.h @@ -211,35 +211,7 @@ struct dir_context { loff_t pos; }; -/* iomap types - only define if linux/iomap.h not included */ -#ifndef LINUX_IOMAP_H -#define IOMAP_MAPPED 0 -#define IOMAP_INLINE 1 -#define IOMAP_UNWRITTEN 2 -#define IOMAP_DELALLOC 3 -#define IOMAP_HOLE 4 - -struct iomap { - u64 addr; - loff_t offset; - loff_t length; - u16 type; - u16 flags; - struct block_device *bdev; - void *inline_data; -}; - -struct iomap_ops { - int (*iomap_begin)(struct inode *inode, loff_t pos, loff_t length, - unsigned flags, struct iomap *iomap, struct iomap *srcmap); - int (*iomap_end)(struct inode *inode, loff_t pos, loff_t length, - ssize_t written, unsigned flags, struct iomap *iomap); -}; - -/* iomap DIO flags */ -#define IOMAP_DIO_UNWRITTEN (1 << 0) -#define IOMAP_DIO_FORCE_WAIT (1 << 1) -#endif /* LINUX_IOMAP_H */ +/* iomap types and structs are in linux/iomap.h */ /* fiemap types */ #define FIEMAP_FLAG_SYNC 0x00000001