From patchwork Sat Jan 10 23:56:14 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1473 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768089427; bh=Jv2ugZ3mMZZpCq5q292aD5SgxcD6Dpald9UCnlC/Arw=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=f8SmK6eoHdMPl1NT1oWPAqXV0EkucFcQN+b3MrczeR6nINcJ2aYCx/KCeTbNc2m8C aTn33JCQ3iwV3V6oNUFp3rAHYM4nJ4qlJvGs8ucr7gZ/QUM1B5IHRooLM8xuoGcgn3 AGHCtyBYbvM03C88jPiSCSsoDNqJoUZrlPRiHmnd3Ml5+tZobwKZ1TJwZNQm0m2Lsi mBhpNj3th9YjXTwuuvIsz9die8s+R8NjqmXn5GkMxtbMUU5f6yHm9Kyrn8SUF1AmXh Tr1V9ZwhExosONzgvbYcPgipBAdErOMuueOsUc/RzXljLZWlE/RUMRZ9ONIGTh75sJ Tg5rEymnLC1pQ== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 2D621692B5 for ; Sat, 10 Jan 2026 16:57:07 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 2VuGAUnItusK for ; Sat, 10 Jan 2026 16:57:07 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768089427; bh=Jv2ugZ3mMZZpCq5q292aD5SgxcD6Dpald9UCnlC/Arw=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=f8SmK6eoHdMPl1NT1oWPAqXV0EkucFcQN+b3MrczeR6nINcJ2aYCx/KCeTbNc2m8C aTn33JCQ3iwV3V6oNUFp3rAHYM4nJ4qlJvGs8ucr7gZ/QUM1B5IHRooLM8xuoGcgn3 AGHCtyBYbvM03C88jPiSCSsoDNqJoUZrlPRiHmnd3Ml5+tZobwKZ1TJwZNQm0m2Lsi mBhpNj3th9YjXTwuuvIsz9die8s+R8NjqmXn5GkMxtbMUU5f6yHm9Kyrn8SUF1AmXh Tr1V9ZwhExosONzgvbYcPgipBAdErOMuueOsUc/RzXljLZWlE/RUMRZ9ONIGTh75sJ Tg5rEymnLC1pQ== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 1B2C7692AE for ; Sat, 10 Jan 2026 16:57:07 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768089425; bh=UQ3PLLcl64zA/ZLzkCFVmmmd+MQIBssrnXRxmHGuQP0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CdWU3PnibjZUxYEFmuwXeq476UHY8caf60A6ca1j2okVhxs+QcWRy87FCSppxwxGX LIFAbf9CLQfX10Nga6JassmeVfjwA2caYFVsru7xMEZSlwwXugvyKNHMmZI7UiyA8k iNJOpdCWF0dAh1klI1DJbbvQsU7/fLXlmMeRi8ORo8PsNVVyIL77rymM/f03a++qPv ea7A36aFR4mfZ+Vz1SgfLASy4hf8ndtXLhBO3jLM6dxCdhYeGydgVScngc+25LNsFN cLJ+G+Fez1geHAXFlOjPc7SQGFDzVUIMHKk1ti62iesz6xlX8qWey9EHy3rmhQpR83 AL72Z5d2n54xw== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id F41A4692A1; Sat, 10 Jan 2026 16:57:04 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id 0hIokQhMJ2VJ; Sat, 10 Jan 2026 16:57:04 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768089420; bh=RPkdyaKbvTx8UFbf+IodHQ2wi2SUWUXlcngGj+bABEg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hE1qqWhemHIHaR6AjTOR+A0yes+qVs8j2VUQiJQ8CeBlO4mpEhSylhw8T5a6N6/TX j4W1RoDGyo3d7MLPzApKCdP6VJJuYscerDjIg0UUr1r4Dzvdld+bxlMKfSUZVxZAdG V1z9IhBirLdOCCEIwPINxarqrh6hOA5BKiAucgMQOrDtIa9GzhhqFJfUNrZVDOkCIB 0RAjWybcn88fo1GjSHqk0MUWs0ZHndlWLjrG2vk7fHU32MvKbuUhYeyBj+M+TBmGoV mtvb1IJa5dyDAwxYDJtxCPfFmSZ31WyaVUc7qwuSdfhF/78OlaJ7UeBFAR8AWfvyNR r3fSGyT7gmQQw== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id A778169186; Sat, 10 Jan 2026 16:57:00 -0700 (MST) From: Simon Glass To: U-Boot Concept Date: Sat, 10 Jan 2026 16:56:14 -0700 Message-ID: <20260110235633.1064859-2-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260110235633.1064859-1-sjg@u-boot.org> References: <20260110235633.1064859-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: GRFUTRM3DEL2RA7NNO7AJR7S2PRVC3TL X-Message-ID-Hash: GRFUTRM3DEL2RA7NNO7AJR7S2PRVC3TL X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Glass , "Claude Opus 4 . 5" X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 01/14] buildman: Rename module constants to UPPER_CASE in func_test List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass Rename settings_data to SETTINGS_DATA and commit_shortlog to COMMIT_SHORTLOG to follow Python naming conventions for module-level constants. This fixes pylint C0103 warnings. Co-developed-by: Claude Opus 4.5 Signed-off-by: Simon Glass --- tools/buildman/func_test.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/buildman/func_test.py b/tools/buildman/func_test.py index fa946c55645..9a067ec5e7a 100644 --- a/tools/buildman/func_test.py +++ b/tools/buildman/func_test.py @@ -27,7 +27,7 @@ from u_boot_pylib import terminal from u_boot_pylib import test_util from u_boot_pylib import tools -settings_data = ''' +SETTINGS_DATA = ''' # Buildman settings file [global] @@ -51,7 +51,7 @@ BOARDS = [ ['Active', 'sandbox', 'sandbox', '', 'Tester', 'Sandbox board', 'board4', ''], ] -commit_shortlog = """4aca821 patman: Avoid changing the order of tags +COMMIT_SHORTLOG = """4aca821 patman: Avoid changing the order of tags 39403bb patman: Use --no-pager' to stop git from forking a pager db6e6f2 patman: Remove the -a option f2ccf03 patman: Correct unit tests to run correctly @@ -192,7 +192,7 @@ class TestFunctional(unittest.TestCase): self._buildman_dir = os.path.dirname(os.path.realpath(sys.argv[0])) command.TEST_RESULT = self._HandleCommand bsettings.setup(None) - bsettings.add_file(settings_data) + bsettings.add_file(SETTINGS_DATA) self.setupToolchains() self._toolchains.add('arm-gcc', test=False) self._toolchains.add('powerpc-gcc', test=False) @@ -202,7 +202,7 @@ class TestFunctional(unittest.TestCase): # Directories where the source been cloned self._clone_dirs = [] - self._commits = len(commit_shortlog.splitlines()) + 1 + self._commits = len(COMMIT_SHORTLOG.splitlines()) + 1 self._total_builds = self._commits * len(BOARDS) # Number of calls to make @@ -303,7 +303,7 @@ class TestFunctional(unittest.TestCase): if '-n0' in args: return command.CommandResult(return_code=0) elif args[-1] == 'upstream/master..%s' % self._test_branch: - return command.CommandResult(return_code=0, stdout=commit_shortlog) + return command.CommandResult(return_code=0, stdout=COMMIT_SHORTLOG) elif args[:3] == ['--no-color', '--no-decorate', '--reverse']: if args[-1] == self._test_branch: count = int(args[3][2:])