From patchwork Sat Jan 10 23:56:27 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1486 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768089488; bh=fQhvgeRhi/lC9jdOsqnRrlIcRQMSof2Xi/ocYzN4a94=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=w0nQlYI8dYuWCJafGlC9igNcmrEBNvYP7p/V03/Q8F0X+PxOvKIB8o+Ho5V18yAFj 4w2QJg5CId4KIQnZPYIzfjvQYU6dAgA4o/8seohJYQeAq5N6O+X06urBhzDDpJddlb T+WM5Zdq6EcIP4Y9X4+4+YeymVAZoHxML+QEMwjaU2ztxaUf3dQTTxcHunDMQJdmeN qFAWXThZVwrGMIts9dUCwauujeCMBuZ9Lvjra8sH0KyqWMgbTd4+ALeBGx4Wwz1POx NgEMy7/CX//m/3j/qCbSp35ECJmy9KA0zdEzSD28mNc5hpSDy2Ag14gSq7yvEA1Iq7 7qbKDkohZkLAw== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 05340692B9 for ; Sat, 10 Jan 2026 16:58:08 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ioOcjpbh1cwe for ; Sat, 10 Jan 2026 16:58:07 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768089487; bh=fQhvgeRhi/lC9jdOsqnRrlIcRQMSof2Xi/ocYzN4a94=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=ibaUhaxl2RVmkN5Av1KYQgZwyEVopaA0AXpOUvXC1xFgoucuWjluag/O5z4ym3Miq cn1sBpDggVctCD1oh1GiWDLPjdJpzuAJLL/m/rsEhr9BL0E0H9W7Rzp3tzrD6Tdlsu ON6JAzPuXExmHOfuIpzhTYGRvyUr6cznW/0y0SXfExfU4Z8gOOCxhD9und39/rm4h2 4DLpgi2jRXh8EJqeIjRwy51MCUP9ohczVbMxg5ZLFxDcxqrejjgloEdL5BcxiFcNXW 8QBK50RQJEErIeIl4RwYbi3YzPVhflz96sutpsqRY4JNGHjLSJ1TbVF1UBRnWNYK0+ 9ohfQh2jIir0g== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id E837B692AE for ; Sat, 10 Jan 2026 16:58:07 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768089486; bh=5MOODEWHM3RS9kkv0IH5JWFYekOLt1pxhQ8+ekWyXLE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JWpieEg2PQwmssIh+ZL+grZ8JU9xMnjj09K3wX/0NAJIcfxMZPgHXM10P+GQTpKux 6LoOMaj+zw9+88LmW9hFi0pfbHlgP2IC4ZM/rb735Jqvfz5d5Fz0LX364TsTj6o6ro MaMiBo4DyPuTD7ktsJYFuEG6CA7M2wAgJMg0PyioWtqO5BruQtBHOu4/eesjp3L8Ap 34qitaYuuGJHQ4DhpvcY2t/NrvbVz4NFrDF/m/4Sccw2555XuxjOQR4KtIsxd10Vvj F8sH3+swZPVt+7ulLk9R6adOL9HjVYefOEO87Tf7HeC/g9jf/aLv9QYNHbXaA/gdru 6O05Ia0Bt15MA== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 1A83669186; Sat, 10 Jan 2026 16:58:06 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id dbVfczpaHmrv; Sat, 10 Jan 2026 16:58:06 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768089482; bh=UXqOoZwh+s+SFsa93iRGSWoCqezA2wt0fZDlT5M3Yws=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rozvI9nk52hmcf3kaS0cX/Wi+5aqqbivir91OXdKoTpu0/ppwZNEhBRtjldP5KOgO 37AkEO2xQoqqbQrdkvbr8xh64X+Sck3nWTtP9zqdpbuYfvxqksx4mV6QD9j1PkEK1i ASFZ/zLZExoUUSNFBzBebj2S0g2BG49t83UIcXrvGm0kq9wHZ/DGa3MWE+nLhlnXn0 PJtzNtV7GRjqN0+lNAaysVeolikVwjp94ie0X6t1fuJyufmX9kfQSYPJiFj2MQc4+c XeDVB+/nBsvQK4/xtC8p+m131LMtq0lQ6xrJzE9j3lx6u9INsLQj3SQbXGPZGDkH/t buKHEUu3d1vMA== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id BC854692AE; Sat, 10 Jan 2026 16:58:01 -0700 (MST) From: Simon Glass To: U-Boot Concept Date: Sat, 10 Jan 2026 16:56:27 -0700 Message-ID: <20260110235633.1064859-15-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260110235633.1064859-1-sjg@u-boot.org> References: <20260110235633.1064859-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: IQWWQPYBDRSIPNNKHRDYR64G3V7SA5S3 X-Message-ID-Hash: IQWWQPYBDRSIPNNKHRDYR64G3V7SA5S3 X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Glass , "Claude Opus 4 . 5" X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 14/14] buildman: Suppress pylint warnings for test structure List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass Suppress warnings that are inherent to the test module structure: - too-many-lines: The functional test module necessarily contains many test methods and helper functions - too-many-instance-attributes: The test class requires many attributes for mocking and test state Splitting the module or class would reduce cohesion without improving maintainability. Co-developed-by: Claude Opus 4.5 Signed-off-by: Simon Glass --- tools/buildman/func_test.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tools/buildman/func_test.py b/tools/buildman/func_test.py index d784210446b..4a207bfb00c 100644 --- a/tools/buildman/func_test.py +++ b/tools/buildman/func_test.py @@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0+ # Copyright (c) 2014 Google, Inc # +# pylint: disable=too-many-lines """Functional tests for buildman @@ -180,6 +181,8 @@ Date: Fri Aug 22 15:57:39 2014 -0600 TEST_BRANCH = '__testbranch' + +# pylint: disable=too-many-instance-attributes disable=too-many-public-methods class TestFunctional(unittest.TestCase): """Functional test for buildman. @@ -443,7 +446,7 @@ Idx Name Size VMA LMA File off Algn print(line, file=buf) return command.CommandResult(stdout=buf.getvalue(), return_code=0) - def _handle_command(self, **kwargs): + def _handle_command(self, **kwargs): # pylint: disable=too-many-branches """Handle a command execution. The command is in kwargs['pipe-list'], as a list of pipes, each a @@ -488,7 +491,7 @@ Idx Name Size VMA LMA File off Algn result.stdout = len(result.stdout.splitlines()) return result - def _handle_make(self, commit, brd, stage, cwd, *args, **_kwargs): + def _handle_make(self, commit, brd, stage, cwd, *args, **_kwargs): # pylint: disable=too-many-branches """Handle execution of 'make' Args: @@ -715,7 +718,7 @@ Idx Name Size VMA LMA File off Algn self.assertEqual(captured_stderr.getvalue(), 'branch_error.c:456: error: branch failure\n') - def test_branch_summary(self): + def test_branch_summary(self): # pylint: disable=too-many-statements """Test building a branch and then showing a summary""" self._run_control('-b', TEST_BRANCH, '-o', self._output_dir) self.assertEqual(self._builder.count, self._total_builds) @@ -1205,7 +1208,7 @@ Active aarch64 armv8 - armltd total_compute board2 Path(os.path.join(config_dir, 'board0_defconfig')).unlink() self.assertFalse(boards.output_is_new(boards_cfg, config_dir, src)) - def test_maintainers(self): + def test_maintainers(self): # pylint: disable=too-many-statements """Test detecting boards without a MAINTAINERS entry""" src = self._git_dir main = os.path.join(src, 'boards', 'board0', 'MAINTAINERS')