From patchwork Sat Jan 10 20:28:36 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1450 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768076982; bh=alqbKcYW68anGXjzNMxW5rxAYJY6bv8WHTdxO1HL9GQ=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=n/QDalMsADLxDJzAD3rAV2g46vIO1kIntE6sg1qdlbU8L7Rj8u4MGxWwr6lQS36p3 Txrtf9nX3FTq4BuWD65WTLdljKsnJslBLIYMu5e9dsrPFf41D/NvW401mTtQGA56/D pwaYOH2m09AWGFGAnxMi+6ncqtHimxGAUOWjPuyqcEkOWq3mtbbvD2SmxRJVlAhorN H2vkKspqXVSCso3aSpIpp/wkPJfUP0+mW2TK6PpsXdLIfSBg0fe/ku2YpPSdRU2qHy NFgaB5EOL9eXNi/E1hvOFwDvf0wlkT6N3s3QNK2tTn1ALT+4M+ivdovkhsGc2mZHZ6 j0zD6nMx8Ag5g== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 181DE69291 for ; Sat, 10 Jan 2026 13:29:42 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id PJYvbYguR8o4 for ; Sat, 10 Jan 2026 13:29:42 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768076982; bh=alqbKcYW68anGXjzNMxW5rxAYJY6bv8WHTdxO1HL9GQ=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=n/QDalMsADLxDJzAD3rAV2g46vIO1kIntE6sg1qdlbU8L7Rj8u4MGxWwr6lQS36p3 Txrtf9nX3FTq4BuWD65WTLdljKsnJslBLIYMu5e9dsrPFf41D/NvW401mTtQGA56/D pwaYOH2m09AWGFGAnxMi+6ncqtHimxGAUOWjPuyqcEkOWq3mtbbvD2SmxRJVlAhorN H2vkKspqXVSCso3aSpIpp/wkPJfUP0+mW2TK6PpsXdLIfSBg0fe/ku2YpPSdRU2qHy NFgaB5EOL9eXNi/E1hvOFwDvf0wlkT6N3s3QNK2tTn1ALT+4M+ivdovkhsGc2mZHZ6 j0zD6nMx8Ag5g== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 0624C69281 for ; Sat, 10 Jan 2026 13:29:42 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768076979; bh=UTTgChXt1KvjFlM8sUDPQR8W8oMLFjAcmmQh+RiSSTE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tXVAbkp0/ktt9fBL6tfWFF7bkvUyWlFyHA+AHka8llx5ablgHGqXWRLzHp19h6NO8 m+LlBPVDhMP5C1qtgkudBgAVqxCZJRUgbOZ1m8C7dUeyI5GNKXE75bwA6VR7oYtwWY WMkG7Uzj1pyxuFzM+IZCucaSPwUq9Ir0+gPdOJy+BiEf3BLpINpV++9RSbyDG+OIh7 VFd5NHEigz5KB7uTa+yRcaEW/CTj0Sxs8bxNyO6urT1rOFvQu1bwLfJkco71/d7fP5 BFsGrJNsT7MLRrz9kTjNXEVjj5p75STnQS1jGjUWSJGBX9CzMf8MljRvkc0Wp83osf tZvrdDLrLP9AA== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 8606B6927E; Sat, 10 Jan 2026 13:29:39 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id BmgkcWeJh4LM; Sat, 10 Jan 2026 13:29:39 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768076975; bh=3pYdJC3b6+Ta/2MFwIxjPBqsxD9NWuKEajKSdrc9pBQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LgZncEKFMLQ8zly4GBaQS1X+F1Y5KPHCq/XUEeHqaNhnI7wCPYx4tpMF3fx1Dgdxn Td99hqi/qXKV7fWvZZuzMmAqGnOQMBOt21bLBSCYKi7HH41TrTPbkqBfMq0Q9DTpKO cPmgXARQHORSACPvCXq8XoKKBItEO0mnwQrkjXGTwU7NmRjVydApYGdEaUtBMWFr7Z INfb4Af2TLlJKz5QTe2okutM6vUZV8CJL+KOCsxMtBpXcb9sI3gjldU++2KtRYEQ7o xC1SdICT8ujO6viAXzByCG7rffbhHlxrAKD0kG4HqHb1eAW5BQVRcmlc6dFlfNHey4 OVOX9TljgInaA== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 23F1669186; Sat, 10 Jan 2026 13:29:35 -0700 (MST) From: Simon Glass To: U-Boot Concept Date: Sat, 10 Jan 2026 13:28:36 -0700 Message-ID: <20260110202906.187370-5-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260110202906.187370-1-sjg@u-boot.org> References: <20260110202906.187370-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: 7CFFQX5FDK736VNVOQ4JLYUXKCA6OP24 X-Message-ID-Hash: 7CFFQX5FDK736VNVOQ4JLYUXKCA6OP24 X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Heinrich Schuchardt , Simon Glass , "Claude Opus 4 . 5" X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 04/26] boot: pxe: Free menu label in label_destroy() List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass The menu field of pxe_label is allocated by parse_sliteral() in parse_label_menu() but is never freed. Add the missing free() call in label_destroy() to prevent a memory leak. Co-developed-by: Claude Opus 4.5 Signed-off-by: Simon Glass --- boot/pxe_parse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/boot/pxe_parse.c b/boot/pxe_parse.c index 8c720db5e75..e5af05d4120 100644 --- a/boot/pxe_parse.c +++ b/boot/pxe_parse.c @@ -116,6 +116,7 @@ void label_destroy(struct pxe_label *label) struct pxe_fdtoverlay *overlay; free(label->name); + free(label->menu); free(label->kernel_label); free(label->kernel); free(label->config);