| Message ID | 20260110202906.187370-3-sjg@u-boot.org |
|---|---|
| State | New |
| Headers |
Return-Path: <concept-bounces+u-boot-concept=u-boot.org@u-boot.org> X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768076971; bh=Z5Ls6s3VhMnAYiKnx8c3cZgRAgoYkNov1JRDKKl0hrk=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=pe2M5VhTy6Y9bAF8riiwek1pNFMyLWNmH5e64RQMm7LYjLNRn4Y+24lvC5g2OTVcv /zDuroF9oKl3wxYLI9Lj6yjdTJXyIvTBLpy6L1drRLIK2G3pNOx2+bcM4dziwIQnqV AWuSZ0/tuWSj8ohHPcTF4ZPErUssKMFaOsxjkkm72f3ery6TSRgwV2d8AL8VyvNlRT kqhDAKkFLfwwlJZw/9wFX8Nj4N6d1WrrnLbiMxK9hrugIuUm/9J8C9bbCGqL48Vm/g 71YkyKxWwi7j5YAd/KUDPplZ8ILsovPSd4TAt0HkoINnGphGnP7PTu3U/xZkpe+tyn lcnsvtSFfNi8w== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id B11AB69296 for <u-boot-concept@u-boot.org>; Sat, 10 Jan 2026 13:29:31 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id JUZsCAyyG6Yh for <u-boot-concept@u-boot.org>; Sat, 10 Jan 2026 13:29:31 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768076971; bh=Z5Ls6s3VhMnAYiKnx8c3cZgRAgoYkNov1JRDKKl0hrk=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=pe2M5VhTy6Y9bAF8riiwek1pNFMyLWNmH5e64RQMm7LYjLNRn4Y+24lvC5g2OTVcv /zDuroF9oKl3wxYLI9Lj6yjdTJXyIvTBLpy6L1drRLIK2G3pNOx2+bcM4dziwIQnqV AWuSZ0/tuWSj8ohHPcTF4ZPErUssKMFaOsxjkkm72f3ery6TSRgwV2d8AL8VyvNlRT kqhDAKkFLfwwlJZw/9wFX8Nj4N6d1WrrnLbiMxK9hrugIuUm/9J8C9bbCGqL48Vm/g 71YkyKxWwi7j5YAd/KUDPplZ8ILsovPSd4TAt0HkoINnGphGnP7PTu3U/xZkpe+tyn lcnsvtSFfNi8w== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id A115C6928E for <u-boot-concept@u-boot.org>; Sat, 10 Jan 2026 13:29:31 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768076970; bh=VNteaEQI31oKdF7jQbXaOixlpNm3VRfoc9OxP3V5DIE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Xei7AJX0VyyS9nq5twS9mqzHka8aCLqZeCtBT+b06+M0o9s9Ct7cnVMmPYh5aFGrA HezNLYp7EmmEOH7kp5Zy7+Y/KXjqZL1qgSKJq4+gdJn9/nh5mAJGFKuGcBFt0/3rRi YsR0z0h8vIHX3seNNID6RDGdvcrz9QbdQ6p9H4xX+Rohr6TLUyw6GCzalqiIAjmGu9 h4Vcg3Imcml+Vi0nQsF2T8XKiPZgKKAJGxFRcLfl2PXAz6biVBB+NTmtUr0mj/DkTj Ts5YV6NgMbt6AOuP4g+lNnDlsUEy+xKYQzMRxprj3kBm4v1m4PfQ9v2P+MPf8iJz4k nwjsYG2YKS+gw== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 215B46927E; Sat, 10 Jan 2026 13:29:30 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id N8-B9mlzlLRp; Sat, 10 Jan 2026 13:29:30 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768076966; bh=+gbYBtcPf8uLfc/MnRVPERkvU8kI7b2vbaVH+NLn/ec=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PNBzQbGc0jH8Rc5DTGg6kcsejc4KQt/tkR+Hh/MeXFzqaeVJ3AMCjCFWBzOzh7XqL y0H3RYCjPngpFBTDl6O6sMyQxfNI59IAx4edzF/GKR1PIHJqKVx4Vl5ll3gRvFOhWs s2QW+dDp8lhfOWQ23pYszWUxPyp8aOV0DI0PbrZJrUjFcDjMuen71rGVxUxTmsnQMz DiJOnmo1g61YPTuMr75gt9gmzWW6Ts5sTpiyD2X4XYcx1N5CGK3VfKLc7pDnS3t3ML rIxhcF1yciFprhzSx4QCEqhDLrfS5kVs1K2ICjD4KgBXQg32bWFugnj5M/ycY/oVXe c7i+v/cXVSLUg== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id B603B69186; Sat, 10 Jan 2026 13:29:25 -0700 (MST) From: Simon Glass <sjg@u-boot.org> To: U-Boot Concept <concept@u-boot.org> Date: Sat, 10 Jan 2026 13:28:34 -0700 Message-ID: <20260110202906.187370-3-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260110202906.187370-1-sjg@u-boot.org> References: <20260110202906.187370-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: 2ZU5PJFG4MRAO2E7VNMRCDDXWBB3OUPG X-Message-ID-Hash: 2ZU5PJFG4MRAO2E7VNMRCDDXWBB3OUPG X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Heinrich Schuchardt <xypron.glpk@gmx.de>, Simon Glass <simon.glass@canonical.com>, "Claude Opus 4 . 5" <noreply@anthropic.com> X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 02/26] boot: pxe: Free bmp in pxe_menu_uninit() List-Id: Discussion and patches related to U-Boot Concept <concept.u-boot.org> Archived-At: <https://lists.u-boot.org/archives/list/concept@u-boot.org/message/2ZU5PJFG4MRAO2E7VNMRCDDXWBB3OUPG/> List-Archive: <https://lists.u-boot.org/archives/list/concept@u-boot.org/> List-Help: <mailto:concept-request@u-boot.org?subject=help> List-Owner: <mailto:concept-owner@u-boot.org> List-Post: <mailto:concept@u-boot.org> List-Subscribe: <mailto:concept-join@u-boot.org> List-Unsubscribe: <mailto:concept-leave@u-boot.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit |
| Series |
boot: pxe: Add three-phase API and fix memory leaks
|
|
Commit Message
Simon Glass
Jan. 10, 2026, 8:28 p.m. UTC
From: Simon Glass <simon.glass@canonical.com> The bmp field of pxe_menu is allocated by parse_sliteral() in parse_menu() but is never freed. Add the missing free() call in pxe_menu_uninit() to prevent a memory leak. Co-developed-by: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Simon Glass <simon.glass@canonical.com> --- boot/pxe_utils.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/boot/pxe_utils.c b/boot/pxe_utils.c index 52032d683c3..9444effbb6a 100644 --- a/boot/pxe_utils.c +++ b/boot/pxe_utils.c @@ -985,6 +985,7 @@ void pxe_menu_uninit(struct pxe_menu *cfg) free(cfg->title); free(cfg->default_label); free(cfg->fallback_label); + free(cfg->bmp); list_for_each_safe(pos, n, &cfg->labels) { label = list_entry(pos, struct pxe_label, list);