From patchwork Sat Jan 10 20:28:53 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1467 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768077057; bh=8xQboB7CplAXRhnsmCk+WWzYt4yISfL9hCsIj9y4K/U=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=eIdVqR+uhOp1AGbG31bhaoJSHXsyNqWmsfWPgp6OIuOdsF9ZD6JW1UBRubX79K/3y pS759hH77XyKYPyF8y+TWzKpXMFTwZfZsrBGtSktuG/DYUicz3QZTklOkFzm6J/pD8 GeudxNDA333axYXqBOa4uckC0PzTTq8hYgnAj0UOOwb1R8vTaxEXlgtOGxI3B1qwkL 6CyJpQQfP3NGwapIo3ADxQNZqBEhRPvya4TeTTj/ZafxeA0kSMc+AOCtMJXYI2dKAr ocdmESY8fbeticZCW3Ff/BTfAcbPILnSMPM8QjxMKHczYIigcqMGDAULyUoh+yeYEk HY5ewyo+jqjzw== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id CEF23692A6 for ; Sat, 10 Jan 2026 13:30:57 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id M8KbbC7WlHHH for ; Sat, 10 Jan 2026 13:30:57 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768077057; bh=8xQboB7CplAXRhnsmCk+WWzYt4yISfL9hCsIj9y4K/U=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=eIdVqR+uhOp1AGbG31bhaoJSHXsyNqWmsfWPgp6OIuOdsF9ZD6JW1UBRubX79K/3y pS759hH77XyKYPyF8y+TWzKpXMFTwZfZsrBGtSktuG/DYUicz3QZTklOkFzm6J/pD8 GeudxNDA333axYXqBOa4uckC0PzTTq8hYgnAj0UOOwb1R8vTaxEXlgtOGxI3B1qwkL 6CyJpQQfP3NGwapIo3ADxQNZqBEhRPvya4TeTTj/ZafxeA0kSMc+AOCtMJXYI2dKAr ocdmESY8fbeticZCW3Ff/BTfAcbPILnSMPM8QjxMKHczYIigcqMGDAULyUoh+yeYEk HY5ewyo+jqjzw== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id B9AFB69291 for ; Sat, 10 Jan 2026 13:30:57 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768077055; bh=pmDJGutB0dYUHHowfSfcKg1y5WvmU3o/NTUO319qULk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aAUz3fJj82u1NO3bOQsOwrmcKjs6CgD//djRuMIN2xuz2aT5CXTOxnUj7KwW+74Wl XpjnCCQSCaezPEiUgRkN3OIzHTHi6Y1NrF6B6dmoWvKfbJpODgesQSlzwmRT4zBjL4 Q5DfKdve/UtZnVGBaZjvFQkF3izFZJarvNt2AknVpMcl3BCXzIX+CaawIQMPaTSoqO XLFxzPldnK7SpoZmczzIj/tNyB07mFO/jdegNNrqRu/oe7rrtGS98slVy6LZX8kzCi F/a+m2otKGhyQ666l79ydUMmAWkJcXeuThRbcuuIh7hZFLyuVt4dQEoQ++QK/bCFHy 9COs3OEbVMIsw== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 941366927E; Sat, 10 Jan 2026 13:30:55 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id oqxRh2LeaYdm; Sat, 10 Jan 2026 13:30:55 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768077051; bh=wphXtadLjg5Xuo5bRC4I96vbVVRw5USFljRVUvA/fnU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XwHj9LO0eL0MjA7EfD7cHSqxUiTs2YPk8aAsRiBGo7gU7vgqBwQ+fkgErzKKEJAFj rBNbKaUmOX6AJnH2rElk/H8oA1ZfL0D+nfXNHA4kVedFHYYzUg4zfx9qekKe4B2N1s MSyX4ftxb5yW1jMxG+ispVoNpBjlvW0rTigGfFGMcGxnZBAkUxJwyVjhGWuSeNXTR7 DnczIAdvMUMtQkOwTQdNB7PK5MXg+oRKB5Dqklav3Y+SyGvNCI31NmoK4nV2bz/iJL hCYS5ztGTGLCqsiJTeD4zQ1mSBHoFVWDMFEWZAhCbWRVtXDSI/qoDf8K+q8a5c1fad Q89WYGtdT7Nfw== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 36F5969186; Sat, 10 Jan 2026 13:30:51 -0700 (MST) From: Simon Glass To: U-Boot Concept Date: Sat, 10 Jan 2026 13:28:53 -0700 Message-ID: <20260110202906.187370-22-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260110202906.187370-1-sjg@u-boot.org> References: <20260110202906.187370-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: 6I7HAUKLFUTZIAIDSHGBAYZSLAWGS7RV X-Message-ID-Hash: 6I7HAUKLFUTZIAIDSHGBAYZSLAWGS7RV X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Heinrich Schuchardt , Simon Glass , "Claude Opus 4 . 5" X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 21/26] boot: pxe: Remove unused base parameter from parse_pxefile_top() List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass The parse_pxefile_top() function takes a base parameter but never uses it. Remove this dead parameter. Co-developed-by: Claude Opus 4.5 Signed-off-by: Simon Glass --- boot/pxe_parse.c | 2 +- boot/pxe_utils.c | 4 ++-- include/pxe_utils.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/boot/pxe_parse.c b/boot/pxe_parse.c index 52216c0b7ef..3d113a6fd83 100644 --- a/boot/pxe_parse.c +++ b/boot/pxe_parse.c @@ -691,7 +691,7 @@ static int parse_label(char **c, struct pxe_menu *cfg) */ #define MAX_NEST_LEVEL 16 -int parse_pxefile_top(struct pxe_context *ctx, char *p, ulong base, +int parse_pxefile_top(struct pxe_context *ctx, char *p, struct pxe_menu *cfg, int nest_level) { struct token t; diff --git a/boot/pxe_utils.c b/boot/pxe_utils.c index d2ba0412906..b5320f2f6cf 100644 --- a/boot/pxe_utils.c +++ b/boot/pxe_utils.c @@ -1013,7 +1013,7 @@ struct pxe_menu *parse_pxefile(struct pxe_context *ctx, struct abuf *buf) if (!cfg) return NULL; - r = parse_pxefile_top(ctx, abuf_data(buf), abuf_addr(buf), cfg, 1); + r = parse_pxefile_top(ctx, abuf_data(buf), cfg, 1); if (r < 0) { pxe_menu_uninit(cfg); @@ -1069,7 +1069,7 @@ int pxe_parse_include(struct pxe_context *ctx, const struct pxe_include *inc, int ret; buf = map_sysmem(addr, 0); - ret = parse_pxefile_top(ctx, buf, addr, inc->cfg, inc->nest_level); + ret = parse_pxefile_top(ctx, buf, inc->cfg, inc->nest_level); unmap_sysmem(buf); return ret; diff --git a/include/pxe_utils.h b/include/pxe_utils.h index 9682956932b..11be00da199 100644 --- a/include/pxe_utils.h +++ b/include/pxe_utils.h @@ -510,7 +510,7 @@ int pxe_setup_label(struct pxe_context *ctx, struct pxe_label *label); * * Returns 1 on success, < 0 on error. */ -int parse_pxefile_top(struct pxe_context *ctx, char *p, ulong base, +int parse_pxefile_top(struct pxe_context *ctx, char *p, struct pxe_menu *cfg, int nest_level); /**