| Message ID | 20260110202906.187370-21-sjg@u-boot.org |
|---|---|
| State | New |
| Headers |
Return-Path: <concept-bounces+u-boot-concept=u-boot.org@u-boot.org> X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768077051; bh=UmieXbEfq1LnV+YNYcHLRTnWmr9gs7YDGH0V6WKXJmM=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=h+w+j63MVEohfhPBgqj0sLfr/Hi8+w67JxQkEAL11vuDDzweRNhs24yYTye+rODOr se7O0sN3bXQK5ITZfHwOPP/x3lEUpCuLutvY0zBkisFOaDu88YzqDw3srhi7rf+h5/ 5d4xLjTkTgXB84VHd+T3J6xinLIsKzrDixaaZKW1AKyCT6gm0vuPm/AmKjNswWhteU 7ULViBsh/dASmrdSU5VqiGXKor5rGKdfBM73PKW3zay73v2wEr4FaHhdTylJ4UcZUR sMsIDn/mPXNBzKgLnJfW/6kXJ1MAV1IvsfQy/P9jLty7md7UR0qNX7OMgf18H+i0wm VOADIMavYaZTg== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id E6DDA69291 for <u-boot-concept@u-boot.org>; Sat, 10 Jan 2026 13:30:51 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 7w8fUi2boIBQ for <u-boot-concept@u-boot.org>; Sat, 10 Jan 2026 13:30:51 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768077051; bh=UmieXbEfq1LnV+YNYcHLRTnWmr9gs7YDGH0V6WKXJmM=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=h+w+j63MVEohfhPBgqj0sLfr/Hi8+w67JxQkEAL11vuDDzweRNhs24yYTye+rODOr se7O0sN3bXQK5ITZfHwOPP/x3lEUpCuLutvY0zBkisFOaDu88YzqDw3srhi7rf+h5/ 5d4xLjTkTgXB84VHd+T3J6xinLIsKzrDixaaZKW1AKyCT6gm0vuPm/AmKjNswWhteU 7ULViBsh/dASmrdSU5VqiGXKor5rGKdfBM73PKW3zay73v2wEr4FaHhdTylJ4UcZUR sMsIDn/mPXNBzKgLnJfW/6kXJ1MAV1IvsfQy/P9jLty7md7UR0qNX7OMgf18H+i0wm VOADIMavYaZTg== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id D6CA569296 for <u-boot-concept@u-boot.org>; Sat, 10 Jan 2026 13:30:51 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768077050; bh=SH+rYp9MDZSOhoLmNIE+rq9X93EVqfMuxxMFgKQHEBA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oYofg/bY7Y8K3Jv3yifyf28/+GT02tDW3euotZSYagCAV60EwKuABVHBfD5rv6J0O yj2Kk/xg1fyIWMzMJe1xSm4HqqwHetjkGD5iYDshSitJdEplCMpOTMvbrMJBgbHfmX M2xarXnO+jY2dLJB7iB6rGcGjQXfT6IqgtNjmRi+yRmIzu1Q4WcS5XwuQVnGDOs12U CyEGVNvwKkbhKJU86aYHGZv7J+JsCcr5tnmDCBXqDznSBIClI5FdFgDxYHIriO/OrN JmID+XKiA2Gf7qlPiwGYfL4zQM+p3y4QabaGNHtmrZId6RAfh0p+BAsdSKXN930qKP huEl9sO+nNQqg== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id E0A796927E; Sat, 10 Jan 2026 13:30:50 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id iyoMhtib_Ulh; Sat, 10 Jan 2026 13:30:50 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768077046; bh=mJRDb/anzgA8ZOQyHABfSwRVg09uf5HlyqWQTwkWdu8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=twJWNNIJVms0LGFnXmYBJ0OrOo8igt6JnXucr6uwca2k++QGZoAAr0fn/Z3Z/LmnN pLr8fAzGbAGNc3D7Eq33Mzm6X7jTqAR0bLAZOuqJfbX0k8uBEELHzgjHEMlknNoq5w k+kVRsQulT9+7XfCfM2drOc6XtHfZSAo3TiOwix4hKctFp0JVgCp05E/ULRIPEkUjC l/+t6PXb57BD1FP8oOQjW0WMGQa+k9d1CsO0jLbmRgDwoVDvOFUVp7G/JBW2J1kPur ErI3apcXmVwvvbK9XvJVffWJ4YSF5hoAQlbl1RKwh+m+1+FPPG15wOIB8zzW8+xcAr kGOyz+HHU2Y+Q== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 8D16E69186; Sat, 10 Jan 2026 13:30:46 -0700 (MST) From: Simon Glass <sjg@u-boot.org> To: U-Boot Concept <concept@u-boot.org> Date: Sat, 10 Jan 2026 13:28:52 -0700 Message-ID: <20260110202906.187370-21-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260110202906.187370-1-sjg@u-boot.org> References: <20260110202906.187370-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: M4CVXZNSXWZCBQXP5NZAFVBGFKYM746O X-Message-ID-Hash: M4CVXZNSXWZCBQXP5NZAFVBGFKYM746O X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Heinrich Schuchardt <xypron.glpk@gmx.de>, Simon Glass <simon.glass@canonical.com>, "Claude Opus 4 . 5" <noreply@anthropic.com> X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 20/26] boot: pxe: Remove unused base parameter from parse_menu() List-Id: Discussion and patches related to U-Boot Concept <concept.u-boot.org> Archived-At: <https://lists.u-boot.org/archives/list/concept@u-boot.org/message/M4CVXZNSXWZCBQXP5NZAFVBGFKYM746O/> List-Archive: <https://lists.u-boot.org/archives/list/concept@u-boot.org/> List-Help: <mailto:concept-request@u-boot.org?subject=help> List-Owner: <mailto:concept-owner@u-boot.org> List-Post: <mailto:concept@u-boot.org> List-Subscribe: <mailto:concept-join@u-boot.org> List-Unsubscribe: <mailto:concept-leave@u-boot.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit |
| Series |
boot: pxe: Add three-phase API and fix memory leaks
|
|
Commit Message
Simon Glass
Jan. 10, 2026, 8:28 p.m. UTC
From: Simon Glass <simon.glass@canonical.com> The parse_menu() function takes a base parameter but never uses it. Remove this dead parameter. Co-developed-by: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Simon Glass <simon.glass@canonical.com> --- boot/pxe_parse.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/boot/pxe_parse.c b/boot/pxe_parse.c index bcbe0495cbb..52216c0b7ef 100644 --- a/boot/pxe_parse.c +++ b/boot/pxe_parse.c @@ -460,7 +460,7 @@ static int handle_include(char **c, struct pxe_menu *cfg, int nest_level) * a file it includes, 3 when parsing a file included by that file, and so on. */ static int parse_menu(struct pxe_context *ctx, char **c, struct pxe_menu *cfg, - unsigned long base, int nest_level) + int nest_level) { struct token t; char *s = *c; @@ -714,9 +714,7 @@ int parse_pxefile_top(struct pxe_context *ctx, char *p, ulong base, switch (t.type) { case T_MENU: cfg->prompt = 1; - err = parse_menu(ctx, &p, cfg, - base + ALIGN(strlen(b) + 1, 4), - nest_level); + err = parse_menu(ctx, &p, cfg, nest_level); break; case T_TIMEOUT: err = parse_integer(&p, &cfg->timeout);