From patchwork Fri Jan 9 18:30:58 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1384 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767983522; bh=5hlYwAAMsIeOfD5yFKoq7KOWbMOaTP9+i1Ecs5QQr0A=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=Qq/rrZ4slPpunrdNZxL5ZoD++K3MzcKkhEhfjtzAkkWr1XSpzETypwLuLzCH0t2Eg XG+wr+A+RG+4q7MNN5P+wwlCocuv668eGFtcj1bSlAeAf1TxbYomSXagbekyOHi6Ep qi1nM68kQJBAQeQsjsRK4OuA6e8BhxXqnavEtpAGyaaaBlilNU0skp9QTstxgDhTxK vA8FvKos6BC6BPecrubw+B9/TKISE/ejuxgcPK39suBlCORSoam7tji/u/qla2LSN2 cpGf3CYBmS6NNWD29A8O+RiHhgUDhfXrSL3gj+i5wuz9SUjhxfaGANAQq5QczuvvU5 pk4mtcVix4aUA== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id A44B469218 for ; Fri, 9 Jan 2026 11:32:02 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id To-07hrjZ4wh for ; Fri, 9 Jan 2026 11:32:02 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767983522; bh=5hlYwAAMsIeOfD5yFKoq7KOWbMOaTP9+i1Ecs5QQr0A=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=Qq/rrZ4slPpunrdNZxL5ZoD++K3MzcKkhEhfjtzAkkWr1XSpzETypwLuLzCH0t2Eg XG+wr+A+RG+4q7MNN5P+wwlCocuv668eGFtcj1bSlAeAf1TxbYomSXagbekyOHi6Ep qi1nM68kQJBAQeQsjsRK4OuA6e8BhxXqnavEtpAGyaaaBlilNU0skp9QTstxgDhTxK vA8FvKos6BC6BPecrubw+B9/TKISE/ejuxgcPK39suBlCORSoam7tji/u/qla2LSN2 cpGf3CYBmS6NNWD29A8O+RiHhgUDhfXrSL3gj+i5wuz9SUjhxfaGANAQq5QczuvvU5 pk4mtcVix4aUA== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 8E1A869211 for ; Fri, 9 Jan 2026 11:32:02 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767983520; bh=mJmmU21R9BQwgSr423IfQug5mbqGqhd4AqKW9bKYSAs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XxuBMNwWybc/kyy/oVznQWGs8Cfzdk6mzAgyRT+vJn8WGwbXAuGrZwcvun1jH7i7L v3+8YWEUqPCUsHJVKzZ/yvHK7/YppMtcE1tXlFq/nraRl6pDl/4NQYczGH4yonPJ7M jfFGaWlu5TsCA1dIgKJjeQi+NRX1Slk0w4NYn7lvbBwVFkVK7qdWUG0lLoPcVZ0vbg 2lLB0RzmXG4d2zmtjPvRCxR+EqjrKZkGwdqx26TGTfghFL1U+z6kBh0AakslQJP6RR zz930FlaLGFWnLFegfoNY98I3E6CLBxn0MjqsSNS1BI3GMfHPlQs4UDG7t7sqMBOvb IilgJTmkv32BA== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id E839F69208; Fri, 9 Jan 2026 11:32:00 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id i3H5kleR7mE5; Fri, 9 Jan 2026 11:32:00 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767983516; bh=fiWuFP9rruEZwlAL/XhHPtJhpXhxWbbojBrzXqgfr2s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X6O2S2bCzB5JISHTgonhbJZlf4X+LspJf9MkUQJrwgVawYsLMBL/gzaziaC40S8Nu HTVcbX3JMjwfdibv/b7/fZ/AHzoQmEDOFzL1LBcGBHLfiLpeb/BDotHzzpme6knkom y2/YWpCjYrypDUrx2l1Ze/bbFr8dUofcaG7EZBWZWqfySIfb7HGnPYOz0ztgHsY44X oeWCxZNSrIwsSNrtlwsalOqIJ5AM4hRcPV1IUEEvNETvDRgey6uLd/hHrHbUUXGzQI 4dL0hcVACI9QAQ9fHX8ZlGO7/A07pnNSSrlk/XaQ3eflnzHIElJXLA9SsejWxBarRr HC9S2w1iOqSrw== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 7074069209; Fri, 9 Jan 2026 11:31:56 -0700 (MST) From: Simon Glass To: U-Boot Concept Date: Fri, 9 Jan 2026 11:30:58 -0700 Message-ID: <20260109183116.3262115-7-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260109183116.3262115-1-sjg@u-boot.org> References: <20260109183116.3262115-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: 6MHY6R3DUOKSRQRWQ5HMROGEA3UA3N6B X-Message-ID-Hash: 6MHY6R3DUOKSRQRWQ5HMROGEA3UA3N6B X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Heinrich Schuchardt , Simon Glass , "Claude Opus 4 . 5" X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 06/18] buildman: Fix config value change detection List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass Config value changes are never detected because tconfig.config.get(key) looks up the config key in the filename-keyed dict instead of the config dict for the current file. Change to tconfig.config[name].get(key) to correctly look up the config value in the current file's config dict. Co-developed-by: Claude Opus 4.5 Signed-off-by: Simon Glass --- tools/buildman/builder.py | 2 +- tools/buildman/func_test.py | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/buildman/builder.py b/tools/buildman/builder.py index 4bcde84adca..3cb14af279f 100644 --- a/tools/buildman/builder.py +++ b/tools/buildman/builder.py @@ -1624,7 +1624,7 @@ class Builder: config_minus[key] = value all_config_minus[key] = value for key, value in base.items(): - new_value = tconfig.config.get(key) + new_value = tconfig.config[name].get(key) if new_value and value != new_value: desc = f'{value} -> {new_value}' config_change[key] = desc diff --git a/tools/buildman/func_test.py b/tools/buildman/func_test.py index 817cd6e7a7f..b80779017b4 100644 --- a/tools/buildman/func_test.py +++ b/tools/buildman/func_test.py @@ -651,8 +651,10 @@ Some images are invalid''' self.assertEqual(self._make_calls, 0) lines = terminal.get_print_test_lines() text = '\n'.join(line.text for line in lines) - # Check config options appear in the output - self.assertIn('CONFIG_', text) + # Check config options appear in the output - both additions and + # value changes should be detected + self.assertIn('CONFIG_NEW_OPTION', text) # Addition + self.assertIn('CONFIG_VALUE', text) # Value change self.assertIn('(no errors to report)', lines[-1].text) def testCount(self):