diff mbox series

[Concept,25/29] buildman: Extract not-built display

Message ID 20260106220403.2915630-26-sjg@u-boot.org
State New
Headers
Series buildman: Clean up builder.py |

Commit Message

Simon Glass Jan. 6, 2026, 10:03 p.m. UTC 
  From: Simon Glass <simon.glass@canonical.com>

Move the not-built boards display into _show_not_built() to reduce
complexity in print_result_summary()

Co-developed-by: Claude <noreply@anthropic.com>
Signed-off-by: Simon Glass <simon.glass@canonical.com>
---

 tools/buildman/builder.py | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/tools/buildman/builder.py b/tools/buildman/builder.py
index d5b57246908..f8217124864 100644
--- a/tools/buildman/builder.py
+++ b/tools/buildman/builder.py
@@ -1877,10 +1877,19 @@  class Builder:
         self._base_config = config
         self._base_environment = environment
 
-        # Get a list of boards that did not get built, if needed
+        self._show_not_built(board_selected, board_dict)
+
+    @staticmethod
+    def _show_not_built(board_selected, board_dict):
+        """Show boards that were not built
+
+        Args:
+            board_selected (dict): Dict of selected boards, keyed by target
+            board_dict (dict): Dict of boards that were built, keyed by target
+        """
         not_built = []
         for brd in board_selected:
-            if not brd in board_dict:
+            if brd not in board_dict:
                 not_built.append(brd)
         if not_built:
             tprint(f"Boards not built ({len(not_built)}): "