From patchwork Tue Jan 6 22:03:31 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1316 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767737121; bh=0DzimnQA9JoEOUvUdSIRgdBXZmcVBRSZtv7cTwxf2wo=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=exed+z51ujzx9oMAa5jt/1xvMlU440wqQ9Vi7CS9mAnDCOFFCBrqDngfhXUd5nMCF gCgpKmu6gl6zeJ8LIjmWhWrfBwopzPQ987wFrMjIcdZIsaH4AppReoe5q3lOUWo286 S7tRMX74L7n7I19owUEjq0zjKSfaYU5M/MXep+YcvW9eNcei0ClNsXVyNx5RgPiKZ5 kF695dLTk1jokGNGmhQX+/UaPdCYCWO0XvdQTrcXzk1+5RQ3OzwrILylBQkD3yrSDx 4QiAFTbT/FZHrQaF5L5ULLs7oYj4KM56vf+2AVhZPRBfLlOmNrDOa+uN4QJX9n2fhx X/O3wOWzR4Fiw== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 69D7469161 for ; Tue, 6 Jan 2026 15:05:21 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 2ANTHqzhsYll for ; Tue, 6 Jan 2026 15:05:21 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767737121; bh=0DzimnQA9JoEOUvUdSIRgdBXZmcVBRSZtv7cTwxf2wo=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=exed+z51ujzx9oMAa5jt/1xvMlU440wqQ9Vi7CS9mAnDCOFFCBrqDngfhXUd5nMCF gCgpKmu6gl6zeJ8LIjmWhWrfBwopzPQ987wFrMjIcdZIsaH4AppReoe5q3lOUWo286 S7tRMX74L7n7I19owUEjq0zjKSfaYU5M/MXep+YcvW9eNcei0ClNsXVyNx5RgPiKZ5 kF695dLTk1jokGNGmhQX+/UaPdCYCWO0XvdQTrcXzk1+5RQ3OzwrILylBQkD3yrSDx 4QiAFTbT/FZHrQaF5L5ULLs7oYj4KM56vf+2AVhZPRBfLlOmNrDOa+uN4QJX9n2fhx X/O3wOWzR4Fiw== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 533AB69146 for ; Tue, 6 Jan 2026 15:05:21 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767737119; bh=ZXWj4f57TPmEntEoHXT3VhKD61JzQx3Ia4yugrBD7i0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TMPGMkYY9kaki2EZgrcf7OR7CwwXg8i4MAvbV4EA9iNLYizS4e5EwHLAh0FHbbUTr imARs1XlO3sUC3ok6SALhEWAiHviwA9DuD8qnFKP0Dp7b+xeno/7DBhFcLNITy/OhV QmQ/cI031hspEVG96jeasHwVH98xsPXFpKR7hpKQ9sj14mqdSpXGwaZhUSNrjJauVE 8wqJFMfIOzO7tx4xstpMKflUd1zyfaoCQ0C2h0b1JGHW7ZlX4SbNzTd0GRxdZj2kP2 coTCGEnqXYbfIr95jacAwJhkRSRy+05/2k4LJlJbaiW2WVxe3duysAy/IcvlHgQHcv yrgxrqe3IOKLw== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 5342B5FF82; Tue, 6 Jan 2026 15:05:19 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id Px-fTdtAeCDn; Tue, 6 Jan 2026 15:05:19 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767737115; bh=FmAgnt7yiOJIVkFFHOL++4mn4n0QrYyIPEuZkOWqDg4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pHMCMlaHNBxZv2DvHdzpfl1ToGH6a04i13eskUVJ2CfX1G662iI7H2ptcZ0l6jWgQ GR3/qHFMDowLQiVti0yzWA9aaiC+4gOMLh2PSnLMVrrZ2e0R2vBmfaNSm+hWCv3U2G 4WU+kg8B0iwLQuopsOMncWIkDzhdeLpIWdWk4rAESiLiijJUk41olkkxLy3+wRRdX8 xTemYpnxJYHCWkQUDcceNehsC1cfRx7OEU0bZTw1lU/5OiBx9PrWh3S7kGBtKSvei/ Fwqcs11fHb4MpzYTMe3tBAn9JFo5SC+31PC/tVN2dUFOSoa8aOzTgqY3cIbpMVwAoa KfqrGyHkTQQ/A== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 1D774690CB; Tue, 6 Jan 2026 15:05:15 -0700 (MST) From: Simon Glass To: U-Boot Concept Date: Tue, 6 Jan 2026 15:03:31 -0700 Message-ID: <20260106220403.2915630-14-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260106220403.2915630-1-sjg@u-boot.org> References: <20260106220403.2915630-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: B3YBUIEV7Y5CPBMHVZEUC5PSFZUYMZZL X-Message-ID-Hash: B3YBUIEV7Y5CPBMHVZEUC5PSFZUYMZZL X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Glass , Claude X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 13/29] buildman: Fix line length and return-value pylint warnings List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass Wrap lines that exceed 80 columns and fix the inconsistent return statement in _get_output_space_removals() which returns a list on one path but None on another. Co-developed-by: Claude Signed-off-by: Simon Glass --- tools/buildman/builder.py | 35 ++++++++++++++++++++--------------- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/tools/buildman/builder.py b/tools/buildman/builder.py index 3fd7182cbb6..4526c476a97 100644 --- a/tools/buildman/builder.py +++ b/tools/buildman/builder.py @@ -232,8 +232,8 @@ class Builder: threading is not being used _terminated: Thread was terminated due to an error _restarting_config: True if 'Restart config' is detected in output - _ide: Produce output suitable for an Integrated Development Environment, - i.e. dont emit progress information and put errors/warnings on stderr + _ide: Produce output suitable for an Integrated Development Environment + i.e. don't emit progress information and put errors on stderr """ class Outcome: """Records a build outcome for a single make invocation @@ -394,9 +394,10 @@ class Builder: self._re_files = re.compile('In file included from.*') self._re_warning = re.compile(r'(.*):(\d*):(\d*): warning: .*') self._re_dtb_warning = re.compile('(.*): Warning .*') - self._re_note = re.compile(r'(.*):(\d*):(\d*): note: this is the location of the previous.*') - self._re_migration_warning = re.compile(r'^={21} WARNING ={22}\n.*\n=+\n', - re.MULTILINE | re.DOTALL) + self._re_note = re.compile( + r'(.*):(\d*):(\d*): note: this is the location of the previous.*') + self._re_migration_warning = re.compile( + r'^={21} WARNING ={22}\n.*\n=+\n', re.MULTILINE | re.DOTALL) self.thread_exceptions = [] self.test_thread_exceptions = test_thread_exceptions @@ -453,7 +454,8 @@ class Builder: self._single_builder = builderthread.BuilderThread( self, -1, mrproper, per_board_out_dir) - ignore_lines = ['(make.*Waiting for unfinished)', '(Segmentation fault)'] + ignore_lines = ['(make.*Waiting for unfinished)', + '(Segmentation fault)'] self.re_make_err = re.compile('|'.join(ignore_lines)) # Handle existing graceful with SIGINT / Ctrl-C @@ -595,7 +597,8 @@ class Builder: if self._terminated: # Try to be helpful - result.stderr += '(** did you define an int/hex Kconfig with no default? **)' + result.stderr += \ + '(** did you define an int/hex Kconfig with no default? **)' if self.verbose_build: result.stdout = f"{' '.join(cmd)}\n" + result.stdout @@ -1376,8 +1379,8 @@ class Builder: worse_lines = [] for line in lines: if line not in base_lines: - errline = ErrLine(char + '+', _board_list(line, line_boards), - line) + errline = ErrLine( + char + '+', _board_list(line, line_boards), line) worse_lines.append(errline) for line in base_lines: if line not in lines: @@ -1513,8 +1516,8 @@ class Builder: sys.stderr.write(line) # Display results by arch - elif any((ok_boards, warn_boards, err_boards, unknown_boards, new_boards, - worse_err, better_err, worse_warn, better_warn)): + elif any((ok_boards, warn_boards, err_boards, unknown_boards, + new_boards, worse_err, better_err, worse_warn, better_warn)): arch_list = {} self.add_outcome(board_selected, arch_list, ok_boards, '', self.col.GREEN) @@ -1522,7 +1525,8 @@ class Builder: self.col.YELLOW) self.add_outcome(board_selected, arch_list, err_boards, '+', self.col.RED) - self.add_outcome(board_selected, arch_list, new_boards, '*', self.col.BLUE) + self.add_outcome(board_selected, arch_list, new_boards, '*', + self.col.BLUE) if self._show_unknown: self.add_outcome(board_selected, arch_list, unknown_boards, '?', self.col.MAGENTA) @@ -1841,7 +1845,7 @@ class Builder: List of full paths of directories to remove """ if not self.commits: - return + return [] dir_list = [] for commit_upto in range(self.commit_count): dir_list.append(self.get_output_dir(commit_upto)) @@ -1944,12 +1948,13 @@ class Builder: if duration > timedelta(microseconds=1000000): if duration.microseconds >= 500000: duration = duration + timedelta(seconds=1) - duration = duration - timedelta(microseconds=duration.microseconds) + duration -= timedelta(microseconds=duration.microseconds) rate = float(self.count) / duration.total_seconds() msg += f', duration {duration}, rate {rate:1.2f}' tprint(msg) if self.thread_exceptions: - tprint(f'Failed: {len(self.thread_exceptions)} thread exceptions', + tprint( + f'Failed: {len(self.thread_exceptions)} thread exceptions', colour=self.col.RED) return (self.fail, self.warned, self.thread_exceptions)