From patchwork Tue Jan 6 22:03:30 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1315 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767737116; bh=aHgXSULMWa8jVQLpCbzPvDkYtx83U7cb5I9k6s7Y8gE=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=hgfNX+sDXhBQP2FEB9WvSuNGa4Os3qs3eBOq63WLEFyaIRt+QasdXvNbofrJqmoum 3GeE71A8YxLhchHyymnK6beig0T1eytADKL2VLHS39+qyRPW97NZ808U2tAWJDkDsK UMe4D0oBpDHza06lKPouCOM8xS9MTJ3khP4UEqcMPXKzfSPULabfV3QvWQhJY5JO5J lwE8NXlN+KsWBQ2iuOkg7rFhbo8webfrDRIyANADGgRgWJlsCbj3jLbqzKscm4tujn P1ZdcuhatUTJgwbQyOoL/h7yY4JAcB9X48DLzOecJMqNn4xCN+wcKSHLxHBPykFZp8 rRDM9RDMC8OxQ== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id E115B69161 for ; Tue, 6 Jan 2026 15:05:16 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id kcg-YQVCMdsQ for ; Tue, 6 Jan 2026 15:05:16 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767737116; bh=aHgXSULMWa8jVQLpCbzPvDkYtx83U7cb5I9k6s7Y8gE=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=hgfNX+sDXhBQP2FEB9WvSuNGa4Os3qs3eBOq63WLEFyaIRt+QasdXvNbofrJqmoum 3GeE71A8YxLhchHyymnK6beig0T1eytADKL2VLHS39+qyRPW97NZ808U2tAWJDkDsK UMe4D0oBpDHza06lKPouCOM8xS9MTJ3khP4UEqcMPXKzfSPULabfV3QvWQhJY5JO5J lwE8NXlN+KsWBQ2iuOkg7rFhbo8webfrDRIyANADGgRgWJlsCbj3jLbqzKscm4tujn P1ZdcuhatUTJgwbQyOoL/h7yY4JAcB9X48DLzOecJMqNn4xCN+wcKSHLxHBPykFZp8 rRDM9RDMC8OxQ== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id CFEC669146 for ; Tue, 6 Jan 2026 15:05:16 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767737114; bh=nmxVn32gNhx1a/aKiUxQjMI3fLDJYpi42JMz4j1dvW0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KSB8ykkvPEmCrBMdtkqrimSRl0iNR2+7QNx/IpErmnEHiju00blYs1fDMmQC6V+R9 uedaqDnUnkByAn3w7en1WcFGvnup9xBQNdbbfsE6uegUaZBWCUsvmRxU2rjhJqqWtx /tyeFpAorASkIMljHJN5z9CERIRjj3Nlkh0g+6rYeu4fd5OGuOejVihc816CbA9AdI 4Rr6/5FoPyzUkFp55wMQT5uhReew6glFtm3nuHQUNgzhJAV5c0eiYfjXzMMqSCxF0h 8hUl0kHCvjGaxxq3nov9YWhD22+d+DWhnIY6N3Y4uH6dPSB3POm4C4RioIoI+HnK46 4WRocSVgT+MqA== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id D20005FF82; Tue, 6 Jan 2026 15:05:14 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id OwWIH3rYyJuj; Tue, 6 Jan 2026 15:05:14 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767737110; bh=wX1rXMsedXCF6gsVKgy/siFqIQZNgcDkwSKgDoJpY/E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I1Cd/ZQ9vICg1C43YofwEKknCDEqW8YW58JuwHz74xtEKCtfRY8hSYQ+kPiTl/OrK SAK+uG8aGvcNvfd9hvyr9gMdkxLSqprbidsypF2T7XFKPJyYWqeN65A38r02Wtnc3b GRpuqtq4KfkF2Niv9UJ58Ol+3eWQH8UfX8Do2ISzr4W/iGGc+HSMOoN9aPHW/4vc4b 6BaivCddTbCompSDx3yvZnE+IUxq+OR4QylHmuL0imrD+0WiR2969gVcQu3RHa4Sv0 2DbiWsLgLJrOk6Jjy/n7MGjhndTZp+lQEzmU64uW6ypVRWKz8HshDZFiTFHtmHwLMV cQM4qf/Ui9rGg== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id A1E11690CB; Tue, 6 Jan 2026 15:05:10 -0700 (MST) From: Simon Glass To: U-Boot Concept Date: Tue, 6 Jan 2026 15:03:30 -0700 Message-ID: <20260106220403.2915630-13-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260106220403.2915630-1-sjg@u-boot.org> References: <20260106220403.2915630-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: ZSSYTJV2GWUCHXQ6PDDFS33WROCRGWUK X-Message-ID-Hash: ZSSYTJV2GWUCHXQ6PDDFS33WROCRGWUK X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Glass , Claude X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 12/29] buildman: Mark unused function arguments in builder.py List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass Prefix unused function arguments with underscore to indicate they are intentionally unused. These are typically required by interfaces (signal handlers, callbacks) but not used in the implementation. This fixes pylint W0613 (unused-argument) warnings. Remove parameter documentation for these underscore-prefixed unused arguments as pylint considers documenting them useless (W9019/W9020). Co-developed-by: Claude Signed-off-by: Simon Glass --- tools/buildman/builder.py | 23 ++++++----------------- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/tools/buildman/builder.py b/tools/buildman/builder.py index 195fbe40324..3fd7182cbb6 100644 --- a/tools/buildman/builder.py +++ b/tools/buildman/builder.py @@ -463,13 +463,8 @@ class Builder: """Get rid of all threads created by the builder""" self.threads.clear() - def signal_handler(self, signum, frame): - """Handle a signal by exiting - - Args: - signum (int): Signal number - frame (frame): Stack frame at point of signal - """ + def signal_handler(self, _signum, _frame): + """Handle a signal by exiting""" sys.exit(1) def make_environment(self, toolchain): @@ -564,20 +559,16 @@ class Builder: if checkout and self.checkout: gitutil.checkout(commit.hash) - def make(self, commit, brd, stage, cwd, *args, **kwargs): + def make(self, _commit, _brd, _stage, cwd, *args, **kwargs): """Run make Args: - commit (Commit): Commit object that is being built - brd (Board): Board object that is being built - stage (str): Stage that we are at (mrproper, config, oldconfig, - build) cwd (str): Directory where make should be run args: Arguments to pass to make kwargs: Arguments to pass to command.run_one() """ - def check_output(stream, data): + def check_output(_stream, data): if b'Restart config' in data: self._restarting_config = True @@ -779,11 +770,10 @@ class Builder: out_lines.append(line) return out_lines - def read_func_sizes(self, fname, fd): + def read_func_sizes(self, _fname, fd): """Read function sizes from the output of 'nm' Args: - fname (str): Filename we are reading from (just for errors) fd (file): File containing data to read Returns: @@ -1739,12 +1729,11 @@ class Builder: tprint('(no errors to report)', colour=self.col.GREEN) - def setup_build(self, board_selected, commits): + def setup_build(self, board_selected, _commits): """Set up ready to start a build. Args: board_selected (dict): Selected boards to build - commits (list): Selected commits to build """ # First work out how many commits we will build count = (self.commit_count + self._step - 1) // self._step