From patchwork Tue Jan 6 22:03:28 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1313 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767737107; bh=fKtyDfoFNpsie52G9LJ3+YWEMR4oAQiP3nNQS4T+YO0=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=mD2sL3wqPAHhAn68mPn/5dEYOr0A/isJlNGzKgV51Gy5GDjNn4UkBeAfEXR8dMjDa fCy1rcXdV+SJ/E1v6tuwARK6t/2mTNCD+khOjzGOO6IqPHf/zLW9p9EOJRL4unnpLV QW3PzFqAoYyqOSRg3bteusBmz4WcK+jSbW7Ak/xYz97xgtOi26EmTsK17ghCeeytci dbUNhM9/0EpLobtw7rw96BkTRcMwIHwK4W9MNBH0Iq6anRiAcvCCqATjBYNOeqdAER kB9kJ64gALbDkaa4ofCeSgjPBAe1D5mjEkQ7zZY4/frWNbZiVBFEf0gYYbzWXRUsjW nsglIWPBN2RDw== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 8CEAB5FF82 for ; Tue, 6 Jan 2026 15:05:07 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 1moacIY8AZ3o for ; Tue, 6 Jan 2026 15:05:07 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767737107; bh=fKtyDfoFNpsie52G9LJ3+YWEMR4oAQiP3nNQS4T+YO0=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=mD2sL3wqPAHhAn68mPn/5dEYOr0A/isJlNGzKgV51Gy5GDjNn4UkBeAfEXR8dMjDa fCy1rcXdV+SJ/E1v6tuwARK6t/2mTNCD+khOjzGOO6IqPHf/zLW9p9EOJRL4unnpLV QW3PzFqAoYyqOSRg3bteusBmz4WcK+jSbW7Ak/xYz97xgtOi26EmTsK17ghCeeytci dbUNhM9/0EpLobtw7rw96BkTRcMwIHwK4W9MNBH0Iq6anRiAcvCCqATjBYNOeqdAER kB9kJ64gALbDkaa4ofCeSgjPBAe1D5mjEkQ7zZY4/frWNbZiVBFEf0gYYbzWXRUsjW nsglIWPBN2RDw== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 7C04969146 for ; Tue, 6 Jan 2026 15:05:07 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767737105; bh=LHO7IjWb8UjOg5Ewb2E4cMiwvrRrGSfOT1Z0L33Xvg8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QAs128qF0/fy9s6vrACGdbu2Xx2CxcjqtpIPhs3LE8f29gfFIcenERgHKYnTpWGhG w9ON+u0csx+2HezE8VNIJjsZFq2PHeiIY87HMmfyYDymX5lfdZgctJQaSO/f7WWh7T TvMbnqsZqijKGPfY0+I4KDiXgiUc1shg5JBoXYQ0DeWcYBBK5VLCxMjg8nTwz/6hCv heuX39pzsSrSzlnkjklX6+5uuuXSqRUdct4iz+shfblelUYdbSQQff/DvAAkYAz3lh aSrc32CeWekw+wnWjwscGteKSbrBf0yoi8kGxFKt4u3xRZwblWa+v7yzpsBAfQqRhz L67JPVL4TNSOQ== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 9934C5FF82; Tue, 6 Jan 2026 15:05:05 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id epKerl2wq3Q3; Tue, 6 Jan 2026 15:05:05 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767737101; bh=GWSRP6HcVq5/jp0wzW8kO65dc3BL1QI0SPSUe4ZAcM4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sQWa7TrSxkdbNym3cHkFSQz96G3Zfz2RbehoP0u2YGTP3Zk9RuRbw68cFPSItH6Q1 jrtdtXkC0THHUyJzWKd9v4A2Fqp4/2Eif7ZDPBIHlXvtRii/3FDlYRXPzECdw8Elvn 35F1UgLSXYlEXaIbLfq2ZyCMP1ohUHHctbYqxHjlvpeuw68Tu9UgtfHHHdxTW6gseK sIDBuMXSXTJMRWRcNHd7zxNHcsM8XJuIpjoGMxyzLpYgq72xgjBxfGq//FYkUlKl4O KlinEglI9jXk/6LJdoczqfcHs6WHD4DFcWxu/TKH0QBcZG/4lIB9FgdauHmdHVuvsu a3aCYlorGBdQA== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 2A0C9690CB; Tue, 6 Jan 2026 15:05:01 -0700 (MST) From: Simon Glass To: U-Boot Concept Date: Tue, 6 Jan 2026 15:03:28 -0700 Message-ID: <20260106220403.2915630-11-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260106220403.2915630-1-sjg@u-boot.org> References: <20260106220403.2915630-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: FBE6FX5RBS4Y4AJIP42FPOZOBSRS6JG7 X-Message-ID-Hash: FBE6FX5RBS4Y4AJIP42FPOZOBSRS6JG7 X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Glass , Claude X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 10/29] buildman: Initialise all attributes in Builder.__init__() List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass Add initialisation for all instance attributes in __init__() to fix pylint W0201 (attribute-defined-outside-init) warnings. These attributes were previously only set in other methods like set_display_options(), reset_result_summary(), setup_build() and build_boards(). Co-developed-by: Claude Signed-off-by: Simon Glass --- tools/buildman/builder.py | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/tools/buildman/builder.py b/tools/buildman/builder.py index 25e802a104c..b3f979e91dd 100644 --- a/tools/buildman/builder.py +++ b/tools/buildman/builder.py @@ -402,6 +402,39 @@ class Builder: self.thread_exceptions = [] self.test_thread_exceptions = test_thread_exceptions + + # Attributes used by set_display_options() + self._show_errors = False + self._show_sizes = False + self._show_detail = False + self._show_bloat = False + self._list_error_boards = False + self._show_config = False + self._show_environment = False + self._filter_dtb_warnings = False + self._filter_migration_warnings = False + + # Attributes set by other methods + self._build_period = None + self.commit = None + self.upto = 0 + self.warned = 0 + self.fail = 0 + self.commit_count = 0 + self.commits = None + self.count = 0 + self._timestamps = None + self._verbose = False + + # Attributes for result summaries + self._base_board_dict = {} + self._base_err_lines = [] + self._base_warn_lines = [] + self._base_err_line_boards = {} + self._base_warn_line_boards = {} + self._base_config = None + self._base_environment = None + if self.num_threads: self._single_builder = None self.queue = queue.Queue()