diff mbox series

[Concept,08/22] buildman: Use tools.write_file() in test.py

Message ID	20260106142834.2511220-9-sjg@u-boot.org
State	New
Headers	From: Simon Glass <sjg@u-boot.org> To: U-Boot Concept <concept@u-boot.org> Date: Tue, 6 Jan 2026 07:28:13 -0700 Message-ID: <20260106142834.2511220-9-sjg@u-boot.org> In-Reply-To: <20260106142834.2511220-1-sjg@u-boot.org> References: <20260106142834.2511220-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: HNYR5JC2CH6ZWTRTMSQCEJMXXWRAV626 CC: Simon Glass <simon.glass@canonical.com>, Claude <noreply@anthropic.com> Precedence: list Subject: [Concept] [PATCH 08/22] buildman: Use tools.write_file() in test.py Archived-At: <https://lists.u-boot.org/archives/list/concept@u-boot.org/message/HNYR5JC2CH6ZWTRTMSQCEJMXXWRAV626/> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit
Series	buildman: Clean up test.py for pylint compliance \| [Concept,00/22] buildman: Clean up test.py for pylint compliance [Concept,01/22] buildman: Fix indentation and semicolon in test.py [Concept,02/22] buildman: Add __init__() to Options class in test.py [Concept,03/22] buildman: Convert to f-strings in test.py [Concept,04/22] buildman: Fix import order in test.py [Concept,05/22] buildman: Convert CamelCase to snake_case in test.py [Concept,06/22] buildman: Add missing docstrings in test.py [Concept,07/22] buildman: Fix singleton comparisons in test.py [Concept,08/22] buildman: Use tools.write_file() in test.py [Concept,09/22] buildman: Use set comprehension in test.py [Concept,10/22] buildman: Fix docstring in add_line_prefix() [Concept,11/22] buildman: Remove unused variables in test.py [Concept,12/22] buildman: Fix implicit string concatenation in test.py [Concept,13/22] buildman: Mark unused arguments in test.py [Concept,14/22] buildman: Disable protected-access warning in test.py [Concept,15/22] buildman: Rename commit parameter to avoid shadowing in test.py [Concept,16/22] buildman: Rename constants to UPPER_CASE in test.py [Concept,17/22] buildman: Shorten long lines in test.py [Concept,18/22] buildman: Disable pylint warnings for Options in test.py [Concept,19/22] buildman: Split TestBuild into multiple classes in test.py [Concept,20/22] buildman: Refactor _check_output() in test.py [Concept,21/22] buildman: Split test_process_limit() into two tests in test.py [Concept,22/22] buildman: Disable some final pylint warnings in test.py

Commit Message

Simon Glass Jan. 6, 2026, 2:28 p.m. UTC

  From: Simon Glass <simon.glass@canonical.com>

Replace open() calls with tools.write_file() for consistency and to
fix pylint W1514 (unspecified-encoding) warnings.

Co-developed-by: Claude <noreply@anthropic.com>
Signed-off-by: Simon Glass <simon.glass@canonical.com>
---

 tools/buildman/test.py | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff mbox series

Patch

diff --git a/tools/buildman/test.py b/tools/buildman/test.py
index 430e9ee118c..8b015e22090 100644
--- a/tools/buildman/test.py
+++ b/tools/buildman/test.py
@@ -1128,8 +1128,7 @@  class TestBuild(unittest.TestCase):
         with tempfile.TemporaryDirectory() as tmpdir:
             # Create a reference file
             ref_file = os.path.join(tmpdir, 'done')
-            with open(ref_file, 'w') as f:
-                f.write('0\n')
+            tools.write_file(ref_file, b'0\n')
 
             # Test with no Kconfig files - should return False
             self.assertFalse(
@@ -1140,8 +1139,7 @@  class TestBuild(unittest.TestCase):
 
             # Create a Kconfig file newer than the reference
             kconfig = os.path.join(tmpdir, 'Kconfig')
-            with open(kconfig, 'w') as f:
-                f.write('config TEST\n')
+            tools.write_file(kconfig, b'config TEST\n')
 
             # Should now return True since Kconfig is newer
             self.assertTrue(
@@ -1149,8 +1147,7 @@  class TestBuild(unittest.TestCase):
 
             # Create a new reference file (newer than Kconfig)
             time.sleep(0.1)
-            with open(ref_file, 'w') as f:
-                f.write('0\n')
+            tools.write_file(ref_file, b'0\n')
 
             # Should now return False since reference is newer
             self.assertFalse(
@@ -1165,8 +1162,8 @@  class TestBuild(unittest.TestCase):
             subdir = os.path.join(tmpdir, 'sub')
             os.makedirs(subdir)
             time.sleep(0.1)
-            with open(os.path.join(subdir, 'Kconfig.sub'), 'w') as f:
-                f.write('config SUBTEST\n')
+            tools.write_file(os.path.join(subdir, 'Kconfig.sub'),
+                             b'config SUBTEST\n')
 
             # Should return True due to newer Kconfig.sub in subdir
             self.assertTrue(
@@ -1174,8 +1171,7 @@  class TestBuild(unittest.TestCase):
 
             # Create a new reference file (newer than all Kconfig files)
             time.sleep(0.1)
-            with open(ref_file, 'w') as f:
-                f.write('0\n')
+            tools.write_file(ref_file, b'0\n')
 
             # Should now return False
             self.assertFalse(
@@ -1185,8 +1181,8 @@  class TestBuild(unittest.TestCase):
             configs_dir = os.path.join(tmpdir, 'configs')
             os.makedirs(configs_dir)
             time.sleep(0.1)
-            with open(os.path.join(configs_dir, 'sandbox_defconfig'), 'w') as f:
-                f.write('CONFIG_SANDBOX=y\n')
+            tools.write_file(os.path.join(configs_dir, 'sandbox_defconfig'),
+                             b'CONFIG_SANDBOX=y\n')
 
             # Without target, defconfig is not checked
             self.assertFalse(