From patchwork Tue Jan 6 14:28:12 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1288 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767709757; bh=P5dKRpp0FRxQwC6mZ66ghDfe7sXVTvq+C0xqfTWCOVU=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=F1zlg22H3QtFgpGT3liGWDdi3JYaSFUiUo8oXWgLLJT5pEg001TTjt11OTafdKt65 FZpc6Kr6yneMngqDnqppoEcBgNYOveQ8AhHZ1VZ/EdTGv3cmylOPiQ8KYFFEyqYJM4 CaZJmvpHK7r1x3u5TSafnYkFWgG9FodlHEVpVxwQ4vltoRCT0jDnoIiPJN38s5AOlU +OG3EWhyLI+4h2B211RkvVd0cEm7J5peOnzGZrixDHb6TWquQ7nlxkYFAgJz4zA3el mHy0m4UHcuRkOlo7c5CTbwWWTVOdrUmpCmdmmUvGWsIJOJaECyKHZpcf+uOinrtSey SvLDotmm8CCTw== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id ED75169054 for ; Tue, 6 Jan 2026 07:29:17 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 1UZzcdEeMdYr for ; Tue, 6 Jan 2026 07:29:17 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767709757; bh=P5dKRpp0FRxQwC6mZ66ghDfe7sXVTvq+C0xqfTWCOVU=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=F1zlg22H3QtFgpGT3liGWDdi3JYaSFUiUo8oXWgLLJT5pEg001TTjt11OTafdKt65 FZpc6Kr6yneMngqDnqppoEcBgNYOveQ8AhHZ1VZ/EdTGv3cmylOPiQ8KYFFEyqYJM4 CaZJmvpHK7r1x3u5TSafnYkFWgG9FodlHEVpVxwQ4vltoRCT0jDnoIiPJN38s5AOlU +OG3EWhyLI+4h2B211RkvVd0cEm7J5peOnzGZrixDHb6TWquQ7nlxkYFAgJz4zA3el mHy0m4UHcuRkOlo7c5CTbwWWTVOdrUmpCmdmmUvGWsIJOJaECyKHZpcf+uOinrtSey SvLDotmm8CCTw== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id DB25469121 for ; Tue, 6 Jan 2026 07:29:17 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767709756; bh=6mlyXbybEsCc+jP6+8Sbpj6cDuaqeGScx5a/SeWfG6g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cP3MFHo9mTCxEOR75NXzN3FxUPM+hxV+Upb7nmIIZ/CIKuhFK66aHFlfKglSAAV2e 1pKCUl3y5AHnkgFyvpYNrg1V9ZVL4YhzYTRm9YcMyMhope3bWuYHPj9Dvsg94M8f20 RDDpITUwxXr4UFCWU/F7+adSmgjoyShxKzNWiOOWYRXzfyHn1tjQ+OCAVG8sNYFqjm GsxT9mGBHX8wyBURqWks+4BwPt2ESATGpQDsmr+otacronC3WFRNEQXAygP6v31TMk FE4LpfDCzZScxPGpHwVM6yeOq81gK7eOr4H9QVqwUjZ+hNOxBfc0DPTzbqeA1VwaB6 afHjwDZgP6REQ== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 66CD369054; Tue, 6 Jan 2026 07:29:16 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id 6iouVmMdD51x; Tue, 6 Jan 2026 07:29:16 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767709752; bh=X73BRZKgrxlkiAewoTPupuFYl24F/u2/xU7lFbeLyms=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hLAB5B5uPrN4Ql9a++cLXkzjuQVtE9qLUdVdVXGMAJqRg25oMld5IMOlS3RzKGRCS jTHvgb6gWPnPJVgWH5UWv+QY9PxZUDZ1L146/qwdho8WXwwVQJxAhQgBNTsa8O+smy ayER0J8hJTqzUrRtYmswwcbJkxAPaEest2CSDm/nOHXr7ztfCfM8YxU4Q9GouVUaQC 4fyDGr0T2TwlZAbBFmfhDPbxwa74lPvUv07jN5qGxYMLtSXSJ3Q8NkHEFfpxulTKUU YXfnC3G951sWu4FByF0NFvjdPSR75esE9LfUnNafEK17ebDrkrdzbFtm2spO7p7gCw cCOne/N95IBNA== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id F149069118; Tue, 6 Jan 2026 07:29:11 -0700 (MST) From: Simon Glass To: U-Boot Concept Date: Tue, 6 Jan 2026 07:28:12 -0700 Message-ID: <20260106142834.2511220-8-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260106142834.2511220-1-sjg@u-boot.org> References: <20260106142834.2511220-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: WWPEY6DE4BO75F6Q76QTEZLTTHALRSYE X-Message-ID-Hash: WWPEY6DE4BO75F6Q76QTEZLTTHALRSYE X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Glass , Claude X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 07/22] buildman: Fix singleton comparisons in test.py List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass Use 'is not None' instead of '!= None' for proper singleton comparison. Co-developed-by: Claude Signed-off-by: Simon Glass --- tools/buildman/test.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/buildman/test.py b/tools/buildman/test.py index 70dcf082755..430e9ee118c 100644 --- a/tools/buildman/test.py +++ b/tools/buildman/test.py @@ -616,7 +616,7 @@ class TestBuild(unittest.TestCase): def test_toolchain_aliases(self): """Test that toolchain aliases are handled correctly""" - self.assertTrue(self.toolchains.select('arm') != None) + self.assertTrue(self.toolchains.select('arm') is not None) with self.assertRaises(ValueError): self.toolchains.select('no-arch') with self.assertRaises(ValueError): @@ -624,11 +624,11 @@ class TestBuild(unittest.TestCase): self.toolchains = toolchain.Toolchains() self.toolchains.add('x86_64-linux-gcc', test=False) - self.assertTrue(self.toolchains.select('x86') != None) + self.assertTrue(self.toolchains.select('x86') is not None) self.toolchains = toolchain.Toolchains() self.toolchains.add('i386-linux-gcc', test=False) - self.assertTrue(self.toolchains.select('x86') != None) + self.assertTrue(self.toolchains.select('x86') is not None) def test_toolchain_download(self): """Test that we can download toolchains"""