From patchwork Tue Jan 6 14:28:20 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1296 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767709791; bh=QR1Cwpw6zh8POPrmWYS7Fw1DhihH7qLJDou+DJFw4Go=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=KLQsvHFhktYM+nqqXBtr939DguqwYBQ5gjEqBarFM+EWXpryItrAHkW9MqHXwLnWP y0m/SBgcDMD8MDG3iXpXy7Vo7TnKhw3k5xBtdXZw+EgVXQQuOEUCaArQQjpirmrMi+ W9OM37HZHMIftxBOiiJvvoRwhqaKoKgAJJhqOGlbxiGzz7wsTJXmV/r1kPTR0g2rMA IqdplWfW/e9ZIf382wcKSGTGPYiX2tb4KnYOD19cdU//NTPjVi+RdORCX29uISqCOc SsPRxDT1YFGb8aB1HuC6zID0YqGg3i5GKqKte5IxJzFyMjSBFFcAqut6Bgm5s/J6rw OHIrMilbzmklg== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 9287469142 for ; Tue, 6 Jan 2026 07:29:51 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Me7yQpFZODQR for ; Tue, 6 Jan 2026 07:29:51 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767709791; bh=QR1Cwpw6zh8POPrmWYS7Fw1DhihH7qLJDou+DJFw4Go=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=KLQsvHFhktYM+nqqXBtr939DguqwYBQ5gjEqBarFM+EWXpryItrAHkW9MqHXwLnWP y0m/SBgcDMD8MDG3iXpXy7Vo7TnKhw3k5xBtdXZw+EgVXQQuOEUCaArQQjpirmrMi+ W9OM37HZHMIftxBOiiJvvoRwhqaKoKgAJJhqOGlbxiGzz7wsTJXmV/r1kPTR0g2rMA IqdplWfW/e9ZIf382wcKSGTGPYiX2tb4KnYOD19cdU//NTPjVi+RdORCX29uISqCOc SsPRxDT1YFGb8aB1HuC6zID0YqGg3i5GKqKte5IxJzFyMjSBFFcAqut6Bgm5s/J6rw OHIrMilbzmklg== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 8068569122 for ; Tue, 6 Jan 2026 07:29:51 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767709789; bh=ImtCaDiyN93FqNkqIDfSCJ3zxbvuaRu99tDrHDbExGw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IXQz/3VhKK9uYTC9Hptx8DdP2Ix1fW68V+6B2Vel3lRaY64vUynmePEzHzgkcpMkZ MsRcnzPz3mFysKY+QANX+X1Lc1oniR+uDN0vshUw4+hSfwHIibgPjULLDxmu/hu+OF fjzYNseXFGHxAgru5oPYB+8nD1VN4A9HPkItxPAZfp0MhTWkLFJvVNaBO1SxKEJ19j WgHKgxlC7Rbo57pBY4h04pwoEI/+eog/ZgFcq4etFF1P3pL2ohaQUKJ4pB270Ex24M nwQw9V6rS1MFi7Coh8krmQnaWnSVHkof8hCQj7KvnCq42KPjYmmlg6i6bHcAPxdUj+ UCiBK4vSOBEHQ== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 56B2569083; Tue, 6 Jan 2026 07:29:49 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id rrs5GCOeVJDI; Tue, 6 Jan 2026 07:29:49 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767709784; bh=u9eBEOW6QB+nYIe3p49VehyemF15IzDC5GRdZMU5NcQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DvRIDOnlNlR7Wvl9RxpH5orZVekdyoAmspW2pKzvY7CIOByupdvjvdT8j+cJrzcuq N2r38qt67ZjordW1hlESxFr3EpBTiFw5HBZrKius2o12yofjDTPRpolDe4ucuPX0qk tQovZ2VVO2nnxJ1BexYpxCxwwzejHKQK7OfQcIpvj9xs0QoTXIBhJ/YtxqB97zLxNA rKSeYrme8FSADZV0NOM/ZR2DufFCeoWZPiLBcGYKdUB1RrRcPzyf5xcZ0UvSUt7zyi dGbQ0iEm7L3HlD00JzolLrnzQlkqAO0RIIxnyN0XH7WGPjLHJ6brWknYvbkOslLi3v UGL1gGUMEOs9w== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id A4EE869054; Tue, 6 Jan 2026 07:29:44 -0700 (MST) From: Simon Glass To: U-Boot Concept Date: Tue, 6 Jan 2026 07:28:20 -0700 Message-ID: <20260106142834.2511220-16-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260106142834.2511220-1-sjg@u-boot.org> References: <20260106142834.2511220-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: VNLGJ4KJVDW27QUED55XR3BBRZUQG6C5 X-Message-ID-Hash: VNLGJ4KJVDW27QUED55XR3BBRZUQG6C5 X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Glass , Claude X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 15/22] buildman: Rename commit parameter to avoid shadowing in test.py List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass Rename 'commit' parameter to 'cmt' in make() to avoid shadowing the 'commit' module import, fixing pylint W0621 warning. Co-developed-by: Claude Signed-off-by: Simon Glass --- tools/buildman/test.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/buildman/test.py b/tools/buildman/test.py index 0b6469517cc..361d65ccf81 100644 --- a/tools/buildman/test.py +++ b/tools/buildman/test.py @@ -204,20 +204,20 @@ class TestBuild(unittest.TestCase): def tearDown(self): shutil.rmtree(self.base_dir) - def make(self, commit, brd, _stage, *_args, **_kwargs): + def make(self, cmt, brd, _stage, *_args, **_kwargs): """Mock make function for testing build output""" result = command.CommandResult() boardnum = int(brd.target[-1]) result.return_code = 0 result.stderr = '' result.stdout = (f'This is the test output for board {brd.target}, ' - f'commit {commit.hash}') - if ((boardnum >= 1 and boardnum >= commit.sequence) or - boardnum == 4 and commit.sequence == 6): - result.return_code = commit.return_code - result.stderr = (''.join(commit.error_list) + f'commit {cmt.hash}') + if ((boardnum >= 1 and boardnum >= cmt.sequence) or + boardnum == 4 and cmt.sequence == 6): + result.return_code = cmt.return_code + result.stderr = (''.join(cmt.error_list) % {'basedir' : self.base_dir + '/.bm-work/00/'}) - elif commit.sequence < 6: + elif cmt.sequence < 6: result.stderr = migration result.combined = result.stdout + result.stderr