From patchwork Tue Jan 6 14:28:15 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1291 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767709771; bh=/JTBzBdSOmGNIHL03MAkkypQmURwsowgeX9kNSubIyA=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=eEQ4yxf4EFvuAZ4lldPSSyPu4M8+Amj8antoGw6+QcDtG9zI6M/+VLws9+srb7tIi vVEVZjUjAQ/J9kDaMS4r0vTyEv3NOmf19OIe8Q+mC2X4BHlGtx9+gmJLEMTQgHLk9S QOz865kgNfqHlbNnfD+gNRckvZ7hSmfcCpJRjh/kLcG802mUrJUBnRg998gtv+EbDg kQ8mgKx1VuwJ3HYlrSE96f6Yl4gCLXZu6mRj8fVSt1k8C6eFzTHotqB2KkKrOCJ55t MDAanCEgdonEhGYZHlxOgQOyB11q/eCoSCQUEcTuhrw+qHEL0+h1lgMmv/D1MxIKbI 2SY8iXf3Jt13A== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 818576912C for ; Tue, 6 Jan 2026 07:29:31 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Y7UyB7UYe4_g for ; Tue, 6 Jan 2026 07:29:31 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767709771; bh=/JTBzBdSOmGNIHL03MAkkypQmURwsowgeX9kNSubIyA=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=eEQ4yxf4EFvuAZ4lldPSSyPu4M8+Amj8antoGw6+QcDtG9zI6M/+VLws9+srb7tIi vVEVZjUjAQ/J9kDaMS4r0vTyEv3NOmf19OIe8Q+mC2X4BHlGtx9+gmJLEMTQgHLk9S QOz865kgNfqHlbNnfD+gNRckvZ7hSmfcCpJRjh/kLcG802mUrJUBnRg998gtv+EbDg kQ8mgKx1VuwJ3HYlrSE96f6Yl4gCLXZu6mRj8fVSt1k8C6eFzTHotqB2KkKrOCJ55t MDAanCEgdonEhGYZHlxOgQOyB11q/eCoSCQUEcTuhrw+qHEL0+h1lgMmv/D1MxIKbI 2SY8iXf3Jt13A== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 6E6E269118 for ; Tue, 6 Jan 2026 07:29:31 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767709769; bh=fPjAXDLQ8/Xk6q8zsch4Q0JGGUJDZ4bqktINDLNBzBI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A2OxmttvTFhhCaAEsk5vWQVyPkvzhD8LdckUO/EAwghKlHa+ihbcnpBUC5/WbZ1lD JGTUmD/oElK3hNl0Fgx+cIEM/lGu1Z+NrJxALwKCf4gDy8Fcut6HvoR7TE9TDCGvE2 r/f+esMWuU/1I3/zU+JtK1/luP4NdTpWeV7SwvCTDO86M4OXgNKXyXYljCOSQAa9eV +gpOWTwbEeCHxXqcmcC9peyNe+lJlGwnxqEXWK0suBMouvEHBBWYkCgNoD3lfBdmon RO01MoDqeCdyPxGkU18rEjXAnfe78nGsCaJ9rbdqeRge3ZFij9yDr1g+WBCNJrzXvN FR4y9EZdm6jRQ== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id EB1F069054; Tue, 6 Jan 2026 07:29:29 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id cMqap1-xbpSX; Tue, 6 Jan 2026 07:29:29 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767709765; bh=8z4pwDXlFHmlJtMM0QqvKiQ9zrA9HJqWtSO8rB0gSts=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JsLHAfKy2LNzzQ7I5CprybGnlNtbJDYbmVOi78gXgCFVxO72y9TcrmcyvreSTFfbi 4EzugYM7RwjzBFgFVIt4HEE4/FJ4hTzUw9X+GEjHi02YsPER7hVlzsPogVu95Of73g NwXlI58ij3KLD+SK8yxrtF1ayi7UoOXsKChXdreIo1Ef6YFiaSTjy0YTbssJ4fc0zS dTNihbEA2776xAFiDYPn2qAwSmBjd0YcEi6y0Qn6IM/7Z/xqPvH+NgvkG5y8QDlfKP Y8kzqTp1v6fu8NWu1rLRKYV7uMmFCVyelGVVSMb1YWHKXb9ceuEa12VCjGIbzY9mNS 4K0zKxRxdre1Q== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 831E569083; Tue, 6 Jan 2026 07:29:25 -0700 (MST) From: Simon Glass To: U-Boot Concept Date: Tue, 6 Jan 2026 07:28:15 -0700 Message-ID: <20260106142834.2511220-11-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260106142834.2511220-1-sjg@u-boot.org> References: <20260106142834.2511220-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: KAO6PZ77BL7T44SJMWKOKDOEI763SC5T X-Message-ID-Hash: KAO6PZ77BL7T44SJMWKOKDOEI763SC5T X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Glass , Claude X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 10/22] buildman: Fix docstring in add_line_prefix() List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass Add missing 'brds' parameter documentation and add type annotations to fix pylint W9015/W9016 warnings. Also fix typo 'training' to 'trailing'. Co-developed-by: Claude Signed-off-by: Simon Glass --- tools/buildman/test.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/tools/buildman/test.py b/tools/buildman/test.py index e59c623f6bf..eae614b56b5 100644 --- a/tools/buildman/test.py +++ b/tools/buildman/test.py @@ -287,16 +287,17 @@ class TestBuild(unittest.TestCase): def add_line_prefix(prefix, brds, error_str, colour): """Add a prefix to each line of a string - The training \n in error_str is removed before processing + The trailing newline in error_str is removed before processing Args: - prefix: String prefix to add - error_str: Error string containing the lines - colour: Expected colour for the line. Note that the board list, - if present, always appears in magenta + prefix (str): String prefix to add + brds (str): Board names to include in the output + error_str (str): Error string containing the lines + colour (int): Expected colour for the line. Note that the board + list, if present, always appears in magenta Returns: - New string where each line has the prefix added + str: New string where each line has the prefix added """ lines = error_str.strip().splitlines() new_lines = []