diff mbox series

[Concept,09/22] buildman: Use set comprehension in test.py

Message ID	20260106142834.2511220-10-sjg@u-boot.org
State	New
Headers	From: Simon Glass <sjg@u-boot.org> To: U-Boot Concept <concept@u-boot.org> Date: Tue, 6 Jan 2026 07:28:14 -0700 Message-ID: <20260106142834.2511220-10-sjg@u-boot.org> In-Reply-To: <20260106142834.2511220-1-sjg@u-boot.org> References: <20260106142834.2511220-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: MOSHASTIVD6VHXRIFWC2EOSRL7GGD5SH CC: Simon Glass <simon.glass@canonical.com>, Claude <noreply@anthropic.com> Precedence: list Subject: [Concept] [PATCH 09/22] buildman: Use set comprehension in test.py Archived-At: <https://lists.u-boot.org/archives/list/concept@u-boot.org/message/MOSHASTIVD6VHXRIFWC2EOSRL7GGD5SH/> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit
Series	buildman: Clean up test.py for pylint compliance \| [Concept,00/22] buildman: Clean up test.py for pylint compliance [Concept,01/22] buildman: Fix indentation and semicolon in test.py [Concept,02/22] buildman: Add __init__() to Options class in test.py [Concept,03/22] buildman: Convert to f-strings in test.py [Concept,04/22] buildman: Fix import order in test.py [Concept,05/22] buildman: Convert CamelCase to snake_case in test.py [Concept,06/22] buildman: Add missing docstrings in test.py [Concept,07/22] buildman: Fix singleton comparisons in test.py [Concept,08/22] buildman: Use tools.write_file() in test.py [Concept,09/22] buildman: Use set comprehension in test.py [Concept,10/22] buildman: Fix docstring in add_line_prefix() [Concept,11/22] buildman: Remove unused variables in test.py [Concept,12/22] buildman: Fix implicit string concatenation in test.py [Concept,13/22] buildman: Mark unused arguments in test.py [Concept,14/22] buildman: Disable protected-access warning in test.py [Concept,15/22] buildman: Rename commit parameter to avoid shadowing in test.py [Concept,16/22] buildman: Rename constants to UPPER_CASE in test.py [Concept,17/22] buildman: Shorten long lines in test.py [Concept,18/22] buildman: Disable pylint warnings for Options in test.py [Concept,19/22] buildman: Split TestBuild into multiple classes in test.py [Concept,20/22] buildman: Refactor _check_output() in test.py [Concept,21/22] buildman: Split test_process_limit() into two tests in test.py [Concept,22/22] buildman: Disable some final pylint warnings in test.py

Commit Message

Simon Glass Jan. 6, 2026, 2:28 p.m. UTC

  From: Simon Glass <simon.glass@canonical.com>

Use set comprehension instead of set() with list comprehension to
fix pylint R1718 warning.

Co-developed-by: Claude <noreply@anthropic.com>
Signed-off-by: Simon Glass <simon.glass@canonical.com>
---

 tools/buildman/test.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/tools/buildman/test.py b/tools/buildman/test.py
index 8b015e22090..e59c623f6bf 100644
--- a/tools/buildman/test.py
+++ b/tools/buildman/test.py
@@ -712,7 +712,7 @@  class TestBuild(unittest.TestCase):
         build.commits = self.commits
         build.commit_count = len(commits)
         result = set(build._get_output_space_removals())
-        expected = set([os.path.join(base_dir, f) for f in to_remove])
+        expected = {os.path.join(base_dir, f) for f in to_remove}
         self.assertEqual(expected, result)
 
     def test_adjust_cfg_nop(self):