[Concept,01/12] buildman: Suppress pylint warnings in board.py
Commit Message
From: Simon Glass <simon.glass@canonical.com>
The Board class is a data container that legitimately needs many
attributes and constructor arguments. Suppress the following warnings:
- too-many-instance-attributes
- too-few-public-methods
- too-many-arguments
Also add missing type annotations to the docstring for consistency.
Co-developed-by: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: Simon Glass <simon.glass@canonical.com>
---
tools/buildman/board.py | 18 ++++++++++--------
tools/buildman/boards.py | 1 +
2 files changed, 11 insertions(+), 8 deletions(-)
@@ -4,21 +4,23 @@
"""A single board which can be selected and built"""
+# pylint: disable=too-many-instance-attributes,too-few-public-methods
class Board:
"""A particular board that we can build"""
+ # pylint: disable=too-many-arguments
def __init__(self, status, arch, cpu, soc, vendor, board_name, target,
cfg_name, extended=None, orig_target=None):
"""Create a new board type.
Args:
- status: define whether the board is 'Active' or 'Orphaned'
- arch: Architecture name (e.g. arm)
- cpu: Cpu name (e.g. arm1136)
- soc: Name of SOC, or '' if none (e.g. mx31)
- vendor: Name of vendor (e.g. armltd)
- board_name: Name of board (e.g. integrator)
- target: Target name (use make <target>_defconfig to configure)
- cfg_name: Config-file name (in includes/configs/)
+ status (str): Either 'Active' or 'Orphaned'
+ arch (str): Architecture name (e.g. arm)
+ cpu (str): Cpu name (e.g. arm1136)
+ soc (str): Name of SOC, or '' if none (e.g. mx31)
+ vendor (str): Name of vendor (e.g. armltd)
+ board_name (str): Name of board (e.g. integrator)
+ target (str): Target name (use make <target>_defconfig to configure)
+ cfg_name (str): Config-file name (in includes/configs/)
extended (boards.Extended): Extended board, if this board is one
orig_target (str): Name of target this extended board is based on
"""
@@ -790,6 +790,7 @@ class Boards:
"""Add Status and Maintainers information to the board parameters list.
Args:
+ srcdir (str): Directory containing source code (MAINTAINERS files)
params_list (list of dict): A list of the board parameters
Returns: