From patchwork Sat Jan 3 20:32:38 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1259 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767472433; bh=LSEyBP5JwlvJEx2xcDr295TjJONVCQ+LtKrar8In/KM=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=qYj9pHgJFX4oKdsCjwn4fbCkY6Gk9W6jWCIDtKsRSHXsb1rhectw1xoTGIhhY1VfI /9KA2nuvq9ANmo8qgOwhmA9ArFzsNulKjcqjU7APrG4UhAismSaREni4ZQ3cdzXc13 +iMnvcpmH9pmeUUS7WOx/BFGDkNprwatd8yBB7elwcwxaceVrMtPD7gkAaQ8ZQFORN 7fIl0o+o86obCSTP52sLSdAXFuG6amDGqYznhk9zPlAxXhuyI3Z4cjbUmWrWXQxOyQ IkL2eBeAQKlpBxYNBKZaj0Mimy4UGGtNlgxkkfC/E2xbcBsxUk0oHVzwUEQh0H+I6k Hl4yTMYO1WvVA== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 3C81C68F35 for ; Sat, 3 Jan 2026 13:33:53 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Ckpum6176o52 for ; Sat, 3 Jan 2026 13:33:53 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767472433; bh=LSEyBP5JwlvJEx2xcDr295TjJONVCQ+LtKrar8In/KM=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=qYj9pHgJFX4oKdsCjwn4fbCkY6Gk9W6jWCIDtKsRSHXsb1rhectw1xoTGIhhY1VfI /9KA2nuvq9ANmo8qgOwhmA9ArFzsNulKjcqjU7APrG4UhAismSaREni4ZQ3cdzXc13 +iMnvcpmH9pmeUUS7WOx/BFGDkNprwatd8yBB7elwcwxaceVrMtPD7gkAaQ8ZQFORN 7fIl0o+o86obCSTP52sLSdAXFuG6amDGqYznhk9zPlAxXhuyI3Z4cjbUmWrWXQxOyQ IkL2eBeAQKlpBxYNBKZaj0Mimy4UGGtNlgxkkfC/E2xbcBsxUk0oHVzwUEQh0H+I6k Hl4yTMYO1WvVA== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 21ABC68FC8 for ; Sat, 3 Jan 2026 13:33:53 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767472431; bh=Hjhrk1UrjNT0F7LRnsok4KqnWYGfQ4AT9schVRWL1os=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GcvnYr0k+z9uaV9O1MO4PoI/eQKeyJT9O39aQcfq5R/7HH+Pt5z+7GGvJq7TAM4da mamSkRhuRS+cK+D9yW5tYNI1WyeLLsyYoTvj662GLGRkJeXejBM0CQF8zR7oIb6S1G 7dd+Ti800avguLzF9v8mjTJu8WqnvlntY6v0E8tS5UOFQ26lfnqAK9FGdnDzYmZpJT Sdi1T9R0hn5TPpUmwfcIcYa4CZiDHN6PewdUQ4cZsfJToKA3XjFNI2kQ2JgUUCjSSN sVZhdiJE4ggFVEkoqCwpUPLDO0f1NqFGk+XiILk1VGLXjQCNN1GYEukksm1tznoplF VBR4qapyVFjtw== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id C427368F35; Sat, 3 Jan 2026 13:33:51 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id EkVmiOfigO3o; Sat, 3 Jan 2026 13:33:51 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767472427; bh=dcG/NftvcTGTNH8NyvQUffY8KLn1IFdV6V7jGxOn3PU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AvsvwQQiBlrElztcyi3pE+shQC30t6ksZAR64JA4syoANNHSbro1/cf2Roa3vMg5L IUMT64TRsT3s10s/niY1g9WrH3SqrpfHhng2AyokVoknMmu7VB2y86tmNZmhTdHhLp 3PRG8FiXrQGCOysp2hZS4AX8dBCzsy+h8x+aF20PPzbjQ/xrRbz8VSi6Szt/Cgwx5f cfeeNgErcMGomW748ozrWaTF8V7blf7aI0bJO+0+nwLZWnM3XuqrukZU+PlWkXkICT 0UUoCF6s5jxbQEpn4TnQnWNSVxA21BZT0rpjLDQFfo9JWDZiGGZQYEubkZUf4GRrH9 qRj73qgWGdxng== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 551AF68FC8; Sat, 3 Jan 2026 13:33:47 -0700 (MST) From: Simon Glass To: U-Boot Concept Date: Sat, 3 Jan 2026 13:32:38 -0700 Message-ID: <20260103203243.3727493-13-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260103203243.3727493-1-sjg@u-boot.org> References: <20260103203243.3727493-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: 7SHUARK43WIYVEDUESIFB4HBT3VPNZMS X-Message-ID-Hash: 7SHUARK43WIYVEDUESIFB4HBT3VPNZMS X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Glass , "Claude Opus 4 . 5" X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 12/12] buildman: Fix remaining pylint warnings in boards.py List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass - Add module-level disable for too-many-lines - Suppress consider-using-with for NamedTemporaryFile (intentional) - Change unused linenum to _ in parse_file() - Suppress too-many-arguments for _check_board() - Add missing param documentation for parse_extended() Co-developed-by: Claude Opus 4.5 Signed-off-by: Simon Glass --- tools/buildman/boards.py | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/tools/buildman/boards.py b/tools/buildman/boards.py index 550c0feffa1..7992aae0914 100644 --- a/tools/buildman/boards.py +++ b/tools/buildman/boards.py @@ -3,6 +3,8 @@ # Author: Simon Glass # Author: Masahiro Yamada +# pylint: disable=too-many-lines + """Maintains a list of boards and allows them to be selected""" from collections import OrderedDict, namedtuple @@ -268,6 +270,7 @@ class KconfigScanner: '-x', 'assembler-with-cpp', defconfig] stdout = command.output(*cmd, capture_stderr=True) + # pylint: disable=consider-using-with temp = tempfile.NamedTemporaryFile(prefix='buildman-') tools.write_file(temp.name, stdout, False) fname = temp.name @@ -523,7 +526,7 @@ class MaintainersDatabase: maintainers = [] status = '-' with open(fname, encoding="utf-8") as inf: - for linenum, line in enumerate(inf): + for _, line in enumerate(inf): # Check also commented maintainers if line[:3] == '#M:': line = line[1:] @@ -688,6 +691,7 @@ class Boards: return terms @staticmethod + # pylint: disable=too-many-arguments def _check_board(brd, terms, brds, found, exclude_list, result): """Check whether to include or exclude a board @@ -1076,7 +1080,12 @@ class Boards: raise ValueError(f"Board '{target}' not found") def parse_extended(self, dbase, fname): - """Parse a single 'extended' file""" + """Parse a single 'extended' file + + Args: + dbase (tuple): Database of defconfigs from qconfig + fname (str): Path to the extended-board file to parse + """ result = ExtendedParser.parse_file(fname) for ext in result: ext_boards = self.scan_extended(dbase, ext)