From patchwork Wed Dec 31 22:29:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1151 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767220287; bh=wTuaCzUxq67U3bSGt8DrPEZqKVlOe3+l998CWn9W31k=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=ob/3wZrujsjbcjjRAvtVW0xhxnfSYrvZjPI0zVi3WQ8Xkp1uLDa4kgRuXH9RiUiIv 8kJwRaZ9rRr1BK+S0L+R/lQL4KBVMWDIZopBDoMXmFxOpp3efWSNU9CocwpYG6dQK/ 4/BS5HLisRWtkkUhcpB95xcnWX3cXkmcvZLITi4hcU4XS+xvO8TbgvCpoFNiKTX+on NNt3iCVqcROe0H9nVHp72si+SrGJcLCVbVYrk9x8bYuFJRhI6+75cNAjxjlsB6DrqH 55TdEUI3Xoizv1TLuIA8QT/7thOVejVkh4udEgddPFR+2tys94P26xO92PcYJPHCKu BzK0MxLy4Ua7w== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 022DD68F65 for ; Wed, 31 Dec 2025 15:31:27 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 3Ceb3-vnJroo for ; Wed, 31 Dec 2025 15:31:26 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767220286; bh=wTuaCzUxq67U3bSGt8DrPEZqKVlOe3+l998CWn9W31k=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=Gck/Q8wHP8Eeqxe+SqoSxenpruZscjMtP82Rwk34gpCqQaPhNF8QsRwSIefnRP4uV KLER4FlB4iKKhcH6vG6oI+nOB9NmPkdAxWBSdsI34XRoWTe2f162YOH2fjfetZD7l3 LgY2BMUMEvWzxGxZpO+5si+YdXUI/S1IwkrP9oMYzeAMzinc2nPUvu/Th/wWwYbGTM RhHcKnoglD8iY5nR6dTm+djZlXF4d0vLMIPKJI9NS5ZMDh4cfpgezz2sNkJKowcGEq 9Pym7+UmwhNKKHDOyC/XgRn04Q9khXYPUyLUj5DkZPhEOKg+1Z4NbXlOFj1weeBGY2 zh8aJ+Bg+S7MA== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id DE28068C5D for ; Wed, 31 Dec 2025 15:31:26 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767220284; bh=RvyzsIhlq4FUPMa5Uhcx4BdB2kdRZMmI1HX4II5iF6Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XKYNWA+bj3pbGgqUUdT27VzR7CgOM+EgFh5Pqli28B4rPE+Z9rE9e0qPmQ+SlEOFJ QmLHuha2Q75rNyyu7D/NIWK+PrFxQFdlYi0n6NsPgHKnp/1olDqX2d8zJJPDIdnVf5 3cgmyvKwXOnAS4MgvIkQpQn8u+5e5wnewQvxX+78Nd+LAhSMvnvNSlGnqM52s0VUvQ sTjBwJ5diexEgdkn+ieGMG6djq0LEphD26XHFM+7InFnnFlJVeKtCs/4qmbhJ1D87C 3M+t5N/g4jDMseEk35EGTZWGFK0wagxeZyiJUvDbRHdw1mm/7LYHRx2eA/KPKqjVgz jm5ccn0di+Sdg== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id E758668C5D; Wed, 31 Dec 2025 15:31:24 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id M93tP2Jdr50Y; Wed, 31 Dec 2025 15:31:24 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1767220280; bh=RnX+Ze3ayBAw8NDG0s8Ux8awWlsvZ6vaUVFOMbbSx+8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R5VXKUbwGiQ7I7uVdV+vPgxdZM++UfO6V5HqcgmoVlBn4FA/L1tSEs7WREuwfIU9W AFpM5cTOrJruinKdslfkp3Hhjrz5boqrhnDbk6ZMPQmshGZAFezLQIb1Yzvt6nmXUU zaW/n0GxljviHkhOACCB5r2/X+OdrhbmA42j2H2yZ1L+d1WWNiAuVVIMOvoTlMkg7O 3zBZDHk+YEKEe7vfvsvPM0Geb+jA6yxgubM0kLFHS3WqKb9rpwgcrqfsSM6PIT+QZW 4gODLCfvjjk7zf8ImPrdZErYr/psIIOYgrGJ5eRkha/CvZNmV0CHNMtSh0RQRhGErm KnuJfEN7ggpSw== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 8F0AC68F61; Wed, 31 Dec 2025 15:31:20 -0700 (MST) From: Simon Glass To: U-Boot Concept Date: Wed, 31 Dec 2025 15:29:46 -0700 Message-ID: <20251231223008.3251711-14-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251231223008.3251711-1-sjg@u-boot.org> References: <20251231223008.3251711-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: 5VXJ6L2O3G4XALDE45YJSXQ5SWPPGMNR X-Message-ID-Hash: 5VXJ6L2O3G4XALDE45YJSXQ5SWPPGMNR X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Heinrich Schuchardt , Simon Glass , "Claude Opus 4 . 5" X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 13/26] ext4l: Use the real crc16 implementation List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass The crc16() stub always returns 0, which causes group-descriptor checksum-verification to fail for filesystems using the old CRC16 checksum algorithm (gdt_csum feature without metadata_csum). Replace the stub with U-Boot's real CRC16 implementation to allow mounting these filesystems. Co-developed-by: Claude Opus 4.5 Signed-off-by: Simon Glass --- fs/ext4l/ext4_uboot.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ext4l/ext4_uboot.h b/fs/ext4l/ext4_uboot.h index df26c02b54d..ba4b4266daa 100644 --- a/fs/ext4l/ext4_uboot.h +++ b/fs/ext4l/ext4_uboot.h @@ -2143,8 +2143,8 @@ struct fs_parse_result { /* ctype */ #include -/* crc16 */ -#define crc16(crc, buf, len) (0) +/* crc16 - use U-Boot's implementation */ +#include /* Timer and timing stubs */ #define HZ 1000