From patchwork Mon Dec 8 02:32:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 835 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1765161184; bh=PweDwYTaoI+AiJ+KrQskqhC+auIeIagjdcmeDJ/BoY4=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=lo1HKyVsDMh016YeUY1J5m7Zu6GRrFHv7nSUpTAAvTdi+ksyL0NfFqWqEuMqQvBBk kW/42r6Ln0kYqn6e7DenNfWsXRXDhWq/izlRJE5FDHKdQNt3ClQpNGCkjR18x56HK6 RgJooz/snvaAGJ7BXuoq5WCVnLlbNDCwAorFZ8mXVYeB/uwajbJestmDpQ0L7CnVqf 6Y2wPw563uwl8BmoQvkTZOo1dYt8TS34AY5oQ+UWeagZdxRWTotkHLlvqltQ8PhK2n Pd1ikV0HOJGDqlV8zrl77qgaURhqOHpmVmx6IGj42E2GlB2vwDb3lH4hqg5n4X8B1e syFIbi3lwh4cA== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 5923C688FC for ; Sun, 7 Dec 2025 19:33:04 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id SlhUfaMKrCsD for ; Sun, 7 Dec 2025 19:33:04 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1765161184; bh=PweDwYTaoI+AiJ+KrQskqhC+auIeIagjdcmeDJ/BoY4=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=lo1HKyVsDMh016YeUY1J5m7Zu6GRrFHv7nSUpTAAvTdi+ksyL0NfFqWqEuMqQvBBk kW/42r6Ln0kYqn6e7DenNfWsXRXDhWq/izlRJE5FDHKdQNt3ClQpNGCkjR18x56HK6 RgJooz/snvaAGJ7BXuoq5WCVnLlbNDCwAorFZ8mXVYeB/uwajbJestmDpQ0L7CnVqf 6Y2wPw563uwl8BmoQvkTZOo1dYt8TS34AY5oQ+UWeagZdxRWTotkHLlvqltQ8PhK2n Pd1ikV0HOJGDqlV8zrl77qgaURhqOHpmVmx6IGj42E2GlB2vwDb3lH4hqg5n4X8B1e syFIbi3lwh4cA== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 0DF3968923 for ; Sun, 7 Dec 2025 19:33:04 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1765161179; bh=++10PWR9MJE8JDHEhJ+ZZTPF1wY0m/yfmHxsyUORar0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oeE/W589q2p4Xev/vs91UdIVdDvTtgVsh9ujUZda5Diz6Ou2Yt2tAj/Z9hTU/fFid /IEkL1P+09YkS7JwT5uf8huQcnTB1T2jvQVp6K/C9L+dTYRgZAyW44z9ktRE2Cu3zY jHcwwWL9YFau85dCIqzhB1hr0a9hQFUM4+ZpB5OsIFK8BAm2mq+WdUmn8hxhrzEZbf JeXJESqo6zI4LUanqt1rSjnbUxkK0rHQ2XW+TNKhYbNW+/O3Ll28JaJIZ/FOBYUNG2 DDTTggBHPsGiVusSjrj4YDz4zUaaAYOZ6fyza1KKBQjH01C/OM0QYfkY2TD7ck5lQj TmId92BZ54b6A== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id DF032689C7; Sun, 7 Dec 2025 19:32:59 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id 0YaRsyzzFjII; Sun, 7 Dec 2025 19:32:59 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1765161169; bh=wAIVWi6/FPa/UfoCjQcFLyB045+aPWtyNnC6UNrQuCc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=loHuOeT+PJZu3rhwMSHRe8+7uivBq23RbJYiyaLU7QOBFwfRCs0ZQC5wN23p0HHaD qxKgWScWphNR+JyD3ukv3RLdIDyVnyiFIYS/PSs65v9YA+4OSDgn/F4fLvg30tLdNi TQ8OdC/nDcLO+T2d3hpBnwaMyIxK+p+lC1NvgXhAtkZ2l3ISF7wG7lip+oPougO7W+ ZplamT0Zyu1GQxuLYFrEuC7JkpuevQNN9uHNP9MYAEdcU86rQHxMX9CZ/E517dL06A x4uAEyP3s2us24ewkwW5yHygpWMoBRuoLZJvA7qaQEstiClh6k25rM37Q7OqZa0oYq qwujh7DcbLs1Q== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 207726883E; Sun, 7 Dec 2025 19:32:49 -0700 (MST) From: Simon Glass To: U-Boot Concept Date: Sun, 7 Dec 2025 19:32:05 -0700 Message-ID: <20251208023229.3929910-3-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251208023229.3929910-1-sjg@u-boot.org> References: <20251208023229.3929910-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: I356HJWZ3HHNV6FPNRFLNJSJTNYC5HEG X-Message-ID-Hash: I356HJWZ3HHNV6FPNRFLNJSJTNYC5HEG X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Glass X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 02/19] bootctl: Drop unnecessary calls to calculate dimensions List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass Since scene_calc_dims() is done by scene_arrange(), we don't need to do an explicit call to scene_calc_dims() first. Drop it from both UIs. Signed-off-by: Simon Glass --- boot/bootctl/multi_ui.c | 9 --------- boot/bootctl/simple_ui.c | 4 ---- 2 files changed, 13 deletions(-) diff --git a/boot/bootctl/multi_ui.c b/boot/bootctl/multi_ui.c index adf48808c0f..975f9a1b91c 100644 --- a/boot/bootctl/multi_ui.c +++ b/boot/bootctl/multi_ui.c @@ -426,10 +426,6 @@ static int multiboot_ui_add(struct udevice *dev, struct osinfo *info) multiboot_set_item_props(scn, seq, &info->bflow); - ret = expo_calc_dims(upriv->expo); - if (ret) - return log_msg_ret("ecd", ret); - if (lpriv->default_os && !strcmp(lpriv->default_os, info->bflow.os_name)) scene_menu_select_item(scn, OBJ_MENU, ITEM + seq); @@ -498,11 +494,6 @@ static int multiboot_ui_switch_layout(struct udevice *dev) return log_msg_ret("props", ret); } - /* Calculate dimensions then re-arrange */ - ret = expo_calc_dims(upriv->expo); - if (ret) - return log_msg_ret("ecd", ret); - ret = scene_arrange(scn); if (ret) return log_msg_ret("arr", ret); diff --git a/boot/bootctl/simple_ui.c b/boot/bootctl/simple_ui.c index 7fb59c8b8c3..58860138a33 100644 --- a/boot/bootctl/simple_ui.c +++ b/boot/bootctl/simple_ui.c @@ -156,10 +156,6 @@ static int simple_ui_add(struct udevice *dev, struct osinfo *info) if (ret) return log_msg_ret("asn", ret); - ret = expo_calc_dims(upriv->expo); - if (ret) - return log_msg_ret("ecd", ret); - if (lpriv->default_os && !strcmp(lpriv->default_os, info->bflow.os_name)) scene_menu_select_item(scn, OBJ_MENU, ITEM + seq);