| Message ID | 20251207201628.2882382-5-sjg@u-boot.org |
|---|---|
| State | New |
| Headers |
Return-Path: <concept-bounces+u-boot-concept=u-boot.org@u-boot.org> X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1765138636; bh=cIp+EA+VclO9ows1rkVF0913xZyAY4n/PsS0ic5ASfU=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=mQWI6k4i2eZJHzuPNQVhqOa7UsqIocQLnhEcPmri6bK2gM+A8AHP95U3ZiI3B11TZ /qFVhfCfLlzklvR+WAKAx55q+Coq3cP/rISFokNatiqBkJfe521BClUqqlbJGGeJ12 M9Jy2k93dWELoDMXDl0cZR87LjZ86o/244XqbohgZMektWkV2+fG1fL2AuUdA58sM5 nNWYIMTkUPLWIbw1sxEmrydN2aW1G1953s8mu1dLmkeDC1XAANei0FjhriqWREjbsk r1wd+J/PmDEW4BmncMnZUHSkYhE4a20uGxmbp8NsBPCQ8TSCO45XvQsWiPeOXTgbUe ZCs6P00On8ZWA== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 3E94668995 for <u-boot-concept@u-boot.org>; Sun, 7 Dec 2025 13:17:16 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 7_a-RkGzpY0Q for <u-boot-concept@u-boot.org>; Sun, 7 Dec 2025 13:17:16 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1765138635; bh=cIp+EA+VclO9ows1rkVF0913xZyAY4n/PsS0ic5ASfU=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=rvn19CQcG93oxF3x5y/f1jZcujpvVLxCmCIXeoeLTh8uTQGzXLwSKHhm3jULnHOYf UhHjVuy6D/OHcj+pSckQexTw88hUOiyHGEXOG/OylPJuRiRueVV35rzL1GCPYTU0Ku sz4GpubgT9BLCz3WVXWe+BNq25Z0uEde0Jmibhiz5haFr3uEiRVEsvdKnD3hURqAiv xpP07AWWTB9oklYGY6I85WFms4xzKdOccDcMNeqUxUE9DqRahfpEUNYy0jj8I2HYhq ncy+DvSePTkfSDSqorzVY4RwhtYMirQpwYNL8L8OggH8MzzxSoZd9T6RIWIsRzCfCF C4CsS5uNBTxOQ== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 3AE166899B for <u-boot-concept@u-boot.org>; Sun, 7 Dec 2025 13:17:15 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1765138633; bh=O0MuOyt7JOdyXjrAyN73ZLmIKUXvhmFLEyA22a6FmSs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GW+gi6aPAHRytYquRVS9JXXNaLnC79UINBT18jJlIXDu8tzEB+dJcv6wQPw9eHnvI uIl1wde95C83R06WL0sWdT7Ry37YYIXKmjBzLXQXEOXZ3zxDcCsAPOZpkPGmnYx1ui hmPq+gyF6qnF2eus/lBTchVipiFoszOlDaKd/19pyRkytMQmBI1pu8lZDFNNKgh2p1 3W+Q5J04bhzYwPa9Zam1h7zj6vMXhvukTYE5BwbhKSLr10AdHCNFMNu1KifXj5Zkdm V2WAIiodM3lG37epospmMf1X0fmdO9qdnG/AyaTgma0bsUnURB2MKnwKsgKuYocB1D 0KY3+qC8NxaYw== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 5A1F25F6BF; Sun, 7 Dec 2025 13:17:13 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id dauRNjBI9KuX; Sun, 7 Dec 2025 13:17:13 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1765138633; bh=iqlkQUvjLwq3TRscfzQRTijBU7qVRlKDe/IIPIzmHHE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jeoTtDGyBWCyfp8ZpWhXOy1f4pCiGDARIyj83qVRBuh8ixrRVK6oEnC8B6GtzPPXP 3st/UPsM7bSlsXvk/ZTXIo8Ih1MmBkxNp9Cn9dPZcuG6/pDvXlt7B79TLUfikrPxxQ h1XIgDlyss/Gh9Ub6XnyBGYaCclVX5tfLQF/ZqvevfkaMo/qROLYzqmsma5B2nHIcI aQI1sUQ4RMf+kz7mf52f9o5J0zO5ZSTRCTiGFc5ydfLPWlKcIKMRvUDiNaDCwQXyLy kvio+5XQRaeyFrFU2AFzPFM42mRb4yoyT7Z5rcsULXgJPqNk1+gwYmpSrn6/Ywgbm9 piLKkD01q8bKw== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id BA31C688EF; Sun, 7 Dec 2025 13:17:12 -0700 (MST) From: Simon Glass <sjg@u-boot.org> To: U-Boot Concept <concept@u-boot.org> Date: Sun, 7 Dec 2025 13:16:01 -0700 Message-ID: <20251207201628.2882382-5-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251207201628.2882382-1-sjg@u-boot.org> References: <20251207201628.2882382-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: HXMFKAU6K5UCP4UWKIFGBDBXXAVVAC6O X-Message-ID-Hash: HXMFKAU6K5UCP4UWKIFGBDBXXAVVAC6O X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Heinrich Schuchardt <xypron.glpk@gmx.de>, Simon Glass <simon.glass@canonical.com> X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 04/22] video: Document the quirk in truetype_get_cursor_info() List-Id: Discussion and patches related to U-Boot Concept <concept.u-boot.org> Archived-At: <https://lists.u-boot.org/archives/list/concept@u-boot.org/message/HXMFKAU6K5UCP4UWKIFGBDBXXAVVAC6O/> List-Archive: <https://lists.u-boot.org/archives/list/concept@u-boot.org/> List-Help: <mailto:concept-request@u-boot.org?subject=help> List-Owner: <mailto:concept-owner@u-boot.org> List-Post: <mailto:concept@u-boot.org> List-Subscribe: <mailto:concept-join@u-boot.org> List-Unsubscribe: <mailto:concept-leave@u-boot.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit |
| Series |
expo: Expand docs, dump and textlines in non-popup expos
|
|
Commit Message
Simon Glass
Dec. 7, 2025, 8:16 p.m. UTC
From: Simon Glass <simon.glass@canonical.com> The current code is written to suggest that the cursor position (priv->pos_ptr) might be respected. In fact a bug means that it never is, since index is set to priv->pos_ptr, so the if() condition always fails. Further, when editing textline objects, the cursor index is always the same as priv->pos_ptr anyway. Fix the bug but keep the current behaviour, adding a comment for future readers. Signed-off-by: Simon Glass <simon.glass@canonical.com> --- drivers/video/console_truetype.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/video/console_truetype.c b/drivers/video/console_truetype.c index 4ddf133f2e0..7f5a2262b17 100644 --- a/drivers/video/console_truetype.c +++ b/drivers/video/console_truetype.c @@ -1097,9 +1097,13 @@ static int truetype_get_cursor_info(struct udevice *dev) * figure out where to place the cursor. This driver ignores the * passed-in values, since an entry_restore() must have been done before * calling this function. + * + * A current quirk is that the cursor is always at xcur_frac, since we + * output characters directly to the console as they are typed by the + * user. So we never bother with priv->pos[index] for now. */ index = priv->pos_ptr; - if (index < priv->pos_ptr) + if (0 && index < priv->pos_count) x = VID_TO_PIXEL(priv->pos[index].xpos_frac); else x = VID_TO_PIXEL(vc_priv->xcur_frac);