From patchwork Sun Dec 7 20:16:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 832 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1765138690; bh=MMhj0NXRUKlmd/VhjJJEixAsylVzBOGifd/zOFrOmSs=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=hxCzIfni/CcENSAg+z/IDVYvNbO3KgzAli9CW2v5NJ6Hzdhk/DrRoI7luMux1xLy7 m9votC860EaB6bOyFd/OANeTKqMW7ZBPgwOeVfIBGzrjVrgVHPs6fmnKJN3AsouEiD rh9mlYiUKELyUKluqmXDO27xFQ+RxOqhq1aaXO88W89Lr5l+rk9X77XszKofRVvKem ReefQCQKk3G62y1T6c0fEmCQ/N4eMRjQ7l5ejAvHbyXpKzACMbUZ4/VXlmikFJ5wJy gZQ9K6J7k1iZLQuzPqKZqIe4V2D4ehUeNKgRORm3KxyNxmKUrYMsONSq34HJ+G5BYh 9WFKcuj6tegOA== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id C0F6968950 for ; Sun, 7 Dec 2025 13:18:10 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id IWzm1dmBX8vw for ; Sun, 7 Dec 2025 13:18:10 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1765138689; bh=MMhj0NXRUKlmd/VhjJJEixAsylVzBOGifd/zOFrOmSs=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=ot2TrWVUwyWeDXNwtw3zABLM9M9uCX1M7WmKRvsgspvC0dnsa4ix+dbkyyl8SUFD9 6DjBtvlH5JyV4vD6RIP55kieHXungLrWZu8lWjDjewCzZue5lwMcAEjqOgEVvIRic5 STYDzjRROF9syT1fhYg8Sx784aDedK1lfGc3t+eKqHSuIW6pVZ0cLLp4XXxKL1p2Zv 6Z7z29oic5eFQLaNcb9CPryNqz9xpIYw1Elsn4s3ns/jKg3UNJamTuJjuhtFzPxwfH M5erymBNbiDFLzZQTP1vvrL7O2hAc5tN6cXIv7N53h724oIJZxbiUAfhf2Uw0UwKUT IMEO6/1uq3trw== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id C1619689A8 for ; Sun, 7 Dec 2025 13:18:09 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1765138686; bh=ST1FyJZ9UNnib7Wz6MySuXVW/YYvUjcJWGFd9Sjl6UY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MbbC7z1HHi4OyQ32lq+bAScPEADC01OTWdiH0ybYJEVRX6bWgxSkOK0aM88e5XPgw CTXofQJ2zJrJRqy4/R4U4F4+EFQEglLJnSJbJW4g2ofLO9OU5IPhWDC6EvIGdzGtdQ iOBQWDeWLFe7BNV5ZheDKSseDi3Gg/XYlImx47HL99knsibluz9v44xBiPkV8sl4yf YH/KDuvs2MAUyf3KJdghBNqEtZyeCxkjzLWiZlEDb/Zk4hjG5es3MZ0cQfmmRR53uT lfbYZ4ftX/28S9IsYBHkWAF5j4CbviCihcCBf9lR6Bi14yctUbS/jb8vB/QBmrk1L0 bnbo/vjUD5ptA== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id AE7DE5F6BF; Sun, 7 Dec 2025 13:18:06 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id yibssMRT8hR0; Sun, 7 Dec 2025 13:18:06 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1765138686; bh=Uzb4QGWCtsL9FnBPlHS9nUq0x6yl+1S8A3JEA3VEdV0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y25IluSm41WbFz195jyfdFUTep+UxZWHjuIkfiA7ZJqsT3Uy+L40gvHtD+7D/dTHY Mw/AQUIpy9LgbIDw+0tTA5PMPJG5PyP47HmKs5BQv5TRzH5oN7hdwtoaHPNXjw/54y XmuDje6K12syz4nVw9bqjGy2wRn4NY30pbTE8XCwMKWcx3n7fniKcctLyxD7FNCs6c 5phcseGmWQh+XgUoSc/WDynJr61Cklosp/iqWvoNcjjtaZO+kHe8ALKyeXYLL1jOqj UsQ5Yw7uTfspkM/jqcX2mh6WK66Yd1bs3uBD1MZfANuS5stFZr7R81R61LPq3/ksza N6FUDfp9Jmoxg== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 103E66883E; Sun, 7 Dec 2025 13:18:05 -0700 (MST) From: Simon Glass To: U-Boot Concept Date: Sun, 7 Dec 2025 13:16:17 -0700 Message-ID: <20251207201628.2882382-21-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251207201628.2882382-1-sjg@u-boot.org> References: <20251207201628.2882382-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: ZNWSLO4SWBN4OW4NZCSD7SGLQEFZEMDR X-Message-ID-Hash: ZNWSLO4SWBN4OW4NZCSD7SGLQEFZEMDR X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Heinrich Schuchardt , Simon Glass X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 20/22] expo: Always send keys to highlighted textline List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass Move textline key handling outside the loop so keys are always sent to the highlighted textline, regardless of whether it is open. This allows the textline to respond to keyboard input even if not in a popup expo. Otherwise continue to send keys to menus as now. Signed-off-by: Simon Glass --- boot/scene.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/boot/scene.c b/boot/scene.c index 1bcc3c39e33..5c19bff6011 100644 --- a/boot/scene.c +++ b/boot/scene.c @@ -1152,6 +1152,16 @@ int scene_send_key(struct scene *scn, int key, struct expo_action *event) return 0; } + if (cur && cur->type == SCENEOBJT_TEXTLINE) { + struct scene_obj_textline *tline; + + tline = (struct scene_obj_textline *)cur; + ret = scene_textline_send_key(scn, tline, key, event); + if (ret) + return log_msg_ret("key", ret); + return 0; + } + list_for_each_entry(obj, &scn->obj_head, sibling) { if (obj->type == SCENEOBJT_MENU) { struct scene_obj_menu *menu; @@ -1161,15 +1171,6 @@ int scene_send_key(struct scene *scn, int key, struct expo_action *event) if (ret) return log_msg_ret("key", ret); break; - } else if (!(obj->flags & SCENEOF_OPEN) && - obj->type == SCENEOBJT_TEXTLINE) { - struct scene_obj_textline *tline; - - tline = (struct scene_obj_textline *)obj; - ret = scene_textline_send_key(scn, tline, key, event); - if (ret) - return log_msg_ret("key", ret); - break; } }