diff mbox series

[Concept,14/22] test: cedit: Use UTF_NO_SILENT

Message ID 20251207201628.2882382-15-sjg@u-boot.org
State New
Headers
Series expo: Expand docs, dump and textlines in non-popup expos |

Commit Message

Simon Glass Dec. 7, 2025, 8:16 p.m. UTC 
  From: Simon Glass <simon.glass@canonical.com>

Use the UTF_NO_SILENT flag for cedit_render() instead of manually
calling ut_unsilence_console()/ut_silence_console(). This is makes it
more obvious that the test needs this handling.

Co-developed-by: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: Simon Glass <simon.glass@canonical.com>
---

 test/boot/cedit.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/test/boot/cedit.c b/test/boot/cedit.c
index 7af3dfa2338..c4d402343fa 100644
--- a/test/boot/cedit.c
+++ b/test/boot/cedit.c
@@ -352,11 +352,11 @@  static int cedit_render(struct unit_test_state *uts)
 	 * vidconsole state, outputs the character and then saves the state
 	 * again. If the character is never output, then the state won't be
 	 * updated and the textline will be inconsistent.
+	 *
+	 * This is why this test enables UTF_NO_SILENT
 	 */
-	ut_unsilence_console(uts);
 	for (i = 'a'; i < 'd'; i++)
 		ut_assertok(scene_send_key(scn, i, &evt));
-	ut_silence_console(uts);
 	ut_assertok(cedit_arange(exp, vid_priv, scn->id));
 	ut_assertok(expo_render(exp));
 	ut_asserteq(5076, video_compress_fb(uts, dev, false));
@@ -366,7 +366,7 @@  static int cedit_render(struct unit_test_state *uts)
 
 	return 0;
 }
-BOOTSTD_TEST(cedit_render, UTF_DM | UTF_SCAN_FDT);
+BOOTSTD_TEST(cedit_render, UTF_DM | UTF_SCAN_FDT | UTF_NO_SILENT);
 
 /* Check the cedit displays textlines correctly */
 static int cedit_render_textline(struct unit_test_state *uts)