| Message ID | 20251207201628.2882382-14-sjg@u-boot.org |
|---|---|
| State | New |
| Headers |
Return-Path: <concept-bounces+u-boot-concept=u-boot.org@u-boot.org> X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1765138666; bh=BcbSbTljHIf9g7YaO3tEqCPHKR2A98MY6Jl2rdlF90E=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=v9kik25fLVT6Iu6PH7Sw0VzMMb2U2mszF++zmg0fVVjXGglGky2KMMc+/EJlb2WX+ G6aIgTHilKBwYgplXq2qeSB95Phla4+0WIqEnCJuIDPEb/kJ7Dt/SjGf10BRBgVP1m aDgupBCqKlAENIkK9hIwe+xYr2Ya9S26Aw3sI0loShGxUsgNGkrcKOeapwT3TtEbOn PVo55FAWMqB9R8abzeFRUsO25Bc6gW5mA9ADphMtG12MA7HGZ2uhIb6z+5R9Wmt2a2 8i5Fb3JyYmGQkZOB/q4tnmRCtBbMxSbuEIm6j16msObTBzmp7JGev9ON5G/A62D+OH 29glZ/lkjkq+A== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 035E8689BE for <u-boot-concept@u-boot.org>; Sun, 7 Dec 2025 13:17:46 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 5FvnGgZHZIrP for <u-boot-concept@u-boot.org>; Sun, 7 Dec 2025 13:17:45 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1765138664; bh=BcbSbTljHIf9g7YaO3tEqCPHKR2A98MY6Jl2rdlF90E=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=fqAS94xSAOq4o+i/2dNk5pcrzuvXCTCCqXMo54g2kZKCk56dabrxpGdkIgCFMbw+j K5wNciMxFOkjXMY/mp2wNgJefEZx1/PZCcaRp4gi88MLvLA9mulUT0BNqkntkvAvKY fN38Y5g80FVpRrMu4JbUdXnLew5KFo2/PqeT/P8bh9ZHgyro29pEmROazExUJEI+qY oN92PVc6EJ18JCk0C6d+TRYcK/R/ZWy/wdqyqashDWv0NMN/LWf3jHDW7fMDWWt2Kq 3lehMD6RzfihWGzj/CuuI7BIGDoYIseCcUZRk0nd8lVJqtcD2iG/K9YyZi4pOZUXNA 6bvKhJnclqNLw== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 00C2668997 for <u-boot-concept@u-boot.org>; Sun, 7 Dec 2025 13:17:44 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1765138661; bh=0alUt2vli6TUugTyhbiujl7qGmiuWBMbskTpqY7lSAY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZI2TZoJ+MTXFQFM8aDm2zAKR1qN4ndswMck/mzF++Wgray7VifHf0IFz3ILOV/FfO 2I1udTUAjoZ+vM1TdRqvsHRfrsx24HqRxHv6n/yFJ6ChTCxI4l/VpopVIlvzFJIkef 8yjbsXDCcXKKYhXmY1YPWqd9lnmw07br93lUVGSggUTb6mxjWs7HePugGRMp9Uo4Sb hyIp8+rO9APXkq72Vtfnw4eubyQ2Tpl332YvI76O+D7kZmYQImMGhjc1zF2yVJjqaE UjOrO0htsrESvDtixvEoQTBeitrUN8LbetiBz77tG2Kbkw52nI+ODpSFJy55TNJ+c2 cI2cMRG8fP9/w== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 8687668950; Sun, 7 Dec 2025 13:17:41 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id CMonrM_o3RGi; Sun, 7 Dec 2025 13:17:41 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1765138661; bh=rU1dahAlU1STx9b0ja9OHc6hl3eIgJxNUcmN7DOpshM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X9R8wn568mBwWMKBRQ6rG7r+zNcckaQ1jk/UNLOUPhLBhCteGhDhOZ2SGJ3oScIQa ax+EBkw6NoEa2niiqIwOlGQuABLAM3BQFlxQwN9yYj++knvso5IdhmizEM1k4fsRYV BWxWZ5S3rZDFQ+7cjRA/9BJafbs2vOXsBteqKkCa27HQA0UFxdh13jSMxj4i0Aw560 BxxbAfWCj0yRu3cURFdtjXXzdlQY2P/JQviBuAyGa8nd0tE2hYFpY1VHPSdq6O5kKL 6O1p0sIbbAC1mKqNMS86uMuyGHPHX9poRhAz6QjG+0939ACPYG6bqyilWDN7SV/L0p 6CjXoldT7Qbew== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id E7D7268902; Sun, 7 Dec 2025 13:17:40 -0700 (MST) From: Simon Glass <sjg@u-boot.org> To: U-Boot Concept <concept@u-boot.org> Date: Sun, 7 Dec 2025 13:16:10 -0700 Message-ID: <20251207201628.2882382-14-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251207201628.2882382-1-sjg@u-boot.org> References: <20251207201628.2882382-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: RWRHWELTWX2STWZYDTQODICATGQL4AZJ X-Message-ID-Hash: RWRHWELTWX2STWZYDTQODICATGQL4AZJ X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Heinrich Schuchardt <xypron.glpk@gmx.de>, Simon Glass <simon.glass@canonical.com>, Claude <claude@anthropic.com> X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 13/22] expo: Fix textline edit text not updating in bootflow menu List-Id: Discussion and patches related to U-Boot Concept <concept.u-boot.org> Archived-At: <https://lists.u-boot.org/archives/list/concept@u-boot.org/message/RWRHWELTWX2STWZYDTQODICATGQL4AZJ/> List-Archive: <https://lists.u-boot.org/archives/list/concept@u-boot.org/> List-Help: <mailto:concept-request@u-boot.org?subject=help> List-Owner: <mailto:concept-owner@u-boot.org> List-Post: <mailto:concept@u-boot.org> List-Subscribe: <mailto:concept-join@u-boot.org> List-Unsubscribe: <mailto:concept-leave@u-boot.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit |
| Series |
expo: Expand docs, dump and textlines in non-popup expos
|
|
Commit Message
Simon Glass
Dec. 7, 2025, 8:16 p.m. UTC
From: Simon Glass <simon.glass@canonical.com> The edit text object for the passphrase textline is created with an empty string literal "", rather than pointing to the textline's buffer. This means that when the user types, tline->buf is updated but the text object still displays the original empty string. Fix this by creating the edit text object with abuf_data(&tline->buf) so it points to the textline's buffer. This matches how expo_build.c creates textlines for cedit. Co-developed-by: Claude <claude@anthropic.com> Signed-off-by: Simon Glass <simon.glass@canonical.com> --- boot/bootflow_menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/boot/bootflow_menu.c b/boot/bootflow_menu.c index 84ae0223ba0..ee3150afef4 100644 --- a/boot/bootflow_menu.c +++ b/boot/bootflow_menu.c @@ -308,7 +308,7 @@ int bootflow_menu_add(struct expo *exp, struct bootflow *bflow, int seq, snprintf(name, sizeof(name), "item%d.pass.edit", seq); ret = scene_txt_str(scn, name, ITEM_PASS_EDIT + seq, 0, - "", NULL); + abuf_data(&tline->buf), NULL); if (ret < 0) return log_msg_ret("ite", -EINVAL); tline->edit_id = ret;