From patchwork Mon Dec 1 17:05:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 798 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1764608957; bh=cu1ywqWt3SNx2h+ju7lXM7tQfk6urH7X/1vMGsiBn3g=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=FJEQo8PxoNBADP/OZGJMOvgpWVmxPb+0eIe2IkAv6fzkF6IsYIkTuSJMDwui5QI0P xJe9wbl8bZYwozM7e9cRcEf25EcfYf0Y9XWvlQS33snenL/l6wZ1itW4zmP03Au4HD SMDh+BiSsH0k56fjAkq72aIrlzrkLZmOqEE+V12NGsTO6hz0IRac55EvMM2DYf770u C7n+KcV2pddw1vmOeqdu4Ys90RrgYtLa82AhCYQSpRgb5HRjpmC6xVuLos+WwuS/sv P6JiKh1uWylE/dZKpBf4sGY2EiD467CxVprsOiwa/6lIEn1eBJjyOV8QJNLQGHjV7h bHaMER7C5XMKQ== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 49F5868821 for ; Mon, 1 Dec 2025 10:09:17 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id lY538m2fJc9E for ; Mon, 1 Dec 2025 10:09:17 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1764608955; bh=cu1ywqWt3SNx2h+ju7lXM7tQfk6urH7X/1vMGsiBn3g=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=D/UJz9FlvbJEIypfu32vpS8IhpUJsuJQ4E5uzupFAEcSf3XoOfgPZJXbHGhiI3HKb 8kMIpRS9RU3fmRBF48+BbmFDD2AUF/7LnUYVHpuiPFhq3yWBMU2W2QlM6KbcURR5tA QcLe0+IPJ9WDHEC6DLN26dLuSzJjMMoMcFZS9tG7VKZ3WheIty8bTfkzDXeLPiwVfo /SC7ChRwXwVYn3BAeP2Q/EcPdnlNAAKKe0PqWM/oSG5bkRIAEQ1ocxkbbtEg25LQ76 /MUeznfd5xnzuil8KXo6IADdvVJeDzz+O3+/wkKjwvz0urIWBNiXTmib4NrXJbElR6 Okj4y7GPMbAcQ== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id A4C1C6888B for ; Mon, 1 Dec 2025 10:09:15 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1764608952; bh=Xmrb21jB3W1e58jyaWy7/8Kf+7pime6nraB86asY1lM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fEaq0GGmO1Y+v2XVI71E2RFNTHUoIaH5W7xI0VlEp/eXaEaKRoDKoY+FD8LIOIdg7 tz7sTuWfAmryGDEVfEXI0R0mP//EGkwUGJ6aoSzBfnuIGFiGRmXjCKzGJg/906kDFA MqMAcKHUhlruruQzKSTMxlWRevrO795TBj3Ywqp+yGynDFcvitk1AtU8K54FWlujSi Yd2rG9jtoX15gA7HKHT4sUveYBa6bW5hHfPE2VWxJMrt9zqXsVFj6ZW4O2tPC5udjD 8WoAxIOWqr7MVgITHahNjnxbOzPNNW+W5yrg/eqG24DftqfbXFDA+DJPkx9mDKEIcy ZY8LTgaygrBUw== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id DFEDC688A4; Mon, 1 Dec 2025 10:09:12 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id iPAzbVaTO7o4; Mon, 1 Dec 2025 10:09:12 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1764608952; bh=3XDimvYdQFqamRIXlGgwe9RW4kbYXtvdKV+8N9mLtqk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bvEfiBw31N2GeX3KiM23umddcxWsXWQ3l0jtH5PF7sGShsbwRQhqRqjl7+zy+WNBl XzthJbro71QCGd/23q3qHI3QCN4yps+DnsEhCoQchnAOPzGSri/iOTQDR9/9p78EX6 txGJyFcxjDX7g9fmjQ+2WM8S3ZTNonvbd9jriU/PkiBtXoRJCUzHErj+GcFGemZuT0 xFBosJsudTmaW/Z3BTf0H7mrG2El8TW5vMKBeRonoMfesYx18UINRuNjhw03QWzL/7 k6uQzmNunKwLsMMlfryKSvAbjk1lHIbJWlYAub08jpgqPiHfFjnLN1kk+NyquCXlPm a/xBrVGEhaJMA== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id D185F6888B; Mon, 1 Dec 2025 10:09:11 -0700 (MST) From: Simon Glass To: U-Boot Concept Date: Mon, 1 Dec 2025 10:05:02 -0700 Message-ID: <20251201170529.3237986-24-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251201170529.3237986-1-sjg@u-boot.org> References: <20251201170529.3237986-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: GTF3M4Z6HLAM33GTQRTMR2FEQCZRLZV2 X-Message-ID-Hash: GTF3M4Z6HLAM33GTQRTMR2FEQCZRLZV2 X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Heinrich Schuchardt , Simon Glass , Eugene Uriev , Claude X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 23/37] mcheck: Use memset/memcpy instead of MALLOC_ZERO/MALLOC_COPY for mcheck. List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass These fast helpers sometimes breach mem-chunk boundaries. Thus they trigger mcheck alarm. Standard ones are accurate though. When MCHECK_HEAP_PROTECTION is enabled, redefine MALLOC_ZERO and MALLOC_COPY to use standard memset/memcpy instead of the optimized versions that may access memory outside allocated chunks. Signed-off-by: Eugene Uriev Co-developed-by: Claude Signed-off-by: Simon Glass (cherry picked from commit dfba071ddc3e609e61770b34ab0115fbce05edb2) --- common/dlmalloc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/common/dlmalloc.c b/common/dlmalloc.c index 972cadd2e2f..4f88e48f4b0 100644 --- a/common/dlmalloc.c +++ b/common/dlmalloc.c @@ -559,6 +559,10 @@ MAX_RELEASE_CHECK_RATE default: 4095 unless not HAVE_MMAP #ifdef MCHECK_HEAP_PROTECTION #define STATIC_IF_MCHECK static +#undef MALLOC_COPY +#undef MALLOC_ZERO +static inline void MALLOC_ZERO(void *p, size_t sz) { memset(p, 0, sz); } +static inline void MALLOC_COPY(void *dest, const void *src, size_t sz) { memcpy(dest, src, sz); } #else #define STATIC_IF_MCHECK #define dlmalloc_impl dlmalloc