diff mbox series

[Concept,13/30] fit: Drop showing an unused 'required' property

Message ID 20251120025614.2215587-14-sjg@u-boot.org
State New
Headers
Series fit: Improve and test the code to print FIT info |

Commit Message

Simon Glass Nov. 20, 2025, 2:55 a.m. UTC 
  From: Simon Glass <simon.glass@canonical.com>

This is actually not defined by the spec. The 'required' property is for
use by the verifying code. Having it in the FIT does not help size an
attacker could potentially remove it.

Signed-off-by: Simon Glass <simon.glass@canonical.com>
---

 boot/fit_print.c | 4 ----
 1 file changed, 4 deletions(-)
diff mbox series

Patch

diff --git a/boot/fit_print.c b/boot/fit_print.c
index 134625396bd..bea2e176f17 100644
--- a/boot/fit_print.c
+++ b/boot/fit_print.c
@@ -45,7 +45,6 @@  static void fit_image_print_data(const void *fit, int noffset, const char *p,
 	const char *keyname, *padding, *algo;
 	int value_len, ret, i;
 	uint8_t *value;
-	bool required;
 
 	debug("%s  %s node:    '%s'\n", p, type, fit_get_name(fit, noffset));
 	printf("%s  %s algo:    ", p, type);
@@ -55,11 +54,8 @@  static void fit_image_print_data(const void *fit, int noffset, const char *p,
 	}
 	printf("%s", algo);
 	keyname = fdt_getprop(fit, noffset, FIT_KEY_HINT, NULL);
-	required = fdt_getprop(fit, noffset, FIT_KEY_REQUIRED, NULL);
 	if (keyname)
 		printf(":%s", keyname);
-	if (required)
-		printf(" (required)");
 	printf("\n");
 
 	padding = fdt_getprop(fit, noffset, "padding", NULL);