| Message ID | 20251023094308.3406453-2-sjg@u-boot.org |
|---|---|
| State | New |
| Headers |
Return-Path: <concept-bounces+u-boot-concept=u-boot.org@u-boot.org> X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1761212621; bh=JPQ92QoKQc55mqHwGAQUbuYKWD9N5BjLqSQ9ExKKbhE=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=mBTz+WUZcK5Y7EG3fVgnz4YMwNZsJ+wxj+Rnm+6VU3DCmfJdCYlwWZ0aaEwEr2Ki2 F+3hf6d9TZsPUpk/fZdBUbk7OX8FRaVwNvlPP5LFDhppUFI46ix72DnUUouyOrT7sN Ivx2c3Zy5jyKOooeFD1kPUkpuQ3p3nX8NSsaNrqp7YFfQX/9Wp0MJEM7HMC9ZFa94E OnB76ELvFU5v8vWPINPc8tyEw71WB2ykV7idAQ+p1xv6O4XFESfJ3yV97rxGVY6bBV kx0GenqZpl1VAMfo2Jc3Jpf5TH6+NcDnS1IDPYk+BvSyx9x61c18bCWTiPYmMzJHP5 QmV1wfa2XC7EA== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id C92D568195 for <u-boot-concept@u-boot.org>; Thu, 23 Oct 2025 03:43:41 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id leoxcNgyZ43n for <u-boot-concept@u-boot.org>; Thu, 23 Oct 2025 03:43:41 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1761212620; bh=JPQ92QoKQc55mqHwGAQUbuYKWD9N5BjLqSQ9ExKKbhE=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=k6eUbuBDx5pJDWj9iYtLzsEtrJmUcmpSnhmJk/LCmfT/Ho7O5mNwg3GKVvZsjUU/M zO5DtYKfggSY+Xv5tOpWW0Yg+40F/P/KMUx9XbANngdGnaM4bQVWCu7OAOQ7Ozm4Ti zMicDMLKo/6S1QKrnPMgCPt2IfwYvCjByzJteF99V2kwudJugsGj71EDxSrqpEJ0Xn UbA6MZ/UbK1odpeEScYq1WvN3AaE4Fa228Md7bZ0aDVm+mPNSQapU7Qbt7+L/jA8Pn H1HrtwIKzvRIBBXYFyQ698CUTcQimPV4Ajk1jOi1LlDDpO0bDXDdTK88+AHMRh1KMx S/xq5pZqLnSoA== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id DDFCB68228 for <u-boot-concept@u-boot.org>; Thu, 23 Oct 2025 03:43:40 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1761212617; bh=E8mwumk74sgLp+5uN0MJCHAIFBLGPQ2pl7GVywqZwNM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I5DO6qJPfiYJAlk6lIZO/i4WeajMtoZLDSdp34iVSUVJyWmU936Tzrc+oBb0RYwC9 Wk29Ukx1WgV5vaiHCUgvh8LHgBZG+PNB2NJpY5r9Hzvvql4Gmc2nqtG4AHkpqH8EHt BlBhYD+LgQSL1QbBU33aC8NxsvmYU3SR8bEBrQmd4vplutLlRCtvQ21rCvbaHEiHsA dKpQrifyl9uvTvvZkDRZVXfGMX3aX4oWVAo6vyBC+0hm3QnXes1ryHPeMIWTDqEtx7 0KjByHVr564OO42tLifQrg2zOXuq2QLN1AOCIn8nHCUiYqDs30EjI0XEiQUDwQu9WR b/UKxPRbYZPiA== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 841CF68245; Thu, 23 Oct 2025 03:43:37 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id l2l37bbT9x7S; Thu, 23 Oct 2025 03:43:37 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1761212617; bh=H+TNFxGSfZnB4RjvDUojmOvrUv3O+2Cbb5gXLPP6XSw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RA2dW7yCHXTheLYHbiLp+OgHdVCg8qYY0xvnPxn2qxbbgYiWwvqrHO2QlluJoyA6v k/TwWuPsyIXmoY9eMw9iUODV6Uvbw6yftPbboM6C5iNjx7zdikR/GEQ+z8755DA47R SB9qpzy1qJQ+YneCFhvBc9DeEEPCNsnkisgBNczXXelMA6RWL8vr6E2vkcR2CAKgN6 1WrXbIHzeAuUzVID1rvmNP67nXf1596mhUDOCJ8Q0g4HQi4p7zO4DV5fKtkgVVEILq 4mZr1JSjogbiJFDpWMeyiVInXIfV9hxwzl7+uJTL02ICP4pKjm5x/VUjX/bl7iCFCQ DdRHg7aGF1J9Q== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id E6B5C6819C; Thu, 23 Oct 2025 03:43:36 -0600 (MDT) From: Simon Glass <sjg@u-boot.org> To: U-Boot Concept <concept@u-boot.org> Date: Thu, 23 Oct 2025 03:42:50 -0600 Message-ID: <20251023094308.3406453-2-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251023094308.3406453-1-sjg@u-boot.org> References: <20251023094308.3406453-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: UIDMYJA7NFXF7WSCIEEWCIL5FYWMZF7J X-Message-ID-Hash: UIDMYJA7NFXF7WSCIEEWCIL5FYWMZF7J X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Heinrich Schuchardt <xypron.glpk@gmx.de>, Simon Glass <sjg@chromium.org> X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 01/11] expo: Correct handling of mouse clicks List-Id: Discussion and patches related to U-Boot Concept <concept.u-boot.org> Archived-At: <https://lists.u-boot.org/archives/list/concept@u-boot.org/message/UIDMYJA7NFXF7WSCIEEWCIL5FYWMZF7J/> List-Archive: <https://lists.u-boot.org/archives/list/concept@u-boot.org/> List-Help: <mailto:concept-request@u-boot.org?subject=help> List-Owner: <mailto:concept-owner@u-boot.org> List-Post: <mailto:concept@u-boot.org> List-Subscribe: <mailto:concept-join@u-boot.org> List-Unsubscribe: <mailto:concept-leave@u-boot.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit |
| Series |
Bootstage and script enhancements
|
|
Commit Message
Simon Glass
Oct. 23, 2025, 9:42 a.m. UTC
From: Simon Glass <sjg@chromium.org> Due to a missing return in bootflow_menu_poll() a click on any object is handled as if it were a click on the settings object. Fix this by returning the correct error code for unrecognised clicks. Signed-off-by: Simon Glass <sjg@chromium.org> Fixes: e94de63e6c8 ("expo: Add a way to select settings") --- boot/bootflow_menu.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/boot/bootflow_menu.c b/boot/bootflow_menu.c index 26a2f559958..eda95428bf4 100644 --- a/boot/bootflow_menu.c +++ b/boot/bootflow_menu.c @@ -418,6 +418,7 @@ int bootflow_menu_poll(struct expo *exp, int *seqp) case EXPOACT_CLICK: if (act.select.id == OBJ_SETTINGS) return -ECOMM; /* layout change request */ + return -EAGAIN; case EXPOACT_SETTINGS: return -ECOMM; /* layout change request */ default: