diff mbox series

[Concept,13/24] bootctl: Avoid hanging on failure

Message ID	20251018084117.1798704-14-sjg@u-boot.org
State	New
Headers	From: Simon Glass <sjg@u-boot.org> To: U-Boot Concept <concept@u-boot.org> Date: Sat, 18 Oct 2025 02:40:58 -0600 Message-ID: <20251018084117.1798704-14-sjg@u-boot.org> In-Reply-To: <20251018084117.1798704-1-sjg@u-boot.org> References: <20251018084117.1798704-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: 2U5A5K7EX6JZXHNWV77QWBMSVS6H3NSU CC: Simon Glass <sjg@chromium.org> Precedence: list Subject: [Concept] [PATCH 13/24] bootctl: Avoid hanging on failure Archived-At: <https://lists.u-boot.org/archives/list/concept@u-boot.org/message/2U5A5K7EX6JZXHNWV77QWBMSVS6H3NSU/> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit
Series	bootctl: Expand bootctl to include a new UI \| [Concept,00/24] bootctl: Expand bootctl to include a new UI [Concept,01/24] test/py: Make test_bind_unbind_with_uclass() independent [Concept,02/24] test/py: Mark a few more tests as slow [Concept,03/24] bloblist: Add a name for the EFI log [Concept,04/24] bloblist: Provide a way to remove a blob [Concept,05/24] tpm: Correct address handling in tcg2_platform_get_log() [Concept,06/24] scripts: build-efi: Use a locally built OVMF image [Concept,07/24] boot: test: Add another Ubuntu image on mmc11 [Concept,08/24] boot: Allow switching back to another layout [Concept,09/24] test: Correct an incomplete sentence in prep_mmc_bootdev() [Concept,10/24] sandbox: Enable Ubuntu fonts [Concept,11/24] bootctl: Plumb in the feature [Concept,12/24] bootctl: Create a common struct for the BOOTCTL_UI uclass [Concept,13/24] bootctl: Avoid hanging on failure [Concept,14/24] bootctl: Provide an option to slow the display refresh [Concept,15/24] bootctl: Respect the autoboot option [Concept,16/24] bootctl: Re-apply the theme when showing the UI [Concept,17/24] bootctl: Bring in some additional images [Concept,18/24] bootctl: Add an option to switch the layout [Concept,19/24] bootctl: Provide a multi-themed UI [Concept,20/24] bootctl: Disable autoboot [Concept,21/24] bootctl: Add a test for the multi UI [Concept,22/24] efi: x86: Provide settings for bootctl [Concept,23/24] efi: x86: Enable required Kconfig options for bootctl [Concept,24/24] efi: x86: Use only serial for input

Commit Message

Simon Glass Oct. 18, 2025, 8:40 a.m. UTC

  From: Simon Glass <sjg@chromium.org>

For now just drop to the cmdline so that the state can be examined. This
will aid debugging.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 boot/bootctl/bootctl.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/boot/bootctl/bootctl.c b/boot/bootctl/bootctl.c
index 9fa943222db..7155ff0a8f0 100644
--- a/boot/bootctl/bootctl.c
+++ b/boot/bootctl/bootctl.c
@@ -58,7 +58,8 @@  int bootctl_run(void)
 		ret = bc_logic_poll(logic);
 		if (ret) {
 			printf("logic err %dE\n", ret);
-			hang();
+			/* could hang here */
+			return ret;
 		}
 	} while (ret != -ESHUTDOWN);