From patchwork Tue Oct 14 11:12:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 591 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org Authentication-Results: mail.u-boot.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=jq9x1I2a; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 3F30E66DD8 for ; Tue, 14 Oct 2025 05:13:46 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id hVQjuNume_0k for ; Tue, 14 Oct 2025 05:13:46 -0600 (MDT) Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 1076568146 for ; Tue, 14 Oct 2025 05:13:46 -0600 (MDT) Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id B69956811C for ; Tue, 14 Oct 2025 05:13:38 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id scspoyi300zt for ; Tue, 14 Oct 2025 05:13:38 -0600 (MDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.166.54; helo=mail-io1-f54.google.com; envelope-from=sjg@chromium.org; receiver=u-boot.org Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by mail.u-boot.org (Postfix) with ESMTPS id 3A1C168147 for ; Tue, 14 Oct 2025 05:13:37 -0600 (MDT) Received: by mail-io1-f54.google.com with SMTP id ca18e2360f4ac-93607aec358so88999839f.0 for ; Tue, 14 Oct 2025 04:13:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1760440416; x=1761045216; darn=u-boot.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+54P9w6/JL1N8AW+NgMQDnTdvVAKrVznrMO3pwHp85o=; b=jq9x1I2aIHf1MMsHnSwD1tcVsyKcrmhkFZlyWr1EeGXwjfN7MtWnVWX0VeB2+L2ZRp iXw6w4CfOqfkrOmMF294qIB3lan8L+hIuJBViLsNHifmKEOwOIhUuaOeHEM+wpMFwIHK J5/ZFMUvc4iVoUM1dm1j/KnqjECoRO+BxRcow= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760440416; x=1761045216; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+54P9w6/JL1N8AW+NgMQDnTdvVAKrVznrMO3pwHp85o=; b=KjxYUOEtOItJ/dwks8L3hxw/BgAHLIuirXp7B0fEvDEoWSzb7SX/1ISPgYyWFZRqX0 6UyoAzNpA9u3YKsfR4jXue2aKI5tmq/rP1fvfilaeucerAk0haxqwoIsWurnyILrNNdx GTglxErcS7/ATzmrY2Xlk014tWHKJUynwGvLsxzyrAZSfGl5wPNa3XdZteHvATPCO6CI Sfr7RhSGkO2KW/62Q+7Knn+Kxtqv9DHOTpIawBUNW9e6e/o/je0VsZf+L8JN2qa5lgci Ls1CU2ovzDoJr+pL61XqxYkW2iHnE5zzusCMDBXpBKk0F5Ixx1JEfJpy5GTwQeLHkSQV U+tA== X-Gm-Message-State: AOJu0YyMtnJg19z3G83sIS8BbxL4rZcnRBTwHOTC6KGAo3+Nkg+O/cI3 leUTqsWRNbWyFrOg8GveydtDJaSBWGsQgHN4bJl2nvJxSuvatLAanrMXL+3j3VANFIKVtFyTm9q lgAi3R/RZ0ig= X-Gm-Gg: ASbGncvLxde33rqiBJu6Rn6Hb2J2Q2570RZZjpApXucNZgbNEf6asX934bG18FC3J1M b+jm7HmwfDvQEl/2j3XexB+z9L3fzhzUOlY3HS56APbXIsjjE/l/s/eJSnWRwcEicE90lqKbWS3 eKTIsLo53Mokq3n1URACyY5xyRSPOxMAjniK2S8rjaDNy4FX5xy9sqVXxbCfIOobx+8SGJFPB/7 g9OtEcU95t1KbUUZkPGxsRJJa3MTSMad52XTr315I4ioZUAH6rOUGIJxrAQ5PbILSCXf0JqCPEL 1rGsq7+gVDtt4OPItbCIZVAOUXNU+vxRlttqgIPb8SixA3+7CjHnV5jRUAvQnKG0NidFEc+Jxfu Qu2MYyNdizmNf1KZhuMsK8Du0sQLipCA2E+/7LobM8/7KQg== X-Google-Smtp-Source: AGHT+IGMp8D7YyTb6jK3zVc7fQxpQY3L8LxX/g3EnCOyP7auWQ2IqVHAbxIzB8xMsE0jCPZn8s4KXg== X-Received: by 2002:a05:6e02:1529:b0:3f3:4562:ca92 with SMTP id e9e14a558f8ab-42f8736a83fmr275957205ab.10.1760440416016; Tue, 14 Oct 2025 04:13:36 -0700 (PDT) Received: from chromium.org ([73.34.74.121]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-430a3869174sm4608785ab.15.2025.10.14.04.13.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Oct 2025 04:13:34 -0700 (PDT) From: Simon Glass To: U-Boot Concept Date: Tue, 14 Oct 2025 05:12:44 -0600 Message-ID: <20251014111301.1059317-8-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251014111301.1059317-1-sjg@chromium.org> References: <20251014111301.1059317-1-sjg@chromium.org> MIME-Version: 1.0 Message-ID-Hash: 55GX42P5GD25TAW7TNM5C2R4I62YATNV X-Message-ID-Hash: 55GX42P5GD25TAW7TNM5C2R4I62YATNV X-MailFrom: sjg@chromium.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Glass X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 07/16] expo: Clarify that text objects are not string IDs List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Add a reminder in the struct comments that a text ID is not a string ID. Signed-off-by: Simon Glass --- include/expo.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/expo.h b/include/expo.h index 454889d5db9..2f32ff0aa72 100644 --- a/include/expo.h +++ b/include/expo.h @@ -444,7 +444,7 @@ struct scene_obj_txt { * - a preview object which shows an image related to the current item * * @obj: Basic object information - * @title_id: ID of the title text, or 0 if none + * @title_id: ID of the title text object (not string ID), or 0 if none * @cur_item_id: ID of the current menu item, or 0 if none * @pointer_id: ID of the object pointing to the current selection * @pointer_xofs: x position of pointer relative to the left side of the menu @@ -504,8 +504,8 @@ struct scene_menitem { * A textline has a prompt and a line of editable text * * @obj: Basic object information - * @label_id: ID of the label text, or 0 if none - * @edit_id: ID of the editable text + * @label_id: ID of the label text object (not string ID), or 0 if none + * @edit_id: ID of the editable text object (not string ID) * @max_chars: Maximum number of characters allowed * @buf: Text buffer containing current text * @pos: Cursor position