From patchwork Tue Oct 7 17:05:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 560 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1759856816; bh=IvGo6+1itjbg4zwb4TLuK8vJLjn5yEujf/QurPa6qpg=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=TLpriWWqA5Dol6xHPVpCyYEyRW+rD7bCMb4AO0w94DvD85zwPudoBAfGuqookSEH5 q4cTGTAG53gpVB+ABLe6SVfnWEmjs1T/bWbBsAWxqZGBHvIteFzrjWlaY6kYA2FtgM aT4iT+O/uNDM95jqAHdfo6g4k8iO3cO3sMZ06D4AMd+0UjvXGTycUUKDopg7jcL8/S u75H9C8AYq1oY8Hn+bX+qneXnABsAH9NJGh1Pp4WAYaWOGQ2OzaQZ1Frmrdvovshlj ikvhbKy8OdRSGOImHo4dY+1RENcWSdI31jZxRCWl4dMIeFn87CHuqW42YPJUYjJaVK s0tk37/5V5kpg== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 6AA5F67FF9 for ; Tue, 7 Oct 2025 11:06:56 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id OQn-WSUDKT5m for ; Tue, 7 Oct 2025 11:06:56 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1759856816; bh=IvGo6+1itjbg4zwb4TLuK8vJLjn5yEujf/QurPa6qpg=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=TLpriWWqA5Dol6xHPVpCyYEyRW+rD7bCMb4AO0w94DvD85zwPudoBAfGuqookSEH5 q4cTGTAG53gpVB+ABLe6SVfnWEmjs1T/bWbBsAWxqZGBHvIteFzrjWlaY6kYA2FtgM aT4iT+O/uNDM95jqAHdfo6g4k8iO3cO3sMZ06D4AMd+0UjvXGTycUUKDopg7jcL8/S u75H9C8AYq1oY8Hn+bX+qneXnABsAH9NJGh1Pp4WAYaWOGQ2OzaQZ1Frmrdvovshlj ikvhbKy8OdRSGOImHo4dY+1RENcWSdI31jZxRCWl4dMIeFn87CHuqW42YPJUYjJaVK s0tk37/5V5kpg== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 586DE67F6C for ; Tue, 7 Oct 2025 11:06:56 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1759856813; bh=qnAyHJ5NSEzvoV5kpiMc0RZOmdCWxM4h4jZSdkS9xAQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nIyJxhr1z4+i5HUoa8baj/DsTQEdPMnErUwZaov8OZSBd1aqBAMPAT0yVUfs8VwQE nRxIHOYQFH7spkFPNID89KgQG040uF7M02rjwNb/Ek9dFIOoxBM4VbMFbeBSWmFjz1 0Ag6z9qTJ43Qk5pPleav80DhSHQpR2mwn0uqnaPkN9fi+bmVJh2jC0HeBfaMBHl9iM E0WyEVDYCIyW/0ZcBekIAurM8kHtu0v2e3wA8mPDe1gIcpZBIIUEGKJPTg7AGgJ0qS Pzrzs2q6xB/nyQjyU64GRztTb7GH4VuOA/zsA+2FE3xbIeaADBWIU4Y8ww7tJyAbFM hmmWvensfnKWQ== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id C19C767F6C; Tue, 7 Oct 2025 11:06:53 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id vqQD7gwTp1lW; Tue, 7 Oct 2025 11:06:53 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1759856809; bh=kR98mObumL/pt2cVITUuzMEuzmj54I7PQtYm/MMIyy4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vj5DuAgNW6GNgh4JK4tTMFSoxRpNnzWYmB5lKP2vz2GvPoQKxLXyJOAe6IAjTMgc5 iHefFj7hQ/nPwinPSgOfT7gSPnC0PC4z4UTfQHi79uaMlHv1w4aGhmRhFiU9ug7mih nDjlXiHibO+Zou5Uqj4zKQsVnIe/SUxlqyaiQ5QyWNAZ9tOKw2UoQuVfT+GE81hJo2 5pWnZhEjvnCFaitxHprGOgUoWemj+ginQj979wUmb96wVyNReA60lw5QPNCnq/xMwL h9c5n9lmtz4JIkYjbqb9zo3LTFY4p5yh6ky+DQeYRQnivtdceSdzdanY5wHrCknHmv k/w31TzM/YoGw== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id D907367EE5; Tue, 7 Oct 2025 11:06:48 -0600 (MDT) From: Simon Glass To: U-Boot Concept Date: Tue, 7 Oct 2025 11:05:28 -0600 Message-ID: <20251007170549.541981-15-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251007170549.541981-1-sjg@u-boot.org> References: <20251007170549.541981-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: RSKNQZ35WCXXNLUIVOI62QBH72FH7GRY X-Message-ID-Hash: RSKNQZ35WCXXNLUIVOI62QBH72FH7GRY X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Heinrich Schuchardt , Simon Glass X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH v2 14/20] efi: video: Add some more debugging for the modes List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass This driver can operate in various modes, e.g. with VIDEO_COPY and with different colour depths or in blit mode. Add some debugging to help debug problems on particular boards. Fix an errant blank line while we are here. Signed-off-by: Simon Glass --- (no changes since v1) drivers/video/efi.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/video/efi.c b/drivers/video/efi.c index b5e472395e9..bfa367cc7ea 100644 --- a/drivers/video/efi.c +++ b/drivers/video/efi.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include @@ -60,6 +61,10 @@ static int efi_video_sync(struct udevice *dev, uint flags) return -EIO; } } + /* + * When use_blit is false and CONFIG_VIDEO_COPY is enabled, + * video_manual_sync() handles copying to copy_fb + */ return 0; } @@ -252,7 +257,9 @@ static int efi_video_probe(struct udevice *dev) goto err; printf("Video: %dx%dx%d @ %lx\n", uc_priv->xsize, uc_priv->ysize, - vesa->bits_per_pixel, (ulong)priv->fb); + vesa->bits_per_pixel, (ulong)uc_priv->fb); + log_debug("use_blit %d, copy_base %lx, copy_fb %p\n", priv->use_blit, + (ulong)plat->copy_base, uc_priv->copy_fb); return 0; @@ -267,7 +274,6 @@ static int efi_video_bind(struct udevice *dev) { struct video_uc_plat *plat = dev_get_uclass_plat(dev); struct efi_video_priv tmp_priv; - struct vesa_mode_info vesa; int ret; @@ -282,10 +288,13 @@ static int efi_video_bind(struct udevice *dev) /* this is not reached if the EFI call failed */ plat->copy_size = vesa.bytes_per_scanline * vesa.y_resolution; + log_debug("copy size %lx\n", plat->copy_size); } } - if (tmp_priv.use_blit) + if (tmp_priv.use_blit) { plat->size = vesa.bytes_per_scanline * vesa.y_resolution; + log_debug("plat size %x\n", plat->size); + } return 0; }