From patchwork Mon Oct 6 23:21:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 541 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1759793015; bh=VtKObF0kiixMSOP4q/bkSwW/Sqw+H9U0fHz+COFU01I=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=vkp4n3L3IMws6TPORj+lGnCVjxJBiQoeRO5WPh2UjISrUabV/UyZ9R3jTqQzIiWXh hCwnUG/7SSP7Y6k9DOx4PqBjkHz7AOcu+IuRtTyuXPyQ31b47wZDgnyd6N/40fX6mk LZeBJdmKhUjWeI0ctsKFxzP6jWadPPR3L+q61852yw8IRAgqcsWI0emuLu0j6oMXNx ToDdKjuYZdPYLFZjxkCa6y+fjv1SpstLVM9xnCUA1I11zQZxRjINbTrW8QeZqK9fy5 iBzTvVAWA6lnRszgegnypE0Q3zWayu7Ln+bLLDmlv0My/CAxM1gTRfytzP3in4NDij TfBRRKoSuDRxg== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 2C13F67FC6 for ; Mon, 6 Oct 2025 17:23:35 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id v10kHJ8sDMYY for ; Mon, 6 Oct 2025 17:23:35 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1759793015; bh=VtKObF0kiixMSOP4q/bkSwW/Sqw+H9U0fHz+COFU01I=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=vkp4n3L3IMws6TPORj+lGnCVjxJBiQoeRO5WPh2UjISrUabV/UyZ9R3jTqQzIiWXh hCwnUG/7SSP7Y6k9DOx4PqBjkHz7AOcu+IuRtTyuXPyQ31b47wZDgnyd6N/40fX6mk LZeBJdmKhUjWeI0ctsKFxzP6jWadPPR3L+q61852yw8IRAgqcsWI0emuLu0j6oMXNx ToDdKjuYZdPYLFZjxkCa6y+fjv1SpstLVM9xnCUA1I11zQZxRjINbTrW8QeZqK9fy5 iBzTvVAWA6lnRszgegnypE0Q3zWayu7Ln+bLLDmlv0My/CAxM1gTRfytzP3in4NDij TfBRRKoSuDRxg== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 178D667F5A for ; Mon, 6 Oct 2025 17:23:35 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1759793012; bh=iYUAaFlPwrXp/2vWapmZLUA3dmKIqFJG5OYRIp4Lits=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j0F1vpSqB+SPsIRLC6eSaiWzPehtyD6mhZESqwleVK8q5MY6hObLkXWir0q+1a6Py rWwMVSgzqXlDJAoTu9OqYKna1Jck1VGNw3Il7YVkLZ03qSKG0mtuSc2v+SLPLJXrwJ L5HfuvYffgxVuoW90ZxLYu/pZEq0g3/wG+w/ihLH/YwokLdw2zTUuTqbuwcYFC6V3Q wtxVU+ijR9KyCHRLBNwXZImWYiUuoa9RIT+K5WZJ7uL61oIvUpmcxbgzKhSfz0Qu65 s5JiD2KQLGLJiB92VlcoTe2B07NdyZn6GRR+Wluibb3yBVwzNV6Gh7kQ4KvTAqa5uQ 3osFsd+ZNqKhw== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id A97D167F58; Mon, 6 Oct 2025 17:23:32 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id kxA1djFfWLHk; Mon, 6 Oct 2025 17:23:32 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1759793007; bh=atIHsOMy5iKoaN/k3OvhNCuERYHffTW470pmAkWAbtY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WXKLMtJ66p6yYZOkrZR5m7A9NzhKLle8zRBjITII5Y/esOUjwf9az8vvZTck+bLuN zP+AMXC5zo8AuoLzGtrWd3Gks68kazMDlUkU98Oy9P0GpdNtj3gCi/6ZjyGdNDm7li a9EJwo6HGoghqEq6zX5XlI2nwavGh4ZabZxKCvWZb5Cd94aRfl1sNtgmOSWeSqvZMO L4gI79wRFv0i3SXe45qkvp1lU1ZQG5ikUHVfsFFs7WwzC8mPDJ4EfOhCJ4wVJhlzDc V7dHytYEip+gr0zXL36G4EmnFE6pOjfSALyqeiZ95IBeE1O0a5fkBuQd1aPGus7aLu vfJOOx65QRB9Q== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 6108567F3F; Mon, 6 Oct 2025 17:23:27 -0600 (MDT) From: Simon Glass To: U-Boot Concept Date: Mon, 6 Oct 2025 17:21:53 -0600 Message-ID: <20251006232236.2091941-12-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251006232236.2091941-1-sjg@u-boot.org> References: <20251006232236.2091941-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: FYZR2243I7UAYNHL35V5EUKORDXQZMZA X-Message-ID-Hash: FYZR2243I7UAYNHL35V5EUKORDXQZMZA X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Heinrich Schuchardt , Simon Glass X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 11/17] efi: video: Add some more debugging for the modes List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass This driver can operate in various modes, e.g. with VIDEO_COPY and with different colour depths or in blit mode. Add some debugging to help debug problems on particular boards. Fix an errant blank line while we are here. Signed-off-by: Simon Glass --- drivers/video/efi.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/video/efi.c b/drivers/video/efi.c index b5e472395e9..bfa367cc7ea 100644 --- a/drivers/video/efi.c +++ b/drivers/video/efi.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include @@ -60,6 +61,10 @@ static int efi_video_sync(struct udevice *dev, uint flags) return -EIO; } } + /* + * When use_blit is false and CONFIG_VIDEO_COPY is enabled, + * video_manual_sync() handles copying to copy_fb + */ return 0; } @@ -252,7 +257,9 @@ static int efi_video_probe(struct udevice *dev) goto err; printf("Video: %dx%dx%d @ %lx\n", uc_priv->xsize, uc_priv->ysize, - vesa->bits_per_pixel, (ulong)priv->fb); + vesa->bits_per_pixel, (ulong)uc_priv->fb); + log_debug("use_blit %d, copy_base %lx, copy_fb %p\n", priv->use_blit, + (ulong)plat->copy_base, uc_priv->copy_fb); return 0; @@ -267,7 +274,6 @@ static int efi_video_bind(struct udevice *dev) { struct video_uc_plat *plat = dev_get_uclass_plat(dev); struct efi_video_priv tmp_priv; - struct vesa_mode_info vesa; int ret; @@ -282,10 +288,13 @@ static int efi_video_bind(struct udevice *dev) /* this is not reached if the EFI call failed */ plat->copy_size = vesa.bytes_per_scanline * vesa.y_resolution; + log_debug("copy size %lx\n", plat->copy_size); } } - if (tmp_priv.use_blit) + if (tmp_priv.use_blit) { plat->size = vesa.bytes_per_scanline * vesa.y_resolution; + log_debug("plat size %x\n", plat->size); + } return 0; }