From patchwork Thu Sep 25 17:47:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 428 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1758822549; bh=nHNALKuscAUiVTrFsTNOAOVnDSM6VmVMzqulYDMwGVA=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=DtO6QORYYOKideXeOZzrmGTVouHeEBlxkniL44L5d+lrlKN0og6HGHkz3JgLxB6WF ZxGZ5XjW+FXGwJulwNWcTc+LwGBkRHkgZKEIrUPHd9A172/j2evuWBZWnCkSR5T7Pb MEqyRkeKaOgpDDGWEYdf4oxVD/HEAjuvFhFt/4mlF4iu0RqEpKfmbb4Na9Yr747q6L 6b472NlyabEDChzZWR0yuAxXx7RXTiU0dn2E7WsiEIuHwNiFT6ZGV/7FAq2GMxDH57 LTkmFcq/NGpkXd1ertq81KXIgf3i3JKJZWfErr4nMPYdwgVCd12Ag40tJpnGSPcvSX oZQyljCvvWTnA== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id B24D667CA2 for ; Thu, 25 Sep 2025 11:49:09 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id x7oSDfSPY5n7 for ; Thu, 25 Sep 2025 11:49:09 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1758822549; bh=nHNALKuscAUiVTrFsTNOAOVnDSM6VmVMzqulYDMwGVA=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=DtO6QORYYOKideXeOZzrmGTVouHeEBlxkniL44L5d+lrlKN0og6HGHkz3JgLxB6WF ZxGZ5XjW+FXGwJulwNWcTc+LwGBkRHkgZKEIrUPHd9A172/j2evuWBZWnCkSR5T7Pb MEqyRkeKaOgpDDGWEYdf4oxVD/HEAjuvFhFt/4mlF4iu0RqEpKfmbb4Na9Yr747q6L 6b472NlyabEDChzZWR0yuAxXx7RXTiU0dn2E7WsiEIuHwNiFT6ZGV/7FAq2GMxDH57 LTkmFcq/NGpkXd1ertq81KXIgf3i3JKJZWfErr4nMPYdwgVCd12Ag40tJpnGSPcvSX oZQyljCvvWTnA== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 9D07167D76 for ; Thu, 25 Sep 2025 11:49:09 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1758822547; bh=2/m5lbDEPcEAeUU7GBcswH6PA1/ht65UuwZpTB4lIHM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gQpXxmvE9FlwsL62pM0bbSX+VWpH7GbwqT6ltRgpSA0QATPuOJrfzxbCFGC1Ejbwo fweuNQWaWhFNl0L+6uUs8kABrvGnv6qQTBfDPFYHPrumHqQaIRObT+oJUKCgVgG9nn 57FtIC0sib9GwYYt16gNdGPXrX8M27dAe7GXCzfa4BvYxW51F2DQ4wiysMWZy7Em+X Mb1t56nBJwkPHCHHodTfVRLV4BEF1j5Uc/09Qa3KsTT2jrhj1ksU9e0cJE4NxXYqXt Q1u7pORK6TuQ81eRtC3+cqJ7tv/ssrYqlLKrCNFrH3gNUnWgMXIsTvtZc564A7KUPc vALqs5ZdPv5Mg== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id E266967CA2; Thu, 25 Sep 2025 11:49:07 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id HYbLciJ11Gwm; Thu, 25 Sep 2025 11:49:07 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1758822542; bh=aoKBYNwo/CEx09JDNtup4l/lr68iy8DlcXDIU9RyAX4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aYi3seaBXA5vsMecgD6yTSvUEFkc6ggcyB5lTaBDyyhDwYjU8JBZgqAPMWdiiZU82 NgpKdIXqig8dckeWFHAEVK5/9tV3P50E9vBBt7vhf8aLtcoFgDdXO4frbzk2448iZE 1EbR5VimDbRyPVQOma+1Wa/feiWZzyOaUBYPJD3FZ/wFN9kzehwifVdtxxmlkrpcx+ iP6eAa1XoYmlrqRROstQup3GQV/cFgLRbi3Lk8yrkMAzXsAlJsXB2gPTOAugTlrG+w nRAWTuxgyUpIRsAhjsACU0pOzoiqCF8mxVw2vq9jsp0c2j/+37XNFm2HKuwWIaC2kv jS6rPz83zSwyg== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 4880D67C2B; Thu, 25 Sep 2025 11:49:02 -0600 (MDT) From: Simon Glass To: U-Boot Concept Date: Thu, 25 Sep 2025 11:47:40 -0600 Message-ID: <20250925174753.3429102-17-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250925174753.3429102-1-sjg@u-boot.org> References: <20250925174753.3429102-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: DT4ASABRYJHYS3YYBNG4WT7R2NQYFUUS X-Message-ID-Hash: DT4ASABRYJHYS3YYBNG4WT7R2NQYFUUS X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Heinrich Schuchardt , Simon Glass X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 16/22] boot: Tidy up positioning in bootflow_menu_new() List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass Several items use the SCENEOB_DISPLAY_MAX setting which does not work with alignment. Some others have a negative height, which is now checked, so results in the item being invisible. Fix these problems. Signed-off-by: Simon Glass --- boot/bootflow_menu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/boot/bootflow_menu.c b/boot/bootflow_menu.c index 602a2e33c88..3365b5c3b06 100644 --- a/boot/bootflow_menu.c +++ b/boot/bootflow_menu.c @@ -67,7 +67,7 @@ int bootflow_menu_new(struct expo **expp) ret |= scene_txt_str(scn, "title", OBJ_MENU_TITLE, STR_MENU_TITLE, "U-Boot - Boot Menu", NULL); ret |= scene_obj_set_bbox(scn, OBJ_MENU_TITLE, 0, 32, - SCENEOB_DISPLAY_MAX, 30); + 1366, 60); ret |= scene_obj_set_halign(scn, OBJ_MENU_TITLE, SCENEOA_CENTRE); logo = video_get_u_boot_logo(NULL); @@ -90,13 +90,13 @@ int bootflow_menu_new(struct expo **expp) "The highlighted entry will be executed automatically in %ds.", NULL); ret |= scene_obj_set_bbox(scn, OBJ_PROMPT1A, 0, 590, - SCENEOB_DISPLAY_MAX, 30); + 1366, 590 + 40); ret |= scene_obj_set_bbox(scn, OBJ_PROMPT1B, 0, 620, - SCENEOB_DISPLAY_MAX, 30); + 1366, 620 + 40); ret |= scene_obj_set_bbox(scn, OBJ_PROMPT2, 100, 650, 1366 - 100, 700); ret |= scene_obj_set_bbox(scn, OBJ_AUTOBOOT, 0, 720, - SCENEOB_DISPLAY_MAX, 750); + 1366, 750); ret |= scene_obj_set_halign(scn, OBJ_PROMPT1A, SCENEOA_CENTRE); ret |= scene_obj_set_halign(scn, OBJ_PROMPT1B, SCENEOA_CENTRE); ret |= scene_obj_set_halign(scn, OBJ_PROMPT2, SCENEOA_CENTRE);