From patchwork Fri Sep 19 20:14:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 348 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1758312954; bh=qjpkIsM7cwzRDSQemDalt8cImFeQDSPHx8b42YPDZiw=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=sRE+rNt9Ajfekqo+liDVexbsUNEmqKO1KLPrqyd6yck6suIUcA3/lxuuZimZocidQ uvgIFrvi1IVzAd1Hx1I4PWcdyEEy7WIaTCvDhxi+a3ekHY7nJkjJ7k0RemxHW+IKO0 l1tHc0Plbmtpg7ZDVqP1CZ18tyTlwhspcxtnORpvt2lSGeOKoZwjXzigWAFYCpBiwZ ZJG9BABSoEm+RMIEIEckpMPFet6P2kcYOuIUXtgwSTQqriGDaPLULFtyVVqLOFXC/B ENYe8+3fGxYSwuiU7Yhh39CQrYcLQ8qJl3KjFZ6QmcEsKng519inROD/4TvzNrCw7X dH8NzhJEn7Kmw== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id A18BC67C6D for ; Fri, 19 Sep 2025 14:15:54 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id UJBpa29gTiv0 for ; Fri, 19 Sep 2025 14:15:54 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1758312954; bh=qjpkIsM7cwzRDSQemDalt8cImFeQDSPHx8b42YPDZiw=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=sRE+rNt9Ajfekqo+liDVexbsUNEmqKO1KLPrqyd6yck6suIUcA3/lxuuZimZocidQ uvgIFrvi1IVzAd1Hx1I4PWcdyEEy7WIaTCvDhxi+a3ekHY7nJkjJ7k0RemxHW+IKO0 l1tHc0Plbmtpg7ZDVqP1CZ18tyTlwhspcxtnORpvt2lSGeOKoZwjXzigWAFYCpBiwZ ZJG9BABSoEm+RMIEIEckpMPFet6P2kcYOuIUXtgwSTQqriGDaPLULFtyVVqLOFXC/B ENYe8+3fGxYSwuiU7Yhh39CQrYcLQ8qJl3KjFZ6QmcEsKng519inROD/4TvzNrCw7X dH8NzhJEn7Kmw== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 0C96C67C58 for ; Fri, 19 Sep 2025 14:15:54 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1758312952; bh=LutC6i8f4Pv+i4s0MMl/pAimaQo4P0+6cc+ZDMaIZ1A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jByJrj/QNuDKXz37fcTnNFrZrv3QHL3nMzRMbTQ0JrkilWU4vbZSMer3r+hV2dByg z9J6aq5oGllaEykoPwKVGJ5nwcnJTq8h+hXQPw4j6q6eZk9WUZ26WADe/dJER/cTKR uojki1MJzZC3UPyP1kHtFWqZhZePjmsXxQZ7W3b+IM+9dfPE5vjLk1GWtPJ14hDX6X +Bw5lYJzIcVNbI8bMAy8hyj45dXuQv64meS2Dgvto2MyNbDfGS0EEsq8YHWrLQVi0A 7Z6HKTC/9UbAaOHHZJZIKpO35b/Gu1ViR5K/8UAHnyWEKt7lnLdo7w2PC3TOKAfAXP kGaGi86Lgt77A== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 58AD367C6D; Fri, 19 Sep 2025 14:15:52 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id xma0omgyWbhJ; Fri, 19 Sep 2025 14:15:52 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1758312950; bh=g691agaAVXYD9pERJ9oFxSlRzQrj7huTlCXT1ApI6k4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SLOCmNT0C/vCKi4l4k9k5D27ECoL0Fz7r8eTuQVRiBgX2evYQPxUgyTeJHZNRHGUZ 70tCxEXp04YkZ2kar25AgWAGpwaYKLJ+y6gnX4rxY0bidLVOPkulHkYz0a03LhGmq3 r3VHqqWWhh3nkgN7s4t4EOdP8yHlNaIdBWEHUmuXzMIoWdcGCpkn3F7PCphbx0v/VQ tdDbM5igJGwyFecF5ifukKPNF+1+7OP3J1XtZJ/U08c4/ecDr5NL6WgTd8eUfBgFWM R4y8oimDBcpVydFr+lqOzmJPe17CxlgKaZDZRDsTcyAuibC2jKtz09xB8VcWlixozM i159dhJizjXgQ== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 4820D67C71; Fri, 19 Sep 2025 14:15:50 -0600 (MDT) From: Simon Glass To: U-Boot Concept Date: Fri, 19 Sep 2025 14:14:13 -0600 Message-ID: <20250919201507.4024144-7-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250919201507.4024144-1-sjg@u-boot.org> References: <20250919201507.4024144-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: LXRDEJKIBHPIATZPVPEOXOFZ7IQQQ4WP X-Message-ID-Hash: LXRDEJKIBHPIATZPVPEOXOFZ7IQQQ4WP X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Heinrich Schuchardt , Simon Glass , Claude X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 06/42] test: video: Split long strings List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass Some strings in this file are quite long and it is a pain to look at them within an 80-column editor. Split them. Co-developed-by: Claude Signed-off-by: Simon Glass --- test/dm/video.c | 31 +++++++++++++++++++++++++------ 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/test/dm/video.c b/test/dm/video.c index 513134dd445..a48d0c0411c 100644 --- a/test/dm/video.c +++ b/test/dm/video.c @@ -229,7 +229,8 @@ DM_TEST(dm_test_video_text_12x22, UTF_SCAN_PDATA | UTF_SCAN_FDT); static int dm_test_video_chars(struct unit_test_state *uts) { struct udevice *dev, *con; - const char *test_string = "Well\b\b\b\bxhe is\r \n\ta very \amodest \bman\n\t\tand Has much to\b\bto be modest about."; + const char *test_string = "Well\b\b\b\bxhe is\r \n\ta very \amodest " + "\bman\n\t\tand Has much to\b\bto be modest about."; ut_assertok(select_vidconsole(uts, "vidconsole0")); ut_assertok(video_get_nologo(uts, &dev)); @@ -581,7 +582,13 @@ DM_TEST(dm_test_video_comp_bmp8, UTF_SCAN_PDATA | UTF_SCAN_FDT); static int dm_test_video_truetype(struct unit_test_state *uts) { struct udevice *dev, *con; - const char *test_string = "Criticism may not be agreeable, but it is necessary. It fulfils the same function as pain in the human body. It calls attention to an unhealthy state of things. Some see private enterprise as a predatory target to be shot, others as a cow to be milked, but few are those who see it as a sturdy horse pulling the wagon. The \aprice OF\b\bof greatness\n\tis responsibility.\n\nBye"; + const char *test_string = "Criticism may not be agreeable, but it " + "is necessary. It fulfils the same function as pain in the " + "human body. It calls attention to an unhealthy state of " + "things. Some see private enterprise as a predatory target to " + "be shot, others as a cow to be milked, but few are those who " + "see it as a sturdy horse pulling the wagon. The \aprice " + "OF\b\bof greatness\n\tis responsibility.\n\nBye"; ut_assertok(video_get_nologo(uts, &dev)); ut_assertok(uclass_get_device(UCLASS_VIDEO_CONSOLE, 0, &con)); @@ -599,7 +606,13 @@ static int dm_test_video_truetype_scroll(struct unit_test_state *uts) { struct sandbox_sdl_plat *plat; struct udevice *dev, *con; - const char *test_string = "Criticism may not be agreeable, but it is necessary. It fulfils the same function as pain in the human body. It calls attention to an unhealthy state of things. Some see private enterprise as a predatory target to be shot, others as a cow to be milked, but few are those who see it as a sturdy horse pulling the wagon. The \aprice OF\b\bof greatness\n\tis responsibility.\n\nBye"; + const char *test_string = "Criticism may not be agreeable, but it " + "is necessary. It fulfils the same function as pain in the " + "human body. It calls attention to an unhealthy state of " + "things. Some see private enterprise as a predatory target to " + "be shot, others as a cow to be milked, but few are those who " + "see it as a sturdy horse pulling the wagon. The \aprice " + "OF\b\bof greatness\n\tis responsibility.\n\nBye"; ut_assertok(uclass_find_device(UCLASS_VIDEO, 0, &dev)); ut_assert(!device_active(dev)); @@ -621,7 +634,11 @@ static int dm_test_video_truetype_bs(struct unit_test_state *uts) { struct sandbox_sdl_plat *plat; struct udevice *dev, *con; - const char *test_string = "...Criticism may or may\b\b\b\b\b\bnot be agreeable, but seldom it is necessary\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\bit is necessary. It fulfils the same function as pain in the human body. It calls attention to an unhealthy state of things."; + const char *test_string = "...Criticism may or may\b\b\b\b\b\bnot be " + "agreeable, but seldom it is necessary\b\b\b\b\b\b\b\b\b\b\b\b" + "\b\b\b\b\b\b\b\b\b\bit is necessary. It fulfils the same " + "function as pain in the human body. It calls attention to an " + "unhealthy state of things."; ut_assertok(uclass_find_device(UCLASS_VIDEO, 0, &dev)); ut_assert(!device_active(dev)); @@ -645,7 +662,8 @@ static int dm_test_video_copy(struct unit_test_state *uts) struct video_uc_plat *uc_plat; struct udevice *dev, *con; struct video_priv *priv; - const char *test_string = "\n\tCriticism may not be agreeable, but it is necessary.\t"; + const char *test_string = "\n\tCriticism may not be agreeable, but it " + "is necessary.\t"; ulong addr; if (!IS_ENABLED(CONFIG_VIDEO_COPY)) @@ -710,7 +728,8 @@ static int dm_test_video_damage(struct unit_test_state *uts) struct video_priv *priv; const char *test_string_1 = "Criticism may not be agreeable, "; const char *test_string_2 = "but it is necessary."; - const char *test_string_3 = "It fulfils the same function as pain in the human body."; + const char *test_string_3 = "It fulfils the same function as pain in " + "the human body."; if (!IS_ENABLED(CONFIG_VIDEO_DAMAGE)) return -EAGAIN;