| Message ID | 20250919201507.4024144-4-sjg@u-boot.org |
|---|---|
| State | New |
| Headers |
Return-Path: <concept-bounces+u-boot-concept=u-boot.org@u-boot.org> X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1758312946; bh=X7fPB9lBnWNySqRZkZAppJDDjTNmrlLmFnw5PrrJM6M=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=S7+WmAJ8/hYcjRv2YK2y/4n7ZHeozr8woAPxpY5sFhnZ/6BZCyuMRDdIslq3/TTZY 7yIKI1Dm9++dOrE5SL5pUKWihEpGP00LqgGW1BMaYuwHKdznLP/xkfHZb8Y8Uhfy95 dD2/kGU929WvnHvgyrX1B31gCkFZINpFLAyjhxr7yHDQG5dyj6OL3Kd4WRnDyUgEgQ TSCZQDV54w/0m2s9unWt8h2tJrBR+jbxm/3QMxtJfKTPVp2A+Eux20o6ihSSIuETuU /IfnK4c5WxNOmg8+Tj5RGP8GMHteamgVvE0bknu0/Xgc/qnX8aaD3Jpbsschnu2skJ YaORnl45e9+xA== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id A5F8267BFC for <u-boot-concept@u-boot.org>; Fri, 19 Sep 2025 14:15:46 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 4YY8M1fa7n4L for <u-boot-concept@u-boot.org>; Fri, 19 Sep 2025 14:15:46 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1758312944; bh=X7fPB9lBnWNySqRZkZAppJDDjTNmrlLmFnw5PrrJM6M=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=IeJHkgl3nKNw6PJWN/CMO/zDcfLzScCwfTioCRc7oXAi0u7c5iPM14FWp1UQwcUu7 8UBJ2GvEpiEw1QQ2meoFXkooXthZe5rgU6g0UZRc/E+Ne+jrnhg4KIpaI27xxzDpQ9 zKQVfXe/P5HI5TTLVFCk655kv5AqjHnAS4kpN9o2GjPmuwkTe08G5vA+1srzge/EzJ 0AmN3sxXFlpbj2dolkzMcykYONvfE25EQnYWFxRCpE6zMniMqMopHqlv0jtS9bAKCH IerDSaibUjBPPpcAOPyQtmmyGWMkNez0hODTTLs4Eo4bCxaClYZDN7MH+iPABsPWoj /SnNOFdtmdBAg== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 9CC8967C5B for <u-boot-concept@u-boot.org>; Fri, 19 Sep 2025 14:15:44 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1758312943; bh=qQp79LUfgM4XJVt895VKN2t4hsAsPc+4uscFCT36/Gw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hIt1N31wleb3hfcuIAWK6FWCexH/e2u55GXZFyF8oCk81jclHa57Xb+W8CvCqt+OI K3ivNaZ/PfH17As6g0ikYf/3MBHlaMMtZNNzee7wpaVcPVH6KmNJU4N/T09a+dBI0t PbCUOJ02ktEoKqdk/wsq1SDRRHtcIxm1ksk9ihLHo7Mmu1A+t9HNxPEnH34L0FExCV V4cK2ffNv9KFKbo8xVa1lrgcn6UrIrWG5zDnGfdW+CWTbHWL+Gnhcw0IhtnWIepI29 +nPsSG/fcMEpAc7QNw36ypI2qD5mGh4PU1YQ8q5m35HSWFXpwgA3wWluohv6beZNnL uLJ1gaNlyLqgA== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 46D6A67B3B; Fri, 19 Sep 2025 14:15:43 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id atcEqDziqrgp; Fri, 19 Sep 2025 14:15:43 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1758312941; bh=GNvKcGBmi8fvuLX5UD5m2T1buTPMYf54JNxBpOPxLWA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uq+7ch689uEJZUPKphjrtwoXXPZC51yqlPiYK6kjolzcixFWxOvFp3y2t20uZaa1w J303u8xVlNqv2eHGiVNIwMOaAyRW9ZwuNn0LREca/UC8B+wY3HGZqmDz5274fvJ+FN io5rUOsyQDJYHUQ4SlfJWFdrsiXxSVYvF3h5Y+r0tUbdqcPnvnC7m1rrtRkJPoYrLS y0Z0gEOpcd9+fGGQd9e0d8eEbjkwRCu0X7/N8PpFKijgwv8E90SC6RgG3GctLowaQY K0v5K2yxrCaKyXyaioiyAvtc6ODabP25DPXpOku6ScdTk+TjyeEHT+qrJLpDiccNsk kU+jE+IFijnNg== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 8AA8467A99; Fri, 19 Sep 2025 14:15:41 -0600 (MDT) From: Simon Glass <sjg@u-boot.org> To: U-Boot Concept <concept@u-boot.org> Date: Fri, 19 Sep 2025 14:14:10 -0600 Message-ID: <20250919201507.4024144-4-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250919201507.4024144-1-sjg@u-boot.org> References: <20250919201507.4024144-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: 2WFLZYEG4LZHXPTOO7IYOITDS4HARDKA X-Message-ID-Hash: 2WFLZYEG4LZHXPTOO7IYOITDS4HARDKA X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Heinrich Schuchardt <xypron.glpk@gmx.de>, Simon Glass <sjg@chromium.org> X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 03/42] video: Correct ops check for nominal, entry save/restore List-Id: Discussion and patches related to U-Boot Concept <concept.u-boot.org> Archived-At: <https://lists.u-boot.org/archives/list/concept@u-boot.org/message/2WFLZYEG4LZHXPTOO7IYOITDS4HARDKA/> List-Archive: <https://lists.u-boot.org/archives/list/concept@u-boot.org/> List-Help: <mailto:concept-request@u-boot.org?subject=help> List-Owner: <mailto:concept-owner@u-boot.org> List-Post: <mailto:concept@u-boot.org> List-Subscribe: <mailto:concept-join@u-boot.org> List-Unsubscribe: <mailto:concept-leave@u-boot.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit |
| Series |
video: Support a cursor more generally
|
|
Commit Message
Simon Glass
Sept. 19, 2025, 8:14 p.m. UTC
From: Simon Glass <sjg@chromium.org> All of these helper functions check the wrong member. Fix them. Signed-off-by: Simon Glass <sjg@chromium.org> Fixes: 9e55d09596a ("video: Allow obtaining the nominal size of a...") Fixes: 9899eef2cb4 ("video: Allow saving and restoring text-entry...") --- drivers/video/vidconsole-uclass.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/vidconsole-uclass.c b/drivers/video/vidconsole-uclass.c index a98344cf9a7..6c5338936e5 100644 --- a/drivers/video/vidconsole-uclass.c +++ b/drivers/video/vidconsole-uclass.c @@ -655,7 +655,7 @@ int vidconsole_nominal(struct udevice *dev, const char *name, uint size, struct vidconsole_ops *ops = vidconsole_get_ops(dev); int ret; - if (ops->measure) { + if (ops->nominal) { ret = ops->nominal(dev, name, size, num_chars, bbox); if (ret != -ENOSYS) return ret; @@ -675,7 +675,7 @@ int vidconsole_entry_save(struct udevice *dev, struct abuf *buf) struct vidconsole_ops *ops = vidconsole_get_ops(dev); int ret; - if (ops->measure) { + if (ops->entry_save) { ret = ops->entry_save(dev, buf); if (ret != -ENOSYS) return ret; @@ -692,7 +692,7 @@ int vidconsole_entry_restore(struct udevice *dev, struct abuf *buf) struct vidconsole_ops *ops = vidconsole_get_ops(dev); int ret; - if (ops->measure) { + if (ops->entry_restore) { ret = ops->entry_restore(dev, buf); if (ret != -ENOSYS) return ret;