From patchwork Fri Sep 19 20:14:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 362 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1758312997; bh=C5SOXqp3yQv8WIvO47efV/FeFx7HjhvgfJ9cALPsOxU=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=dBcJOc0usdn18dkerBxk49D7m0mxRxrWVogchDZkcz2r/aF7P5jnLbzG9HwzzP3cl itrsUwFFLFcb3RF65KGZlXOoCXd3zVgR+Ze2GV28/1dbjoXOwR7RJR5ae67IzzCgiK EGMbKA8ww/wsDBicHhkihQ6tXw4U2hzz92MUzYYIWA9nIRnX8I31hYh9PsAkbQTzFm WmDo0FbkAL+T2BJkXAosz4CWLROWd8bVHbX1bD5slM2nGy/RvbgrGCCbSIgshmGdfL YlMkKYolUD/c1lNCfP++9sWVgkcfaOnfX2Cqxz9GBeDfaHTN43BjbiIiEXdtjxT8aS 5cLBIPVR0dPgQ== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 2FC2767C5B for ; Fri, 19 Sep 2025 14:16:37 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Dz6_uSy0CJJd for ; Fri, 19 Sep 2025 14:16:37 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1758312997; bh=C5SOXqp3yQv8WIvO47efV/FeFx7HjhvgfJ9cALPsOxU=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=dBcJOc0usdn18dkerBxk49D7m0mxRxrWVogchDZkcz2r/aF7P5jnLbzG9HwzzP3cl itrsUwFFLFcb3RF65KGZlXOoCXd3zVgR+Ze2GV28/1dbjoXOwR7RJR5ae67IzzCgiK EGMbKA8ww/wsDBicHhkihQ6tXw4U2hzz92MUzYYIWA9nIRnX8I31hYh9PsAkbQTzFm WmDo0FbkAL+T2BJkXAosz4CWLROWd8bVHbX1bD5slM2nGy/RvbgrGCCbSIgshmGdfL YlMkKYolUD/c1lNCfP++9sWVgkcfaOnfX2Cqxz9GBeDfaHTN43BjbiIiEXdtjxT8aS 5cLBIPVR0dPgQ== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 1F42267BB6 for ; Fri, 19 Sep 2025 14:16:37 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1758312994; bh=N/RVMIx6JnJryjvrNVrzFRFXDuHzj4rameTkCSgLRow=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DFPfgb0mgI6mLr22Zitfnthw09ceBWHYpL9AM+dt8ytPR9lb2sYCDcGSZ1EJVI9rv k3LQ3QjfhvVFsUn8V80XC6ByQLntAPh27DV5an821e8T8Wn0MAQorE1HJ9ajEcUw5y LXlDL14fTsWN6AD5Tkti1i4n9kxMHrujTe6H/Eo2Vzct5Dz1/QzFOI80MHOLHt5BQi oIdmDJEpgG7JkghQLN0sCy2EgVNKkqz4+X3TrFDeziweLoCJ9Ps9SiKW/wHMDAJEyF F3wj68xPpc9eQCfT6DBqF79HKVWhoH5RVX2qL+gqOkzEbnKSH6mTJP8VmnSAYzrJMJ WndStTJSoKdHg== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 24CB367BB6; Fri, 19 Sep 2025 14:16:34 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id B7ivktfYziGy; Fri, 19 Sep 2025 14:16:34 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1758312988; bh=5Ac1ALTj0gKvEXOLmXoxk/HdC9Bdzob7g0jxEpZEthc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HWGxZ+rYJResGfaRBKwjKW9NNOpkrXhkmmmGcSox88oSK1JJHwYkiZkdejJBltC2U khca1OQyrYoHimljU/kIpQ1LR85lE4pNa02rTnceZp/Fj8kCTbKoqHxlubZGj0gDml HY2x9gDMhFdX97CsOBdXhVJdKHxWWsSUAje8WWxNkmtivIGMBSG8sZ1DJBYVHFbcvt ifp3iXXKn+VL7Op5K9ruQTF24Qu3larBjQhkQ9anEeds/MEOh5YPZtg7cVEWH3Okfq yq7dW7ufias3fMyLPTJS8N0PKXF/Yne+X9+fgwjXE1iutuezLtIHjDkOKl0EdDozA2 nE1xjuGyGi3Ug== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id E15BF67B3B; Fri, 19 Sep 2025 14:16:27 -0600 (MDT) From: Simon Glass To: U-Boot Concept Date: Fri, 19 Sep 2025 14:14:27 -0600 Message-ID: <20250919201507.4024144-21-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250919201507.4024144-1-sjg@u-boot.org> References: <20250919201507.4024144-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: ZXYXGLGHPTYD4SIOD75OH3YJT2YGKZA7 X-Message-ID-Hash: ZXYXGLGHPTYD4SIOD75OH3YJT2YGKZA7 X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Heinrich Schuchardt , Simon Glass X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 20/42] video: Update cursor_show() to take a simple pointer List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass We don't need to pass a pointer to a pointer, so just pass a normal pointer. This is simpler to understand. Signed-off-by: Simon Glass --- drivers/video/console_core.c | 6 +++--- drivers/video/console_normal.c | 5 ++--- drivers/video/console_truetype.c | 2 +- drivers/video/vidconsole_internal.h | 2 +- 4 files changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/video/console_core.c b/drivers/video/console_core.c index 36e7f81dc0a..575d0bfe2b8 100644 --- a/drivers/video/console_core.c +++ b/drivers/video/console_core.c @@ -160,7 +160,7 @@ int fill_char_horizontally(uchar *pfont, void **line, struct video_priv *vid_pri return ret; } -int cursor_show(void **line, struct video_priv *vid_priv, uint height, +int cursor_show(void *line, struct video_priv *vid_priv, uint height, bool direction) { int step, line_step, pbytes, ret; @@ -183,10 +183,10 @@ int cursor_show(void **line, struct video_priv *vid_priv, uint height, value = vid_priv->colour_fg; for (int row = 0; row < height; row++) { - dst = *line; + dst = line; for (int col = 0; col < VIDCONSOLE_CURSOR_WIDTH; col++) fill_pixel_and_goto_next(&dst, value, pbytes, step); - *line += line_step; + line += line_step; } return ret; diff --git a/drivers/video/console_normal.c b/drivers/video/console_normal.c index 3865870dcd5..315d3daa5ce 100644 --- a/drivers/video/console_normal.c +++ b/drivers/video/console_normal.c @@ -85,7 +85,7 @@ static int __maybe_unused console_set_cursor_visible(struct udevice *dev, struct console_simple_priv *priv = dev_get_priv(dev); struct video_fontdata *fontdata = priv->fontdata; int pbytes = VNBYTES(vid_priv->bpix); - void *start, *line; + void *start; /* for now, this is not used outside expo */ if (!IS_ENABLED(CONFIG_EXPO)) @@ -98,8 +98,7 @@ static int __maybe_unused console_set_cursor_visible(struct udevice *dev, x -= 1; start = vid_priv->fb + y * vid_priv->line_length + x * pbytes; - line = start; - cursor_show(&line, vid_priv, vc_priv->y_charsize, NORMAL_DIRECTION); + cursor_show(start, vid_priv, vc_priv->y_charsize, NORMAL_DIRECTION); return 0; } diff --git a/drivers/video/console_truetype.c b/drivers/video/console_truetype.c index babab5eb2c3..eedc285903b 100644 --- a/drivers/video/console_truetype.c +++ b/drivers/video/console_truetype.c @@ -1032,7 +1032,7 @@ static int truetype_set_cursor_visible(struct udevice *dev, bool visible, x * VNBYTES(vid_priv->bpix); /* Use the shared cursor drawing function */ - cursor_show(&line, vid_priv, height, NORMAL_DIRECTION); + cursor_show(line, vid_priv, height, NORMAL_DIRECTION); video_damage(dev->parent, x, y, VIDCONSOLE_CURSOR_WIDTH, height); diff --git a/drivers/video/vidconsole_internal.h b/drivers/video/vidconsole_internal.h index 02b73296292..0654a8f98e6 100644 --- a/drivers/video/vidconsole_internal.h +++ b/drivers/video/vidconsole_internal.h @@ -116,7 +116,7 @@ int fill_char_horizontally(uchar *pfont, void **line, struct video_priv *vid_pri * * Return: 0, if success, or else error code. */ -int cursor_show(void **line, struct video_priv *vid_priv, uint height, +int cursor_show(void *line, struct video_priv *vid_priv, uint height, bool direction); /**