From patchwork Mon Sep 15 12:28:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 321 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1757939387; bh=Kal1YGWWq7+eCwv+Mbj2c0zWo7QLc6mSMzs1yiD/jYA=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=VWzk0hhrs8rZzacKEIU7LtvaIHGGmQ7nCTk5frmCNXLYXRxj7dJarl1qDmd5HTKIH RVXdKfNcEoDxJ9HuFLwHjD4kb4lNHXmw/8UiusoSJkHkXBb7QeurY8l8hY7wt+3VQW HqypIDc50jWDKV9XPkn/WPyAW5ydxJD42YE3GJe29+OYXdgt4ifZkkZBRXuBeIa4hf WXDp6vL1B3+5yT7fLdspNqHcRg3udhibWwzMkSqKfUrwNuRUkNEd6uhJ+T0W3cc2PL B2AAqzkYX2NTy4oiptUqBwb0CvogBL1RBS5O7ZAxpdfQCFtwnrTdFINoZZAs/5EffY Vhm3fY+oN2laA== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 7992B67BAC for ; Mon, 15 Sep 2025 06:29:47 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 4fVBzCBWT9aK for ; Mon, 15 Sep 2025 06:29:47 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1757939386; bh=Kal1YGWWq7+eCwv+Mbj2c0zWo7QLc6mSMzs1yiD/jYA=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=q/kgeQVjNcKxBdp2zCLZm56FCIZgv6rl5SXEKXj53NmjqLMIFN8uytkkZB7M1Izl6 w8hC12NhE8ueD8nGbOu8KoPEXTmh7GNUhk4fEHgBYnrvbLUQPt9rfT9+sefmFQQyTL JxpYKWT77GSggb0ljgp8i97/ujWajCL6+V83PEYL/9sQNW347gOt7fE6WXkIPWJQEY HCnjm4YXBDxYkqwsA4o7CTenMs2Q4ntTCdkoNzdIzj8Ya7HBpTwn2AUmTWStmbkNLA SmxLBz1PLr1ll0DOvf/jQQd7JB3zdX5JST0WD5vKtV+G2PB9AtnZtB7KoOysorOkKn tIb+Qfw2lDeew== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 8343B67BC8 for ; Mon, 15 Sep 2025 06:29:46 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1757939385; bh=ZaqQ76f4IjdgrysuAtOjFOs9iXi5mLjl4NBjSR7vpcw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uZKLIYj5uMoTBoKtq6HaRfqvt82kdCL4Wzd66krCqUzeHwiwmlMywoACIo4WfFoPg 5Bn8yoUtspGjv83SLx1+ZR7QafdPoeCRzZfmWPHMQ5Fg+FgS+HoZ5EBigIZo6dw5oU pRjMY3s4PFZQ7ATgV7WYF8SaN12p+bhikDsDq2xEJA5X7ccR8JVJ4FyUocZ3hFTB3l C1njvNvJPlci+Y+yMWW2Lrpa1LsJUZ8hw5R78YYcAxmGkDhkyGoqarkjwImQXRg0Ul N3pWtYGZP4DmCzUmMoypXNfghunu2QV+nS45bizLOgRPjeOJ6MFYj+9fpGhr0ux/S+ I3FBSbJnYj6Yw== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 2EAA367BCC; Mon, 15 Sep 2025 06:29:45 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id HaLDmARqAV77; Mon, 15 Sep 2025 06:29:45 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1757939379; bh=nMXgbSEc9FouWbrA4QaScy3pfCcKajv+2lwm8IRkG2o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FyWb9O5ERTOR5YEHFAgA2cLL8YCTnQDYVH7p+Z0R+Vz9kZsc8q3R+OXoedeAyycRC XwHTI694huh6zdJw8/3W1+gEAQ0WGKgayE2z/wiYbuoV97kL+PQTBvI8fwb1iYO1AH a0j7Iua0ZmHDMaerzttQx3kowKUGfkCY8h96C0d1+NxlzIjuFBiAMEt1oCMMcg4fzJ xJr9KgWNLDR9e5gQLQPFFiaL2wd1Vq/zVLNcz56VAN4uR2hFfg4dg9t1FjgyLisqLu K5aILW9nf04WuTFBjyE24lfccUQYruKHXTKzmiFJnIWV02iWQgi7DRCXm79d7x5ri5 mFnJGl+oCpWHw== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 9A07D67B45; Mon, 15 Sep 2025 06:29:39 -0600 (MDT) From: Simon Glass To: U-Boot Concept Date: Mon, 15 Sep 2025 06:28:39 -0600 Message-ID: <20250915122905.1217249-7-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250915122905.1217249-1-sjg@u-boot.org> References: <20250915122905.1217249-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: 25TCOW2ITUE3N4OYOSVDRAC7CIEAGCW3 X-Message-ID-Hash: 25TCOW2ITUE3N4OYOSVDRAC7CIEAGCW3 X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Heinrich Schuchardt , Simon Glass X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 06/23] expo: Tidy up a few key-related comments List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass Fix up send_key_obj() to mention a missing argument. Add a bit more detail in scene_send_key() to explain what 'processing' means. Signed-off-by: Simon Glass --- boot/scene.c | 1 + boot/scene_internal.h | 3 +++ 2 files changed, 4 insertions(+) diff --git a/boot/scene.c b/boot/scene.c index 0a62dc6212b..50a7dfb22a1 100644 --- a/boot/scene.c +++ b/boot/scene.c @@ -909,6 +909,7 @@ int scene_render(struct scene *scn) * send_key_obj() - Handle a keypress for moving between objects * * @scn: Scene to receive the key + * @obj: Object to receive the key * @key: Key to send (KEYCODE_UP) * @event: Returns resulting event from this keypress * Returns: 0 if OK, -ve on error diff --git a/boot/scene_internal.h b/boot/scene_internal.h index eada390275c..c6f2615a2c5 100644 --- a/boot/scene_internal.h +++ b/boot/scene_internal.h @@ -231,6 +231,9 @@ int scene_render(struct scene *scn); /** * scene_send_key() - set a keypress to a scene * + * This processes the key, taking any action that is needed, such as moving + * between menu items or editing the text in a textline + * * @scn: Scene to receive the key * @key: Key to send (KEYCODE_UP) * @event: Returns resulting event from this keypress